From: Simon Horman <horms@kernel.org>
To: Jitendra Vegiraju <jitendra.vegiraju@broadcom.com>
Cc: netdev@vger.kernel.org, alexandre.torgue@foss.st.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, mcoquelin.stm32@gmail.com,
bcm-kernel-feedback-list@broadcom.com, richardcochran@gmail.com,
ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
john.fastabend@gmail.com, rmk+kernel@armlinux.org.uk,
rohan.g.thomas@altera.com, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org,
andrew+netdev@lunn.ch, sdf@fomichev.me, me@ziyao.cc,
siyanteng@cqsoftware.com.cn,
prabhakar.mahadev-lad.rj@bp.renesas.com,
weishangjuan@eswincomputing.com, wens@kernel.org,
vladimir.oltean@nxp.com, lizhi2@eswincomputing.com,
boon.khai.ng@altera.com, maxime.chevallier@bootlin.com,
chenchuangyu@xiaomi.com, yangtiezhu@loongson.cn,
ovidiu.panait.rb@renesas.com, chenhuacai@kernel.org,
florian.fainelli@broadcom.com, quic_abchauha@quicinc.com
Subject: Re: [PATCH net-next v8 1/6] Add 25GMAC core type to dwmac_core_type enum
Date: Mon, 23 Mar 2026 14:55:26 +0000 [thread overview]
Message-ID: <20260323145526.GA94382@horms.kernel.org> (raw)
In-Reply-To: <20260320211921.1202058-2-jitendra.vegiraju@broadcom.com>
On Fri, Mar 20, 2026 at 02:19:16PM -0700, Jitendra Vegiraju wrote:
> From: Jitendra Vegiraju <jitendra.vegiraju@broadcom.com>
>
> The DW25GMAC is a newer ethernet MAC IP block from Synopsys that introduced
> new DMA architecure called Hyper-DMA. Define a new dwmac_core_type
> enum in include/linux/stmmac.h file.
>
> Signed-off-by: Jitendra Vegiraju <jitendra.vegiraju@broadcom.com>
> ---
> include/linux/stmmac.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h
> index 72febd246bdb..464f4f2e366a 100644
> --- a/include/linux/stmmac.h
> +++ b/include/linux/stmmac.h
> @@ -197,6 +197,7 @@ enum dwmac_core_type {
> DWMAC_CORE_GMAC,
> DWMAC_CORE_GMAC4,
> DWMAC_CORE_XGMAC,
> + DWMAC_CORE_25GMAC,
> };
Hi Jitendra,
W=1 builds warn that this new enum value is not handled in
the switch statement in stmmac_print_actphyif()
This seems to be addressed in patch 2/6.
And I would suggest squashing this patch into that one.
--
pw-bot: changes-requested
next prev parent reply other threads:[~2026-03-23 14:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 21:19 [PATCH net-next v8 0/5] net: stmmac: Add PCI driver support for BCM8958x Jitendra Vegiraju
2026-03-20 21:19 ` [PATCH net-next v8 1/6] Add 25GMAC core type to dwmac_core_type enum Jitendra Vegiraju
2026-03-23 14:55 ` Simon Horman [this message]
2026-03-25 20:25 ` Jitendra Vegiraju
2026-03-20 21:19 ` [PATCH net-next v8 2/6] Add DW25GMAC support in stmmac core driver Jitendra Vegiraju
2026-03-20 21:19 ` [PATCH net-next v8 3/6] Integrate dw25gmac into hwif handling Jitendra Vegiraju
2026-03-20 21:19 ` [PATCH net-next v8 4/6] Add PCI driver support for BCM8958x Jitendra Vegiraju
2026-03-26 16:55 ` Russell King (Oracle)
2026-03-27 18:14 ` Jitendra Vegiraju
2026-03-27 18:14 ` Jitendra Vegiraju
2026-03-27 18:14 ` Jitendra Vegiraju
2026-03-27 18:14 ` Jitendra Vegiraju
2026-03-20 21:19 ` [PATCH net-next v8 5/6] Fix error handling in probe function Jitendra Vegiraju
2026-03-26 16:57 ` Russell King (Oracle)
2026-03-27 18:17 ` Jitendra Vegiraju
2026-03-27 18:17 ` Jitendra Vegiraju
2026-03-20 21:19 ` [PATCH net-next v8 6/6] Add BCM8958x driver to build system Jitendra Vegiraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323145526.GA94382@horms.kernel.org \
--to=horms@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=boon.khai.ng@altera.com \
--cc=bpf@vger.kernel.org \
--cc=chenchuangyu@xiaomi.com \
--cc=chenhuacai@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hawk@kernel.org \
--cc=jitendra.vegiraju@broadcom.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lizhi2@eswincomputing.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=me@ziyao.cc \
--cc=netdev@vger.kernel.org \
--cc=ovidiu.panait.rb@renesas.com \
--cc=pabeni@redhat.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=quic_abchauha@quicinc.com \
--cc=richardcochran@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rohan.g.thomas@altera.com \
--cc=sdf@fomichev.me \
--cc=siyanteng@cqsoftware.com.cn \
--cc=vladimir.oltean@nxp.com \
--cc=weishangjuan@eswincomputing.com \
--cc=wens@kernel.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.