From: Jakub Kicinski <kuba@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
davem@davemloft.net, Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
thomas.petazzoni@bootlin.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: ethtool: pass genl_info to the ethnl parse_request operation
Date: Mon, 23 Mar 2026 20:00:06 -0700 [thread overview]
Message-ID: <20260323200006.7f5aa157@kernel.org> (raw)
In-Reply-To: <20260323095833.136266-1-maxime.chevallier@bootlin.com>
On Mon, 23 Mar 2026 10:58:32 +0100 Maxime Chevallier wrote:
> The .parse_request() ethnl operation extracts the relevant attributes
> from the netlink request to populate the private req_info.
>
> By passing genl_info as a parameter to this callback, we can use
> the GENL_REQ_ATTR_CHECK() macro to check for missing mandatory
> parameters.
>
> This macro has the advantage of returning a better error explanation
> through the netlink_ext_ack struct.
>
> Convert the eeprom ethnl code to this macro, as it's the only command
> yet that has mandatory request parameters.
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Thanks1
next prev parent reply other threads:[~2026-03-24 3:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 9:58 [PATCH net-next] net: ethtool: pass genl_info to the ethnl parse_request operation Maxime Chevallier
2026-03-24 3:00 ` Jakub Kicinski [this message]
2026-03-25 3:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323200006.7f5aa157@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.