Re: [PATCH v5 5/9] drm/panthor: Part ways with drm_gem_shmem_object

[Boris Brezillon <boris.brezillon@collabora.com>]

On Wed, 25 Mar 2026 00:24:14 +0000
Adrián Larumbe <adrian.larumbe@collabora.com> wrote:

> On 09.03.2026 16:11, Boris Brezillon wrote:
>  [...]  
> 
> I suppose this should be drm_dbg_driver() instead.

Will fix in v6.

> 
>  [...]  
> 
> I think you forgot to remove this comment in the last commit in the series.

Oops, again. Will drop it in v6.

> 
> > +	ret = panthor_gem_backing_get_pages_locked(bo);
> > +	if (ret)
> > +		return ERR_PTR(ret);
> > +
> > +	sgt = drm_prime_pages_to_sg(bo->base.dev, bo->backing.pages,
> > +				    bo->base.size >> PAGE_SHIFT);  
> 
> I've always wondered why this function is called drm_prime_pages_to_sg() and not just
> drm_gem_pages_to_sg(), since it's not only used for populating exported prime objects,
> and also I suspect it might better fit into drivers/gpu/drm/drm_gem.c (same place as
> drm_gem_get_pages). Anyway, this is probably beyond the point of this series.

I'll keep it a prime helper for now. Feel to propose a patch to
rename/move this helper though.