From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E150A31F99C for ; Wed, 25 Mar 2026 22:08:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774476525; cv=none; b=Vd3Kj52KwA3bQg/SL0k2Qj6iP0B7zH2VDCr1kKrACu6m1f4IbwShubuUBIxievWXjlEUFaaXBpflhppRFqvT6ZIknezFUf70B6ZGRCzDyCCmadQY7k4aHuE7VfPhm4RpE6DQUjEtED4s4M/5Qonb5ueZxma4NHVC6fG63i+ZBhU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774476525; c=relaxed/simple; bh=cZ8W4E2I+3ryRIOR4qT6z1fxcP7gy/iwVmNdeBRL8Kk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TehxlyBonifX1w2DEIuP8Q2zABIIXLMWncSfDsYg2hZrMkjlnIwvbWmaxdGS/wO3PBToXI+XuSQYd0Ay7Oz1A7Sf0Lc+36kio+suk8oDj6ZlY23Po4v5J+qu0Fvz0OumLlis8MDwRw5m+k0tmVJpKggZASmGdWLEsqNXyobiENo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zabbo.net; spf=pass smtp.mailfrom=zabbo.net; dkim=pass (1024-bit key) header.d=zabbo.net header.i=@zabbo.net header.b=jjJ3bz/W; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zabbo.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zabbo.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=zabbo.net header.i=@zabbo.net header.b="jjJ3bz/W" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2b06d33e84cso1591305ad.3 for ; Wed, 25 Mar 2026 15:08:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zabbo.net; s=google; t=1774476523; x=1775081323; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=W/r/qjvKeYM4dU3Z/wisedB/mdqTcGSPi5ncGmayi3o=; b=jjJ3bz/WadLExK4sMJ11p7kVJN7KxYhu/1582QGu5+APDyjt+4QJZq3T4kFUfMRuh8 +qu0rMLvgY6182paPP6R37nfJydPF9agmjSllvR1UqAeV3CiRrhij4wFMfZDesJdT6RH nEGl9DlisoucbzpM815LAoWlhFjDvZ/ppsv7g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774476523; x=1775081323; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W/r/qjvKeYM4dU3Z/wisedB/mdqTcGSPi5ncGmayi3o=; b=fiZMGmwyAnqsPJAVKoZJJOlMzrVZTudAMDLu5E58/+rQefcedZKWM5YscCc43TQ4lA a/2Umrh+MDxMQVbQQYs9NCB8QB6db6gHBgabTKH67LtF539CK1qGKAMHgw4L3eFYpxB8 pC6L4/pwNuxcUJsR6iaWDAT5qJMA9ZxremzKOM7zUO0Z6JQxEAAbkOhWxHIjAk2AaMjW C4szLsjC8se+AvxrTeo0uNh8N3JV1euAuENrhGxLJt1ny9GU3osQW842cX9yQhMfBZbv +AqQ+76znzEo9TjLzyiPTbxoxDpXm3Jpa5WineErw26C8+L3pwLM9VXhLkrRPUisA6wf e7aA== X-Gm-Message-State: AOJu0YwiYVq3cERcOmmjZQ4pZKZzPInPldBfmyYOMrL0sMFtPweEFT3A 4GluZgtSM8beyMp3DYVp0+d3qOb3LZW/2uhM0yYHSFwDGF6R+el7NcL8PD4k68MovmThKeEmf7d OGpiw X-Gm-Gg: ATEYQzzfdpdJX9DEGv9br8EGm+UPlCDj6DmfGRYcA7kzc0EKNgphpGD930pur8GirtM lsYa+H3iy+2qidzidEL6hclEO/TH/j/eBvVVzgdAEwzs/cfSJjyoUHycicF0mdRMvpqeJxc9FtJ /YqVweyXOKhcSG5cboA3U0yxLcERzCejmo5XvK31+1rXMXQujHYmUmUpB2texZiPz6X76RVjXMO hGgMM32xB8azP9h+Lazvijq8Ytc1yIPvRepaJsf7pnzYXTkHzbz8Z1HaRErn+MzDWjvedE3geJi kKV8jM203XBZW4LKGcvPvT93cHuUKev6gM4jhpMxUM+j0vnp7NHqEB0UuE9XVDDWko6b4oYhzaD iSEmLQ3t7VUGmBYtsJHFYHoaKWrlfLMH8dpdMHhndQT5vzKu64kjxaadBmoGvMC/BHt+0b1VnWH +ZFQNPE89NaQ== X-Received: by 2002:a17:902:c942:b0:2b0:66bc:22a3 with SMTP id d9443c01a7336-2b0b09a0998mr56847985ad.10.1774476523195; Wed, 25 Mar 2026 15:08:43 -0700 (PDT) Received: from localhost ([50.39.133.72]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0bc881e9csm9003665ad.42.2026.03.25.15.08.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 15:08:42 -0700 (PDT) Date: Wed, 25 Mar 2026 15:08:42 -0700 From: Zach Brown To: Valerie Aurora Cc: rpdfs-devel@lists.linux.dev Subject: Re: [PATCH 2/3] rpdfs: Initialize block seqlock before using it and fix memleak Message-ID: <20260325220842.GE990991@localhost.localdomain> References: <20260319093727.15343-1-val@versity.com> <20260319093727.15343-3-val@versity.com> Precedence: bulk X-Mailing-List: rpdfs-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260319093727.15343-3-val@versity.com> On Thu, Mar 19, 2026 at 10:37:26AM +0100, Valerie Aurora wrote: > alloc_data_page() was using bk->seqlock before it was > initialized. Move the lock initializations to before the > alloc_data_page() call and free the block struct if it fails. > > Signed-off-by: Valerie Aurora Applied, thanks! - z (donning my favourite brown paper bag over here)