From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: drivers/gpu/drm/v3d/v3d_irq.c:288 v3d_irq_init() warn: missing unwind goto?
Date: Thu, 26 Mar 2026 03:09:54 +0800 [thread overview]
Message-ID: <202603260221.BH1bmAti-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: "Maíra Canal" <mcanal@igalia.com>
CC: "Juan A. Suarez" <jasuarez@igalia.com>
CC: Iago Toral Quiroga <itoral@igalia.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: bbeb83d3182abe0d245318e274e8531e5dd7a948
commit: 226862f50a7a88e4e4de9abbf36c64d19acd6fd0 drm/v3d: Disable interrupts before resetting the GPU
date: 9 months ago
:::::: branch date: 19 hours ago
:::::: commit date: 9 months ago
config: openrisc-randconfig-r071-20260325 (https://download.01.org/0day-ci/archive/20260326/202603260221.BH1bmAti-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 14.3.0
smatch: v0.5.0-9004-gb810ac53
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202603260221.BH1bmAti-lkp@intel.com/
smatch warnings:
drivers/gpu/drm/v3d/v3d_irq.c:288 v3d_irq_init() warn: missing unwind goto?
vim +288 drivers/gpu/drm/v3d/v3d_irq.c
57692c94dcbe99 Eric Anholt 2018-04-30 259
fc22771547e7e8 Eric Anholt 2019-03-08 260 int
57692c94dcbe99 Eric Anholt 2018-04-30 261 v3d_irq_init(struct v3d_dev *v3d)
57692c94dcbe99 Eric Anholt 2018-04-30 262 {
226862f50a7a88 Maíra Canal 2025-06-28 263 int irq, ret, core;
57692c94dcbe99 Eric Anholt 2018-04-30 264
57692c94dcbe99 Eric Anholt 2018-04-30 265 INIT_WORK(&v3d->overflow_mem_work, v3d_overflow_mem_work);
57692c94dcbe99 Eric Anholt 2018-04-30 266
57692c94dcbe99 Eric Anholt 2018-04-30 267 /* Clear any pending interrupts someone might have left around
57692c94dcbe99 Eric Anholt 2018-04-30 268 * for us.
57692c94dcbe99 Eric Anholt 2018-04-30 269 */
57692c94dcbe99 Eric Anholt 2018-04-30 270 for (core = 0; core < v3d->cores; core++)
0ad5bc1ce4634c Iago Toral Quiroga 2023-10-31 271 V3D_CORE_WRITE(core, V3D_CTL_INT_CLR, V3D_CORE_IRQS(v3d->ver));
0ad5bc1ce4634c Iago Toral Quiroga 2023-10-31 272 V3D_WRITE(V3D_HUB_INT_CLR, V3D_HUB_IRQS(v3d->ver));
57692c94dcbe99 Eric Anholt 2018-04-30 273
226862f50a7a88 Maíra Canal 2025-06-28 274 irq = platform_get_irq_optional(v3d_to_pdev(v3d), 1);
226862f50a7a88 Maíra Canal 2025-06-28 275 if (irq == -EPROBE_DEFER)
226862f50a7a88 Maíra Canal 2025-06-28 276 return irq;
226862f50a7a88 Maíra Canal 2025-06-28 277 if (irq > 0) {
226862f50a7a88 Maíra Canal 2025-06-28 278 v3d->irq[V3D_CORE_IRQ] = irq;
226862f50a7a88 Maíra Canal 2025-06-28 279
226862f50a7a88 Maíra Canal 2025-06-28 280 ret = devm_request_irq(v3d->drm.dev, v3d->irq[V3D_CORE_IRQ],
eea9b97b450460 Eric Anholt 2019-03-08 281 v3d_irq, IRQF_SHARED,
eea9b97b450460 Eric Anholt 2019-03-08 282 "v3d_core0", v3d);
eea9b97b450460 Eric Anholt 2019-03-08 283 if (ret)
eea9b97b450460 Eric Anholt 2019-03-08 284 goto fail;
226862f50a7a88 Maíra Canal 2025-06-28 285
226862f50a7a88 Maíra Canal 2025-06-28 286 irq = platform_get_irq(v3d_to_pdev(v3d), 0);
226862f50a7a88 Maíra Canal 2025-06-28 287 if (irq < 0)
226862f50a7a88 Maíra Canal 2025-06-28 @288 return irq;
226862f50a7a88 Maíra Canal 2025-06-28 289 v3d->irq[V3D_HUB_IRQ] = irq;
226862f50a7a88 Maíra Canal 2025-06-28 290
226862f50a7a88 Maíra Canal 2025-06-28 291 ret = devm_request_irq(v3d->drm.dev, v3d->irq[V3D_HUB_IRQ],
57692c94dcbe99 Eric Anholt 2018-04-30 292 v3d_hub_irq, IRQF_SHARED,
57692c94dcbe99 Eric Anholt 2018-04-30 293 "v3d_hub", v3d);
fc22771547e7e8 Eric Anholt 2019-03-08 294 if (ret)
fc22771547e7e8 Eric Anholt 2019-03-08 295 goto fail;
eea9b97b450460 Eric Anholt 2019-03-08 296 } else {
eea9b97b450460 Eric Anholt 2019-03-08 297 v3d->single_irq_line = true;
fc22771547e7e8 Eric Anholt 2019-03-08 298
226862f50a7a88 Maíra Canal 2025-06-28 299 irq = platform_get_irq(v3d_to_pdev(v3d), 0);
226862f50a7a88 Maíra Canal 2025-06-28 300 if (irq < 0)
226862f50a7a88 Maíra Canal 2025-06-28 301 return irq;
226862f50a7a88 Maíra Canal 2025-06-28 302 v3d->irq[V3D_CORE_IRQ] = irq;
226862f50a7a88 Maíra Canal 2025-06-28 303
226862f50a7a88 Maíra Canal 2025-06-28 304 ret = devm_request_irq(v3d->drm.dev, v3d->irq[V3D_CORE_IRQ],
57692c94dcbe99 Eric Anholt 2018-04-30 305 v3d_irq, IRQF_SHARED,
eea9b97b450460 Eric Anholt 2019-03-08 306 "v3d", v3d);
57692c94dcbe99 Eric Anholt 2018-04-30 307 if (ret)
fc22771547e7e8 Eric Anholt 2019-03-08 308 goto fail;
eea9b97b450460 Eric Anholt 2019-03-08 309 }
57692c94dcbe99 Eric Anholt 2018-04-30 310
57692c94dcbe99 Eric Anholt 2018-04-30 311 v3d_irq_enable(v3d);
fc22771547e7e8 Eric Anholt 2019-03-08 312 return 0;
fc22771547e7e8 Eric Anholt 2019-03-08 313
fc22771547e7e8 Eric Anholt 2019-03-08 314 fail:
fc22771547e7e8 Eric Anholt 2019-03-08 315 if (ret != -EPROBE_DEFER)
bc662528e29ae7 Simona Vetter 2020-04-15 316 dev_err(v3d->drm.dev, "IRQ setup failed: %d\n", ret);
fc22771547e7e8 Eric Anholt 2019-03-08 317 return ret;
57692c94dcbe99 Eric Anholt 2018-04-30 318 }
57692c94dcbe99 Eric Anholt 2018-04-30 319
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2026-03-25 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 19:09 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-12-14 2:23 drivers/gpu/drm/v3d/v3d_irq.c:288 v3d_irq_init() warn: missing unwind goto? kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202603260221.BH1bmAti-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.