All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yixun Lan <dlan@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dts: riscv: spacemit: k3: add P1 PMIC regulator tree
Date: Thu, 26 Mar 2026 15:27:57 +0800	[thread overview]
Message-ID: <20260326072757-GKG777612@kernel.org> (raw)
In-Reply-To: <4377b748-9604-4470-931a-3b970e213735@kernel.org>

Hi Krzysztof, 

On 08:15 Thu 26 Mar     , Krzysztof Kozlowski wrote:
> On 26/03/2026 08:14, Yixun Lan wrote:
> > Hi Krzysztof, 
> > 
> > On 08:02 Thu 26 Mar     , Krzysztof Kozlowski wrote:
> >> On 26/03/2026 00:48, Yixun Lan wrote:
> >>>>
> >>>>
> >>>>> +
> >>>>> +	reg_aux_vcc3v3: regulator-aux-vcc3v3 {
> >>>>
> >>>> This is even more pointless because there is no user. Dead code.
> >>>>
> >>> reg_aux_vcc3v3 is used by various devices, but I can drop it too,
> >>
> >> Which ones?
> > To be precise, I should say reg_aux_vcc3v3 will be used by various
> > devices in future, but not in current device tree of mainline, e.g, 
> > USB2.0, PCIe, 10G Ethernet, Audio..
> 
> So it is not used by various devices. I just wrote - THERE IS NO USER.
Ok, I got your point, thanks for the review

-- 
Yixun Lan (dlan)

WARNING: multiple messages have this Message-ID (diff)
From: Yixun Lan <dlan@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dts: riscv: spacemit: k3: add P1 PMIC regulator tree
Date: Thu, 26 Mar 2026 15:27:57 +0800	[thread overview]
Message-ID: <20260326072757-GKG777612@kernel.org> (raw)
In-Reply-To: <4377b748-9604-4470-931a-3b970e213735@kernel.org>

Hi Krzysztof, 

On 08:15 Thu 26 Mar     , Krzysztof Kozlowski wrote:
> On 26/03/2026 08:14, Yixun Lan wrote:
> > Hi Krzysztof, 
> > 
> > On 08:02 Thu 26 Mar     , Krzysztof Kozlowski wrote:
> >> On 26/03/2026 00:48, Yixun Lan wrote:
> >>>>
> >>>>
> >>>>> +
> >>>>> +	reg_aux_vcc3v3: regulator-aux-vcc3v3 {
> >>>>
> >>>> This is even more pointless because there is no user. Dead code.
> >>>>
> >>> reg_aux_vcc3v3 is used by various devices, but I can drop it too,
> >>
> >> Which ones?
> > To be precise, I should say reg_aux_vcc3v3 will be used by various
> > devices in future, but not in current device tree of mainline, e.g, 
> > USB2.0, PCIe, 10G Ethernet, Audio..
> 
> So it is not used by various devices. I just wrote - THERE IS NO USER.
Ok, I got your point, thanks for the review

-- 
Yixun Lan (dlan)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2026-03-26  7:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25  9:56 [PATCH] dts: riscv: spacemit: k3: add P1 PMIC regulator tree Yixun Lan
2026-03-25  9:56 ` Yixun Lan
2026-03-25 13:54 ` Krzysztof Kozlowski
2026-03-25 13:54   ` Krzysztof Kozlowski
2026-03-25 23:48   ` Yixun Lan
2026-03-25 23:48     ` Yixun Lan
2026-03-26  7:02     ` Krzysztof Kozlowski
2026-03-26  7:02       ` Krzysztof Kozlowski
2026-03-26  7:14       ` Yixun Lan
2026-03-26  7:14         ` Yixun Lan
2026-03-26  7:15         ` Krzysztof Kozlowski
2026-03-26  7:15           ` Krzysztof Kozlowski
2026-03-26  7:27           ` Yixun Lan [this message]
2026-03-26  7:27             ` Yixun Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260326072757-GKG777612@kernel.org \
    --to=dlan@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.