From: Jakub Kicinski <kuba@kernel.org>
To: fffsqian@163.com
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, shuah@kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Qingshuang Fu <fuqingshuang@kylinos.cn>
Subject: Re: [PATCH v2] selftests: net: broadcast_pmtu: Fix false failure from incorrect ping exit code logic
Date: Thu, 26 Mar 2026 07:58:01 -0700 [thread overview]
Message-ID: <20260326075801.41e83b35@kernel.org> (raw)
In-Reply-To: <20260326094219.2160239-1-fffsqian@163.com>
On Thu, 26 Mar 2026 17:42:19 +0800 fffsqian@163.com wrote:
> The broadcast_pmtu.sh test verifies that broadcast route MTU is respected,
> but it uses an incorrect criteria for test success: it relies solely on
> the ping command's exit code, which leads to false failures.
Still failing, does it pass for you?
Also please read this -
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#tl-dr
prev parent reply other threads:[~2026-03-26 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 9:42 [PATCH v2] selftests: net: broadcast_pmtu: Fix false failure from incorrect ping exit code logic fffsqian
2026-03-26 14:58 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326075801.41e83b35@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fffsqian@163.com \
--cc=fuqingshuang@kylinos.cn \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.