Re: [LTP] [PATCH v2] userfaultfd: Minor fixes

[Petr Vorel <pvorel@suse.cz>]

> On 3/26/26 9:38 AM, Andrea Cervesato wrote:
> > Hi ricardo,

> > > +	if (page) {
> > > +		SAFE_MUNMAP(page, page_size);
> > > +		SAFE_MUNMAP(copy_page, page_size);
> > > +		page = NULL;
> > > +	}
> > This is gonna TBROK when copy_page is NULL. The same apply to all other
> > tests which are affected by the same bug.

> Fixed in v3.

> BTW, we have a minor difference in tests:

> $ diff userfaultfd03.c userfaultfd06.c

> <         tst_brk(TBROK | TERRNO, "Received unexpected UFFD_EVENT %d",
> msg.event);
> ---
> >         tst_brk(TFAIL, "Received unexpected UFFD_EVENT %d", msg.event);

> I think we should have TFAIL, WDYT?

Yes, IMHO TFAIL.

Regards other cleanup: I again double checked if some test could be merged with
others but haven't found any.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp