From: Petr Vorel <pvorel@suse.cz>
To: Martin Cermak <mcermak@redhat.com>
Cc: valgrind-developers@lists.sourceforge.net, ltp@lists.linux.it
Subject: Re: [LTP] [Valgrind-developers] [RFC PATCH 1/1] LTP tests: Run without LTP_REPRODUCIBLE_OUTPUT=1
Date: Thu, 26 Mar 2026 17:42:23 +0100 [thread overview]
Message-ID: <20260326164223.GB11710@pevik> (raw)
In-Reply-To: <20260325145243.daqrazagomckexgj@lida.tpb.lab.eng.brq.redhat.com>
> On Wed 2026-03-25 14:57 , Petr Vorel wrote:
> > > Hi!
> > > > > > That sounds reasonable to me. Which one would you prefer to
> > > > > > keep? I'm inclined to suggest keeping LTP_REPRODUCIBLE_OUTPUT
> > > > > > and dropping LTP_QUIET but no really strong preference on my
> > > > > > side. Thoughts?
> > > > > Maybe we can finally implement proper debug levels in LTP. E.g. hide
> > > > > TINFO and TWARN messages with debug level 0 and default to debug level
> > > > > 1. With debug level 2 we would show TDEBUG as well and with debug level
> > > > > 3 we would show TDEBUG messages for library too.
> > > > That would require running valgrind tests with something like
> > > > debug level -1 ;) because what LTP_REPRODUCIBLE_OUTPUT actually
> > > > does is that it hides testrun specific output like e.g. testrun
> > > > specific addresses, temporary file names etc.
> > > The LTP_REPRODUCIBLE_OUTPUT would have to stay, but the LTP_QUITE would
> > > have been replaced by different debug levels.
> > I thought just remove LTP_QUITE and control everything with
> > LTP_REPRODUCIBLE_OUTPUT.
> Sounds fine, Petr. For Valgrind testing, the functionality of
> both LTP_REPRODUCIBLE_OUTPUT and LTP_QUIET is useful. But
> there's no need to control the two features independently.
> Merging the functionality under one controlling env var works
> perfectly fine from the Valgrind testsuite perspective.
I prefer to keep LTP_REPRODUCIBLE_OUTPUT as variable name (with merged
functionality of both). 1) We have LTP_ENABLE_DEBUG, so one would expect
LTP_ENABLE_DEBUG and LTP_QUIET are mutually exclusive.
2) IMHO it's more about the reproducibility of the results.
Kind regards,
Petr
> Thanks,
> Martin
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-03-26 16:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 21:08 [LTP] [RFC PATCH 1/1] LTP tests: Run without LTP_REPRODUCIBLE_OUTPUT=1 Petr Vorel
2026-03-24 13:18 ` Cyril Hrubis
2026-03-24 14:09 ` [LTP] [Valgrind-developers] " Martin Cermak via ltp
2026-03-25 9:06 ` Martin Cermak via ltp
2026-03-25 9:10 ` Petr Vorel
2026-03-25 9:21 ` Martin Cermak via ltp
2026-03-25 9:37 ` Cyril Hrubis
2026-03-25 9:42 ` Martin Cermak via ltp
2026-03-25 9:57 ` Cyril Hrubis
2026-03-25 10:01 ` Martin Cermak via ltp
2026-03-25 13:57 ` Petr Vorel
2026-03-25 14:52 ` Martin Cermak via ltp
2026-03-26 16:42 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326164223.GB11710@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mcermak@redhat.com \
--cc=valgrind-developers@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.