All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xin Wang <x.wang@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Xin Wang <x.wang@intel.com>
Subject: [PATCH v2] drm/xe: use the asid based invalidation
Date: Thu, 26 Mar 2026 15:18:30 -0700	[thread overview]
Message-ID: <20260326221831.352798-1-x.wang@intel.com> (raw)

Experiment only not for review

Signed-off-by: Xin Wang <x.wang@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_tlb_inval.c | 11 ++++++++++-
 drivers/gpu/drm/xe/xe_module.c        |  4 ++++
 drivers/gpu/drm/xe/xe_module.h        |  1 +
 drivers/gpu/drm/xe/xe_pci.c           |  6 ++++++
 4 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_tlb_inval.c b/drivers/gpu/drm/xe/xe_guc_tlb_inval.c
index ced58f46f846..bccb105af9a7 100644
--- a/drivers/gpu/drm/xe/xe_guc_tlb_inval.c
+++ b/drivers/gpu/drm/xe/xe_guc_tlb_inval.c
@@ -16,6 +16,7 @@
 #include "xe_guc_tlb_inval.h"
 #include "xe_force_wake.h"
 #include "xe_mmio.h"
+#include "xe_module.h"
 #include "xe_sa.h"
 #include "xe_tlb_inval.h"
 #include "xe_vm.h"
@@ -174,7 +175,15 @@ static int send_tlb_inval_ppgtt(struct xe_guc *guc, u32 seqno, u64 start,
 	action[len++] = !prl_sa ? seqno : TLB_INVALIDATION_SEQNO_INVALID;
 	if (!gt_to_xe(gt)->info.has_range_tlb_inval ||
 	    length > MAX_RANGE_TLB_INVALIDATION_LENGTH) {
-		action[len++] = MAKE_INVAL_OP(XE_GUC_TLB_INVAL_FULL);
+		if (xe_modparam.enable_asid_tlb_inval) {
+			action[len++] = MAKE_INVAL_OP_FLUSH(XE_GUC_TLB_INVAL_PAGE_SELECTIVE, true);
+			action[len++] = id;
+			action[len++] = 1;
+			action[len++] = 0;
+			action[len++] = 0;
+		} else {
+			action[len++] = MAKE_INVAL_OP(XE_GUC_TLB_INVAL_FULL);
+		}
 	} else {
 		u64 normalize_len = normalize_invalidation_range(gt, &start,
 								 &end);
diff --git a/drivers/gpu/drm/xe/xe_module.c b/drivers/gpu/drm/xe/xe_module.c
index 4cb578182912..fdfae7fbb231 100644
--- a/drivers/gpu/drm/xe/xe_module.c
+++ b/drivers/gpu/drm/xe/xe_module.c
@@ -83,6 +83,10 @@ MODULE_PARM_DESC(wedged_mode,
 		 "Module's default policy for the wedged mode (0=never, 1=upon-critical-error, 2=upon-any-hang-no-reset "
 		 "[default=" XE_DEFAULT_WEDGED_MODE_STR "])");
 
+module_param_named_unsafe(enable_asid_tlb_inval, xe_modparam.enable_asid_tlb_inval, bool, 0600);
+MODULE_PARM_DESC(enable_asid_tlb_inval,
+		 "Use ASID-based page-selective TLB invalidation instead of full invalidation (experimental)");
+
 static int xe_check_nomodeset(void)
 {
 	if (drm_firmware_drivers_only())
diff --git a/drivers/gpu/drm/xe/xe_module.h b/drivers/gpu/drm/xe/xe_module.h
index 79cb9639c0f3..648ac49fef76 100644
--- a/drivers/gpu/drm/xe/xe_module.h
+++ b/drivers/gpu/drm/xe/xe_module.h
@@ -23,6 +23,7 @@ struct xe_modparam {
 #endif
 	unsigned int wedged_mode;
 	u32 svm_notifier_size;
+	bool enable_asid_tlb_inval;
 };
 
 extern struct xe_modparam xe_modparam;
diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index 189e2a1c29f9..f47e96aa5967 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -955,6 +955,12 @@ static int xe_info_init(struct xe_device *xe,
 		xe->info.has_device_atomics_on_smem = 1;
 
 	xe->info.has_range_tlb_inval = graphics_desc->has_range_tlb_inval;
+	if (xe_modparam.enable_asid_tlb_inval)
+		xe->info.has_range_tlb_inval = 0;
+	xe_info(xe, "ASID-based TLB invalidation %s (modparam=%u, has_range_tlb_inval=%u)\n",
+		xe_modparam.enable_asid_tlb_inval ? "enabled" : "disabled",
+		xe_modparam.enable_asid_tlb_inval,
+		xe->info.has_range_tlb_inval);
 	xe->info.has_ctx_tlb_inval = graphics_desc->has_ctx_tlb_inval;
 	xe->info.has_usm = graphics_desc->has_usm;
 	xe->info.has_64bit_timestamp = graphics_desc->has_64bit_timestamp;
-- 
2.43.0


             reply	other threads:[~2026-03-26 22:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26 22:18 Xin Wang [this message]
2026-03-26 22:41 ` ✓ CI.KUnit: success for drm/xe: use the asid based invalidation (rev2) Patchwork
2026-03-26 23:26 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-27 17:09 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260326221831.352798-1-x.wang@intel.com \
    --to=x.wang@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.