From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02CA239903A for ; Fri, 27 Mar 2026 06:24:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774592700; cv=none; b=Xh2rywPCbZrOKcoVkrLW1zyTZckpXQ0rxbx2eTmmiekor3O5++G+yv2szd/zhM9QFqQHmeuXl6HLc5EvF2jlMrC12YOZOEsAQX137xvfMgJf0DgT56DpvIWafD6Gc6zH4ndyUmahNOYXGK6itMC0mXT4Q+KWHM1JqivFd0mok/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774592700; c=relaxed/simple; bh=OwAl3m9zcDO/MK+ooa8uf/C497uAonrcIGTodd/fZBY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F4AAJTUS1xfFBWnWoZcKUeh3l8llcmw6rz94iOTYC8napdyJpu+vexYaMJxvoDOLTqPg+39hqZuyxGCrn5BlXrCSlVj8Bb2ibvQTqOJjDq/xNBq7wbEbrrEaMLoDlL8cmDf4foszAPQrc6QA9dPklwjnVT811UbL1OxHdZhWj9Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NPsfOUDT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NPsfOUDT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 129BFC19423; Fri, 27 Mar 2026 06:24:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774592699; bh=OwAl3m9zcDO/MK+ooa8uf/C497uAonrcIGTodd/fZBY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NPsfOUDTLl2vsyVjFStPZn+mJsLhro9zFFbOLXMy/7hOQvqhlA81HCTjgD8LNX5JL jd2jlKIdK9T+BZ6ygOhqETYRmYLSiR8DWYMvvD3quTTxRsGYni9Kk8kZrVND6lurtd tBoZAHbcZZBDEEAuKOOBfZwXZDCzrRum03IP6AuY= Date: Fri, 27 Mar 2026 07:24:35 +0100 From: Greg KH To: Carlos Llamas Cc: pedro.montes.alcalde@gmail.com, aliceryhl@google.com, arve@android.com, christian@brauner.io, linux-kernel@vger.kernel.org, tkjos@android.com, kernel-team@android.com Subject: Re: [PATCH v2] rust_binder: Downgrade startup warning to info Message-ID: <2026032712-dimple-myself-24a7@gregkh> References: <20260326230713.3633842-1-cmllamas@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260326230713.3633842-1-cmllamas@google.com> On Thu, Mar 26, 2026 at 11:07:12PM +0000, Carlos Llamas wrote: > From: Pedro Montes Alcalde > > The "Loaded Rust Binder." message is logged during normal > initialization and does not indicate an error/warning condition. > > Logging it as a warning creates unnecessary noise and may > mislead developers when inspecting logs. Log it as info instead > > Signed-off-by: Pedro Montes Alcalde > Acked-by: Carlos Llamas > Signed-off-by: Carlos Llamas > --- > v2: fixed patch formatting, added tags. > > drivers/android/binder/rust_binder_main.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/android/binder/rust_binder_main.rs b/drivers/android/binder/rust_binder_main.rs > index aa5f2a75adb4..3907291a33c9 100644 > --- a/drivers/android/binder/rust_binder_main.rs > +++ b/drivers/android/binder/rust_binder_main.rs > @@ -292,7 +292,7 @@ fn init(_module: &'static kernel::ThisModule) -> Result { > // SAFETY: The module initializer never runs twice, so we only call this once. > unsafe { crate::context::CONTEXTS.init() }; > > - pr_warn!("Loaded Rust Binder."); > + pr_info!("Loaded Rust Binder."); When drivers work properly, they are quiet, so why print anything out at all here? thanks, greg k-h