All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Shivam Gupta <shivgupta751157@gmail.com>
Cc: johan@kernel.org, elder@kernel.org, vaibhav.sr@gmail.com,
	mgreer@animalcreek.com, greybus-dev@lists.linaro.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: audio_manager: Add missing newline to sysfs_emit outputs
Date: Sat, 28 Mar 2026 07:02:27 +0100	[thread overview]
Message-ID: <2026032850-riverbed-distant-f96b@gregkh> (raw)
In-Reply-To: <20260328044527.10489-1-shivgupta751157@gmail.com>

On Sat, Mar 28, 2026 at 10:15:27AM +0530, Shivam Gupta wrote:
> sysfs_emit outputs in audio_manager_module.c do not include a terminating
> newline, which is required for proper sysfs formatting.
> 
> Add newline characters to all sysfs_emit format strings.
> 
> Signed-off-by: Shivam Gupta <shivgupta751157@gmail.com>

You just changed the user/kernel api here, are you _sure_ it is ok to do
so?  What tools just broke or were used to test this?  What tool asked
you to make this change?

thanks,

greg k-h

  reply	other threads:[~2026-03-28  6:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-28  4:45 [PATCH] staging: greybus: audio_manager: Add missing newline to sysfs_emit outputs Shivam Gupta
2026-03-28  6:02 ` Greg KH [this message]
2026-03-28 14:51   ` Hadi Chokr
2026-03-30  9:35     ` Dan Carpenter
2026-03-30  9:35 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026032850-riverbed-distant-f96b@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=elder@kernel.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mgreer@animalcreek.com \
    --cc=shivgupta751157@gmail.com \
    --cc=vaibhav.sr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.