From: Nathan Chancellor <nathan@kernel.org>
To: Kees Cook <kees@kernel.org>
Cc: Justin Stitt <justinstitt@google.com>,
Nicolas Schier <nsc@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] kbuild: add -fdiagnostics-show-inlining-chain for FORTIFY_SOURCE
Date: Mon, 30 Mar 2026 07:36:04 +0200 [thread overview]
Message-ID: <20260330053604.GA879042@ax162> (raw)
In-Reply-To: <202603292059.01A4CB14F2@keescook>
On Sun, Mar 29, 2026 at 08:59:51PM -0700, Kees Cook wrote:
> On Fri, Mar 27, 2026 at 03:29:18PM -0700, Justin Stitt wrote:
> > On Fri, Mar 27, 2026 at 3:18 PM Nathan Chancellor <nathan@kernel.org> wrote:
> > The compile time impact is not measurable (within expected noise). The
> > peak memory usage may increase by somewhere in the 0.5% to 1.5% range
> > depending on build configuration.
> >
> > I bundled this under fortify to limit initial impact as its had
> > virtually no real-world testing and may produce unhelpful diagnostic
> > notes under its heuristic mode. I don't expect folks to use `-g1` in
> > the kernel (which would enable full-proof diagnostic notes).
> >
> > > If not, maybe worth adding a Kconfig option that is force selected by FORTIFY_SOURCE with
> > > clang or can be optionally enabled by a user?
> >
> > I'll defer to you on this one. We could add
> > CONFIG_SHOW_INLINING_CHAIN_NOTES or something similar?
>
> I would prefer to just unconditionally enable this when it is supported.
Agreed. It cannot possibly be worse than the status quo, right? :) This
feels very similar to -fdiagnostics-show-context=2, so maybe add it near
there?
Cheers,
Nathan
next prev parent reply other threads:[~2026-03-30 5:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 21:59 [PATCH] kbuild: add -fdiagnostics-show-inlining-chain for FORTIFY_SOURCE Justin Stitt
2026-03-27 22:18 ` Nathan Chancellor
2026-03-27 22:29 ` Justin Stitt
2026-03-30 3:59 ` Kees Cook
2026-03-30 5:36 ` Nathan Chancellor [this message]
2026-03-30 18:56 ` Kees Cook
2026-03-31 0:17 ` Justin Stitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330053604.GA879042@ax162 \
--to=nathan@kernel.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nsc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.