From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D12C3383C6A for ; Mon, 30 Mar 2026 05:58:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774850329; cv=none; b=VjLBSJ4eV74il5EUHFP3qbWFVj1/XKrfAJUbrrVXEe52CkixZSYotMVRugBujXtHtks38qKuiQ2eJ4gNpbnw0J2QhPSMtr/eJFbOiLGrkfc1b+yPFceu2lu5Id/8kPwEVTI1vq+ETB/Jtu10CWFEVxjqpm3wvHtcv6ElW/+tVyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774850329; c=relaxed/simple; bh=cG92xGH9WZWBy//57zeOYY4EGrjWkxOuj9kBCNQi1c8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cl9IU8cJADnlONnhymD6jkhgdtJGl3SzgsgIyZNa2PCU/FGmGUca7v+aujJdtKimb+PxnFjlkryuDySRiBOZhUINH4U7PhaKjtF41haYBx89HQTWlyM+ZSoD9gknrmcKJaEv8Xlk9ZIjEgG9sFgyegPuvZ3J1MdbAllXycQVghU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EwSB2B62; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EwSB2B62" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-48702d51cd0so48364565e9.2 for ; Sun, 29 Mar 2026 22:58:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774850326; x=1775455126; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PgdaL/zWdNdjo2VBs5fMH7nzqTNFHOZ8Z5QsCp8ugaU=; b=EwSB2B62XcxEiLMMKGoBCXckh6yOWbBKUVaR6e+aJ+NrfxM6xKNVm8KWQwAahMioMA llMw0eYEnrjUp7d37WxysIo033PFL7ynlOgI/W/a8DbakVdK/TSq5bP3+q+isRLhoEQC Td5CstkXJcTTdtAvduzBiNom1olI1bOo/hg4ub7ee2Cm1uTf+eNazrApQjS2kysGqgHW ZoCRr2DGTu6tNWZTL4jf4flhMaaDOaYN0rqSaZMkMWn8aLy1+8pwgTk8+SdLp/4rPYpx PXfTptr0ddLZDTUaeO9CwhDXwDgTO7znOfJ/sWWgznryQFtgzoPfL5AH2tnOt5hcQ1xX JeeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774850326; x=1775455126; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PgdaL/zWdNdjo2VBs5fMH7nzqTNFHOZ8Z5QsCp8ugaU=; b=I+7eI+yjmgk+xkTnLLhC+oby8HI6uqr23vtYlF8I/zSn86xSOQaevNdZoV+WcVRDqg 5n7Sz0o7XexYQRvDig1dGx7JdB6LxfRgKYSWmMXpwmmdpRPMBV20f5PLmay4Y4hH6n/B ggcEzm+zmTuZY2s1RwebGSmDUFYMpS8hZXHSe22kg/7tMVbJjDN4VTWXfjSjxLTJbrgo EPFhq0zfoXhchuTJ2C3puX+Lt6NHTD8X7nF159wpddBjOJFegbGpbp9bNHzjJnkb/xnv H1w2I+Sia6tNu/Y4oWamve6IpvUtpZ/sYgfl+4wDXm3/2FfLQxMtI5ggpOqahV5w2Fom cW5g== X-Forwarded-Encrypted: i=1; AJvYcCXF26NbzQW9Z+larpMJCBm9fUE7hxz/h8hucKAR4rQzV17PcruTwc7PPlJt3/52tU6XNUUFPuI56AmtjHA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxm9ZroPLzeIS8kC9mKy8b/KKMRNlsWpSzKwFL8uQSe6EUg0rWr /rRhnznlQd1Wvf4yAV1sJrBtq1tG4MtLEVME/A0ATy2DYzozMc6jvw9Q X-Gm-Gg: ATEYQzyJ1X/1coce5KFnlY/cguWKUhdy2IDfN1pdE0aVSB7U/n3EMwiAcGJkWnqPzkA fjJe4nw3R88Ig0A1otvMCu+NlkuooHkxG61lqUMD1y/6aQ468SC6igXSjElyyd453MRvfIFlscz Qzek06LsVLDGhI8Ai77rmLMHxlOfM/4gtWwXSFYyuqxSKc4YoHxu5Tg7/PUQI6Hrkiy/Ao8ZGea sbo/deiBeF7UFecISR7QrW17Dt5g4AyNs3bz18MxVA5WJr4ihaSfqbvNBTE9IFnbwdfpMU6bxp/ fSiNGDm1e/j/Xjm3u8NPzBtJB1+ipkMtsZMq0aJzLv0r0gfCk6uOS7jPP0n8gL/4CxjLPzzy3TE UmNjhK77CeOWetOndLkpijCftFc0G1qi7XhZdeOud+JndvAPBk3bNIWKGP9F5SLqJX7t9xu2HTi 2WbDH/9yh9P6ZZvt73xNq/qq8FvlU90vm8xYmJnzOzqYzrsgi/PX4d/TUxuN3JXMFDIGIgH7MC3 JFi8s9p6+SlhjQ7umYIrcBtZNUxMoM3GCNnHlw84kus7cB3mY+40Ko= X-Received: by 2002:a05:6000:400c:b0:43c:fa96:d921 with SMTP id ffacd0b85a97d-43cfa96dd05mr6555170f8f.15.1774850326109; Sun, 29 Mar 2026 22:58:46 -0700 (PDT) Received: from fedora ([193.77.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf247079esm16324269f8f.25.2026.03.29.22.58.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 22:58:45 -0700 (PDT) From: Uros Bizjak To: x86@kernel.org, linux-kernel@vger.kernel.org Cc: Uros Bizjak , "Peter Zijlstra (Intel)" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH RESEND v4 1/4] x86/fsgsbase: Remove unnecessary "memory" clobbers from FS/GS base accessors Date: Mon, 30 Mar 2026 07:57:42 +0200 Message-ID: <20260330055823.5793-1-ubizjak@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The rdfsbase() and rdgsbase() helpers currently include a "memory" clobber in their inline assembly definitions. However, the RDFSBASE and RDGSBASE instructions only read the FS/GS base MSRs into a general-purpose register and do not access memory. The "memory" clobber, which acts as a compiler barrier and may inhibit optimization, is therefore unnecessary. The "memory" clobber was historically used as a scheduling constraint to prevent the compiler from moving the instructions before preceding segment register loads. This is not required because both the segment register loads and the RDFSBASE/RDGSBASE accessors are implemented with `asm volatile`, which already prevents reordering between them. No functional change intended. Signed-off-by: Uros Bizjak Acked-by: "Peter Zijlstra (Intel)" Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" --- v2: Note that the "memory" clobber was historically used as a scheduling constraint. --- arch/x86/include/asm/fsgsbase.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/fsgsbase.h b/arch/x86/include/asm/fsgsbase.h index ab2547f97c2c..70ff4ef457b1 100644 --- a/arch/x86/include/asm/fsgsbase.h +++ b/arch/x86/include/asm/fsgsbase.h @@ -25,7 +25,7 @@ static __always_inline unsigned long rdfsbase(void) { unsigned long fsbase; - asm volatile("rdfsbase %0" : "=r" (fsbase) :: "memory"); + asm volatile("rdfsbase %0" : "=r" (fsbase)); return fsbase; } @@ -34,7 +34,7 @@ static __always_inline unsigned long rdgsbase(void) { unsigned long gsbase; - asm volatile("rdgsbase %0" : "=r" (gsbase) :: "memory"); + asm volatile("rdgsbase %0" : "=r" (gsbase)); return gsbase; } -- 2.53.0