From: Johan Hovold <johan@kernel.org>
To: Hans Verkuil <hverkuil@kernel.org>, Sean Young <sean@mess.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan@kernel.org>
Subject: [PATCH 5/6] media: hdpvr: refactor endpoint lookup
Date: Mon, 30 Mar 2026 12:11:40 +0200 [thread overview]
Message-ID: <20260330101141.1664143-6-johan@kernel.org> (raw)
In-Reply-To: <20260330101141.1664143-1-johan@kernel.org>
Use the common USB helper for looking up bulk-in endpoints instead of
open coding.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/media/usb/hdpvr/hdpvr-core.c | 26 ++++++++------------------
1 file changed, 8 insertions(+), 18 deletions(-)
diff --git a/drivers/media/usb/hdpvr/hdpvr-core.c b/drivers/media/usb/hdpvr/hdpvr-core.c
index d42336836b18..849a2be416bd 100644
--- a/drivers/media/usb/hdpvr/hdpvr-core.c
+++ b/drivers/media/usb/hdpvr/hdpvr-core.c
@@ -265,13 +265,10 @@ static int hdpvr_probe(struct usb_interface *interface,
const struct usb_device_id *id)
{
struct hdpvr_device *dev;
- struct usb_host_interface *iface_desc;
struct usb_endpoint_descriptor *endpoint;
#if IS_ENABLED(CONFIG_I2C)
struct i2c_client *client;
#endif
- size_t buffer_size;
- int i;
int dev_num;
int retval = -ENOMEM;
@@ -321,25 +318,18 @@ static int hdpvr_probe(struct usb_interface *interface,
/* set up the endpoint information */
/* use only the first bulk-in and bulk-out endpoints */
- iface_desc = interface->cur_altsetting;
- for (i = 0; i < iface_desc->desc.bNumEndpoints; ++i) {
- endpoint = &iface_desc->endpoint[i].desc;
-
- if (!dev->bulk_in_endpointAddr &&
- usb_endpoint_is_bulk_in(endpoint)) {
- /* USB interface description is buggy, reported max
- * packet size is 512 bytes, windows driver uses 8192 */
- buffer_size = 8192;
- dev->bulk_in_size = buffer_size;
- dev->bulk_in_endpointAddr = endpoint->bEndpointAddress;
- }
-
- }
- if (!dev->bulk_in_endpointAddr) {
+ if (usb_find_bulk_in_endpoint(interface->cur_altsetting, &endpoint)) {
v4l2_err(&dev->v4l2_dev, "Could not find bulk-in endpoint\n");
goto error_put_usb;
}
+ /*
+ * USB interface description is buggy, reported max packet size is 512
+ * bytes, windows driver uses 8192
+ */
+ dev->bulk_in_size = 8192;
+ dev->bulk_in_endpointAddr = endpoint->bEndpointAddress;
+
/* init the device */
if (hdpvr_device_init(dev)) {
v4l2_err(&dev->v4l2_dev, "device init failed\n");
--
2.52.0
next prev parent reply other threads:[~2026-03-30 10:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 10:11 [PATCH 0/6] media: refactor USB endpoint lookups Johan Hovold
2026-03-30 10:11 ` [PATCH 1/6] media: si470x-usb: refactor endpoint lookup Johan Hovold
2026-03-30 10:11 ` [PATCH 2/6] media: imon_raw: " Johan Hovold
2026-03-30 10:11 ` [PATCH 3/6] media: irtoy: " Johan Hovold
2026-03-30 10:11 ` [PATCH 4/6] media: gspca: " Johan Hovold
2026-03-30 10:11 ` Johan Hovold [this message]
2026-03-30 10:11 ` [PATCH 6/6] media: s2255: " Johan Hovold
[not found] ` <69ca8460.050a0220.acff7.105a@mx.google.com>
2026-03-30 14:16 ` [0/6] media: refactor USB endpoint lookups Johan Hovold
2026-04-30 8:40 ` [PATCH 0/6] " Johan Hovold
2026-04-30 17:13 ` sean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330101141.1664143-6-johan@kernel.org \
--to=johan@kernel.org \
--cc=hverkuil@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.