From: Qi Tang <tpluszz77@gmail.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, Phil Sutter <phil@nwl.cc>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, Qi Tang <tpluszz77@gmail.com>
Subject: Re: [PATCH] netfilter: ctnetlink: validate expect class against master helper
Date: Mon, 30 Mar 2026 21:32:16 +0800 [thread overview]
Message-ID: <20260330133216.241532-1-tpluszz77@gmail.com> (raw)
In-Reply-To: <acpkPEJRvzeY863Y@chamomile>
On Mon, Mar 30, 2026 at 01:52:36PM +0200, Pablo Neira Ayuso wrote:
> Better to ignore the helper name proposed by userspace when creating
> the expectation.
>
> The master conntrack must already has a helper, and such helper must
> be the same that is specified here.
Agreed, your approach is much cleaner -- removing the separate helper
lookup entirely eliminates the mismatch class rather than just
patching the validation side.
Thanks for the quick fix!
Qi Tang
prev parent reply other threads:[~2026-03-30 13:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-29 16:51 [PATCH] netfilter: ctnetlink: validate expect class against master helper Qi Tang
2026-03-30 11:53 ` Pablo Neira Ayuso
2026-03-30 13:32 ` Qi Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330133216.241532-1-tpluszz77@gmail.com \
--to=tpluszz77@gmail.com \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.