Re: [PATCH for-11.0] scsi: Don't consider LOGICAL UNIT NOT SUPPORTED guest recoverable

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1497 bytes --]

On Mon, Mar 30, 2026 at 02:16:35PM +0200, Kevin Wolf wrote:
> When commit bdf9613b introduced scsi_sense_buf_is_guest_recoverable(),
> it included LOGICAL UNIT NOT SUPPORTED in the list of guest recoverable
> sense codes. It doesn't really explain how the codes to be in the list
> were selected.
> 
> As the LUN doesn't come from the guest, but from the block backend
> (usually the SCSI device on the host that was opened with host_device,
> but it could also be the iscsi block driver), there is really no way the
> guest could influence this.
> 
> It seems that on some storage arrays, LOGICAL UNIT NOT SUPPORTED can
> happen during failover operations. When combined with multipath, the
> request should be retried on another path instead of being reported to
> the guest, which would offline the filesystem in response.
> 
> Simply returning false in scsi_sense_buf_is_guest_recoverable() will
> enable the retry logic in file-posix, and will also make sure that if
> the error persists, the configured error policy is respected so that the
> VM can be stopped.
> 
> Buglink: https://redhat.atlassian.net/browse/RHEL-158212
> Fixes: bdf9613b7f87 ('scsi: explicitly list guest-recoverable sense codes')
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  scsi/utils.c | 1 -
>  1 file changed, 1 deletion(-)

Paolo: Are you taking this through your SCSI tree or would you like
Peter to merge it directly?

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]