From: Rosen Penev <rosenp@gmail.com>
To: linux-hwmon@vger.kernel.org
Cc: Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] hwmon: (pmbus) simplify allocation slightly
Date: Mon, 30 Mar 2026 14:21:00 -0700 [thread overview]
Message-ID: <20260330212100.15436-1-rosenp@gmail.com> (raw)
Use a flexible array member to combine kzalloc and kcalloc.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/hwmon/pmbus/pmbus_core.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
index e8fdd799c71c..c55ca3095975 100644
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -106,7 +106,6 @@ struct pmbus_data {
int max_attributes;
int num_attributes;
struct attribute_group group;
- const struct attribute_group **groups;
struct pmbus_sensor *sensors;
@@ -127,6 +126,8 @@ struct pmbus_data {
int vout_high[PMBUS_PAGES]; /* voltage high margin */
ktime_t next_access_backoff; /* Wait until at least this time */
+
+ const struct attribute_group *groups[];
};
struct pmbus_debugfs_entry {
@@ -3726,17 +3727,12 @@ int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info *info)
| I2C_FUNC_SMBUS_WORD_DATA))
return -ENODEV;
- data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
- if (!data)
- return -ENOMEM;
-
if (info->groups)
while (info->groups[groups_num])
groups_num++;
- data->groups = devm_kcalloc(dev, groups_num + 2, sizeof(void *),
- GFP_KERNEL);
- if (!data->groups)
+ data = devm_kzalloc(dev, struct_size(data, groups, groups_num + 2), GFP_KERNEL);
+ if (!data)
return -ENOMEM;
i2c_set_clientdata(client, data);
--
2.53.0
next reply other threads:[~2026-03-30 21:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 21:21 Rosen Penev [this message]
2026-03-30 21:32 ` [PATCH] hwmon: (pmbus) simplify allocation slightly Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330212100.15436-1-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.