diff for duplicates of <202603302356.u8QdlRIM-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 35e2375..629d49a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,12 +1,6 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -TO: Steve French <stfrench@microsoft.com> - tree: https://github.com/smfrench/smb3-kernel.git pr/146 head: d290e116f12405d8269c6041cbf68bc924b4cba6 commit: d290e116f12405d8269c6041cbf68bc924b4cba6 [1/1] smb: client: add support for O_TMPFILE (WIP) -:::::: branch date: 23 hours ago -:::::: commit date: 23 hours ago config: x86_64-randconfig-161-20260330 (https://download.01.org/0day-ci/archive/20260330/202603302356.u8QdlRIM-lkp@intel.com/config) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) smatch: v0.5.0-9004-gb810ac53 @@ -22,11 +16,6 @@ fs/smb/client/link.c:509 cifs_hardlink() error: we previously assumed 'old_file' vim +/old_file +509 fs/smb/client/link.c -5ab97578cbb3bf fs/cifs/link.c Steve French 2014-09-15 435 -0f8dce1cb7454f fs/cifs/link.c Sachin Prabhu 2013-11-25 436 /* -0f8dce1cb7454f fs/cifs/link.c Sachin Prabhu 2013-11-25 437 * M-F Symlink Functions - End -0f8dce1cb7454f fs/cifs/link.c Sachin Prabhu 2013-11-25 438 */ -8bfb50a882ccd9 fs/cifs/link.c Stefan Metzmacher 2010-07-31 439 ^1da177e4c3f41 fs/cifs/link.c Linus Torvalds 2005-04-16 440 int ^1da177e4c3f41 fs/cifs/link.c Linus Torvalds 2005-04-16 441 cifs_hardlink(struct dentry *old_file, struct inode *inode, ^1da177e4c3f41 fs/cifs/link.c Linus Torvalds 2005-04-16 442 struct dentry *direntry) @@ -52,6 +41,9 @@ d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 460 tcon 6d5786a34d98bf fs/cifs/link.c Pavel Shilovsky 2012-06-20 462 xid = get_xid(); ^1da177e4c3f41 fs/cifs/link.c Linus Torvalds 2005-04-16 463 d290e116f12405 fs/smb/client/link.c Paulo Alcantara 2026-03-27 @464 if (old_file && d_really_is_positive(old_file) && + ^^^^^^^^ +If old_file is NULL + d290e116f12405 fs/smb/client/link.c Paulo Alcantara 2026-03-27 465 test_bit(CIFS_INO_TMPFILE, &CIFS_I(d_inode(old_file))->flags)) { d290e116f12405 fs/smb/client/link.c Paulo Alcantara 2026-03-27 466 from_name = NULL; d290e116f12405 fs/smb/client/link.c Paulo Alcantara 2026-03-27 467 } else { @@ -97,6 +89,9 @@ d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 506 * if d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 507 * until the file is closed or oplock broken so update nlinks locally d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 508 */ 2b0143b5c986be fs/cifs/link.c David Howells 2015-03-17 @509 if (d_really_is_positive(old_file)) { + ^^^^^^^^ +Then we are toasted here. Unchecked dereference. + 2b0143b5c986be fs/cifs/link.c David Howells 2015-03-17 510 cifsInode = CIFS_I(d_inode(old_file)); 31ec35d6c81175 fs/cifs/link.c Steve French 2006-11-16 511 if (rc == 0) { d290e116f12405 fs/smb/client/link.c Paulo Alcantara 2026-03-27 512 clear_bit(CIFS_INO_TMPFILE, &cifsInode->flags); @@ -116,33 +111,6 @@ d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 525 * i ff273cb879fbc6 fs/cifs/link.c Steve French 2014-10-17 526 * file from srv. Note Samba server prior to 4.2 has bug - ff273cb879fbc6 fs/cifs/link.c Steve French 2014-10-17 527 * not updating src file ctime on hardlinks but Windows servers ff273cb879fbc6 fs/cifs/link.c Steve French 2014-10-17 528 * handle it properly -d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 529 */ -31ec35d6c81175 fs/cifs/link.c Steve French 2006-11-16 530 cifsInode->time = 0; -31ec35d6c81175 fs/cifs/link.c Steve French 2006-11-16 531 -d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 532 /* -d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 533 * Will update parent dir timestamps from srv within a second. -d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 534 * Would it really be worth it to set the parent dir (cifs -d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 535 * inode) time field to zero to force revalidate on parent -d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 536 * directory faster ie -d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 537 * -d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 538 * CIFS_I(inode)->time = 0; -d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 539 */ -31ec35d6c81175 fs/cifs/link.c Steve French 2006-11-16 540 } -^1da177e4c3f41 fs/cifs/link.c Linus Torvalds 2005-04-16 541 -^1da177e4c3f41 fs/cifs/link.c Linus Torvalds 2005-04-16 542 cifs_hl_exit: -f6a9bc336b600e fs/cifs/link.c Al Viro 2021-03-05 543 free_dentry_path(page1); -f6a9bc336b600e fs/cifs/link.c Al Viro 2021-03-05 544 free_dentry_path(page2); -6d5786a34d98bf fs/cifs/link.c Pavel Shilovsky 2012-06-20 545 free_xid(xid); -7ffec372458d16 fs/cifs/link.c Jeff Layton 2010-09-29 546 cifs_put_tlink(tlink); -^1da177e4c3f41 fs/cifs/link.c Linus Torvalds 2005-04-16 547 return rc; -^1da177e4c3f41 fs/cifs/link.c Linus Torvalds 2005-04-16 548 } -^1da177e4c3f41 fs/cifs/link.c Linus Torvalds 2005-04-16 549 - -:::::: The code at line 509 was first introduced by commit -:::::: 2b0143b5c986be1ce8408b3aadc4709e0a94429d VFS: normal filesystems (and lustre): d_inode() annotations - -:::::: TO: David Howells <dhowells@redhat.com> -:::::: CC: Al Viro <viro@zeniv.linux.org.uk> -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index 9907dc4..29e61dd 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,20 +1,15 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0[smfrench-smb3:pr/146 1/1] fs/smb/client/link.c:509 cifs_hardlink() error: we previously assumed 'old_file' could be null (see line 464)\0" - "Date\0Mon, 30 Mar 2026 23:32:23 +0800\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Mon, 30 Mar 2026 22:59:32 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + " Steve French <stfrench@microsoft.com>\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + " oe-kbuild-all@lists.linux.dev\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "TO: Steve French <stfrench@microsoft.com>\n" - "\n" "tree: https://github.com/smfrench/smb3-kernel.git pr/146\n" "head: d290e116f12405d8269c6041cbf68bc924b4cba6\n" "commit: d290e116f12405d8269c6041cbf68bc924b4cba6 [1/1] smb: client: add support for O_TMPFILE (WIP)\n" - ":::::: branch date: 23 hours ago\n" - ":::::: commit date: 23 hours ago\n" "config: x86_64-randconfig-161-20260330 (https://download.01.org/0day-ci/archive/20260330/202603302356.u8QdlRIM-lkp@intel.com/config)\n" "compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)\n" "smatch: v0.5.0-9004-gb810ac53\n" @@ -30,11 +25,6 @@ "\n" "vim +/old_file +509 fs/smb/client/link.c\n" "\n" - "5ab97578cbb3bf fs/cifs/link.c Steve French 2014-09-15 435 \n" - "0f8dce1cb7454f fs/cifs/link.c Sachin Prabhu 2013-11-25 436 /*\n" - "0f8dce1cb7454f fs/cifs/link.c Sachin Prabhu 2013-11-25 437 * M-F Symlink Functions - End\n" - "0f8dce1cb7454f fs/cifs/link.c Sachin Prabhu 2013-11-25 438 */\n" - "8bfb50a882ccd9 fs/cifs/link.c Stefan Metzmacher 2010-07-31 439 \n" "^1da177e4c3f41 fs/cifs/link.c Linus Torvalds 2005-04-16 440 int\n" "^1da177e4c3f41 fs/cifs/link.c Linus Torvalds 2005-04-16 441 cifs_hardlink(struct dentry *old_file, struct inode *inode,\n" "^1da177e4c3f41 fs/cifs/link.c Linus Torvalds 2005-04-16 442 \t struct dentry *direntry)\n" @@ -60,6 +50,9 @@ "6d5786a34d98bf fs/cifs/link.c Pavel Shilovsky 2012-06-20 462 \txid = get_xid();\n" "^1da177e4c3f41 fs/cifs/link.c Linus Torvalds 2005-04-16 463 \n" "d290e116f12405 fs/smb/client/link.c Paulo Alcantara 2026-03-27 @464 \tif (old_file && d_really_is_positive(old_file) &&\n" + " ^^^^^^^^\n" + "If old_file is NULL\n" + "\n" "d290e116f12405 fs/smb/client/link.c Paulo Alcantara 2026-03-27 465 \t test_bit(CIFS_INO_TMPFILE, &CIFS_I(d_inode(old_file))->flags)) {\n" "d290e116f12405 fs/smb/client/link.c Paulo Alcantara 2026-03-27 466 \t\tfrom_name = NULL;\n" "d290e116f12405 fs/smb/client/link.c Paulo Alcantara 2026-03-27 467 \t} else {\n" @@ -105,6 +98,9 @@ "d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 507 \t * until the file is closed or oplock broken so update nlinks locally\n" "d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 508 \t */\n" "2b0143b5c986be fs/cifs/link.c David Howells 2015-03-17 @509 \tif (d_really_is_positive(old_file)) {\n" + " ^^^^^^^^\n" + "Then we are toasted here. Unchecked dereference.\n" + "\n" "2b0143b5c986be fs/cifs/link.c David Howells 2015-03-17 510 \t\tcifsInode = CIFS_I(d_inode(old_file));\n" "31ec35d6c81175 fs/cifs/link.c Steve French 2006-11-16 511 \t\tif (rc == 0) {\n" "d290e116f12405 fs/smb/client/link.c Paulo Alcantara 2026-03-27 512 \t\t\tclear_bit(CIFS_INO_TMPFILE, &cifsInode->flags);\n" @@ -124,36 +120,9 @@ "ff273cb879fbc6 fs/cifs/link.c Steve French 2014-10-17 526 \t\t * file from srv. Note Samba server prior to 4.2 has bug -\n" "ff273cb879fbc6 fs/cifs/link.c Steve French 2014-10-17 527 \t\t * not updating src file ctime on hardlinks but Windows servers\n" "ff273cb879fbc6 fs/cifs/link.c Steve French 2014-10-17 528 \t\t * handle it properly\n" - "d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 529 \t\t */\n" - "31ec35d6c81175 fs/cifs/link.c Steve French 2006-11-16 530 \t\tcifsInode->time = 0;\n" - "31ec35d6c81175 fs/cifs/link.c Steve French 2006-11-16 531 \n" - "d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 532 \t\t/*\n" - "d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 533 \t\t * Will update parent dir timestamps from srv within a second.\n" - "d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 534 \t\t * Would it really be worth it to set the parent dir (cifs\n" - "d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 535 \t\t * inode) time field to zero to force revalidate on parent\n" - "d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 536 \t\t * directory faster ie\n" - "d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 537 \t\t *\n" - "d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 538 \t\t * CIFS_I(inode)->time = 0;\n" - "d6e906f1b571d1 fs/cifs/link.c Steve French 2012-09-18 539 \t\t */\n" - "31ec35d6c81175 fs/cifs/link.c Steve French 2006-11-16 540 \t}\n" - "^1da177e4c3f41 fs/cifs/link.c Linus Torvalds 2005-04-16 541 \n" - "^1da177e4c3f41 fs/cifs/link.c Linus Torvalds 2005-04-16 542 cifs_hl_exit:\n" - "f6a9bc336b600e fs/cifs/link.c Al Viro 2021-03-05 543 \tfree_dentry_path(page1);\n" - "f6a9bc336b600e fs/cifs/link.c Al Viro 2021-03-05 544 \tfree_dentry_path(page2);\n" - "6d5786a34d98bf fs/cifs/link.c Pavel Shilovsky 2012-06-20 545 \tfree_xid(xid);\n" - "7ffec372458d16 fs/cifs/link.c Jeff Layton 2010-09-29 546 \tcifs_put_tlink(tlink);\n" - "^1da177e4c3f41 fs/cifs/link.c Linus Torvalds 2005-04-16 547 \treturn rc;\n" - "^1da177e4c3f41 fs/cifs/link.c Linus Torvalds 2005-04-16 548 }\n" - "^1da177e4c3f41 fs/cifs/link.c Linus Torvalds 2005-04-16 549 \n" - "\n" - ":::::: The code at line 509 was first introduced by commit\n" - ":::::: 2b0143b5c986be1ce8408b3aadc4709e0a94429d VFS: normal filesystems (and lustre): d_inode() annotations\n" - "\n" - ":::::: TO: David Howells <dhowells@redhat.com>\n" - ":::::: CC: Al Viro <viro@zeniv.linux.org.uk>\n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -60d6a3035f1e02338c690f23629cdf7d9f513b64a881b5b4ea2e7e6bb50c38bf +c87ebe52939fdd596e8303da748c2508cf549ca73bcb73dcb8d7d4c5cbfc2f9e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.