From: Greg KH <gregkh@linuxfoundation.org>
To: Thierry Reding <thierry.reding@kernel.org>
Cc: Oskar Ray-Frayssinet <rayfraytech@gmail.com>,
marvin24@gmx.de, linux-staging@lists.linux.dev,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: nvec: fix block comment style in nvec.c
Date: Mon, 30 Mar 2026 16:29:59 +0200 [thread overview]
Message-ID: <2026033038-spectacle-judo-37ff@gregkh> (raw)
In-Reply-To: <accc-kOYHllCEnxi@orome>
On Sat, Mar 28, 2026 at 01:21:40AM +0100, Thierry Reding wrote:
> On Wed, Mar 18, 2026 at 03:59:43PM +0100, Greg KH wrote:
> > On Mon, Mar 09, 2026 at 11:07:18PM +0100, Oskar Ray-Frayssinet wrote:
> > > Fix block comment formatting to use * on subsequent lines
> > > and */ on a separate line as required by kernel coding style.
> > >
> > > Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
> > > ---
> > > drivers/staging/nvec/nvec.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> > > index e70fafc095f2..0e655f79ea4a 100644
> > > --- a/drivers/staging/nvec/nvec.c
> > > +++ b/drivers/staging/nvec/nvec.c
> > > @@ -659,7 +659,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> > > nvec_tx_set(nvec);
> > > to_send = nvec->tx->data[0];
> > > nvec->tx->pos = 1;
> > > - /* Delay ACK due to AP20 HW Bug
> > > + /* delay ACK due to AP20 HW Bug
> > > * do not replace by usleep_range
> > > */
> > > udelay(33);
> > > --
> > > 2.43.0
> > >
> > >
> >
> > This change is not what you documented is changing :(
>
> Hm... this is the 8th version of this patch that I've seen.
>
> I don't know why there was a flurry of these. The checkpatch warning
> certainly isn't new, so maybe this was a new wave of janitors or
> something? Or maybe people using AI agents to get into kernel
> development. Not that it matters much, but it's not a pattern that I've
> seen before.
>
> Also, the fact that 7 out of the 8 versions came in after the first had
> already landed in linux-next:
>
> 29e79c66b3cc ("staging: nvec: fix block comment style in nvec_interrupt()")
>
> suggests that people aren't using linux-next as their baseline. Do we
> need to be stricter in this regard? Seems a bit wasteful for you to have
> to spend so much time looking at duplicates, even though it seems like
> your automation did a lot of the work.
It's easy for me to reject things that obviously do not apply :)
thanks,
greg k-h
prev parent reply other threads:[~2026-03-30 14:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 19:18 [PATCH] staging: nvec: fix block comment style in nvec.c Oskar Ray-Frayssinet
2026-03-09 16:40 ` Greg KH
2026-03-09 22:07 ` [PATCH v3] " Oskar Ray-Frayssinet
2026-03-18 14:59 ` Greg KH
2026-03-18 21:46 ` Oskar Ray-Frayssinet
2026-03-28 0:21 ` Thierry Reding
2026-03-30 14:29 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026033038-spectacle-judo-37ff@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=rayfraytech@gmail.com \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.