From: Greg KH <gregkh@linuxfoundation.org>
To: Prithvi <activprithvi@gmail.com>
Cc: andriy.shevchenko@linux.intel.com, skhan@linuxfoundation.org,
dan.carpenter@linaro.org, abrahamadekunle50@gmail.com,
straube.linux@gmail.com, b9788213@gmail.com,
ethantidmore06@gmail.com, weibu@redadmin.org,
knavaneeth786@gmail.com, ignacio.pena87@gmail.com,
dharanitharan725@gmail.com, lukagejak5@gmail.com,
samasth.norway.ananda@oracle.com, karanja99erick@gmail.com,
s9430939@naver.com, suunj1331@gmail.com, ysinghcin@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev,
david.hunter.linux@gmail.com, khalid@kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: fix constant on left side of test checkpatch warnings
Date: Mon, 30 Mar 2026 18:03:08 +0200 [thread overview]
Message-ID: <2026033047-explore-embody-564f@gregkh> (raw)
In-Reply-To: <20260328174716.rna2qykokwkojzpt@inspiron>
On Sat, Mar 28, 2026 at 11:17:16PM +0530, Prithvi wrote:
> Hello all,
>
> Thank you very much for taking time to review this patch.
>
> I understand, that this patch may be considered to be majorly mechanical
> changes, but still, the scope of the patch as well as the changes
> involved make testing important for this patch.
>
> I agree that, in case of unavailability of hardware for testing, I should
> have mentioned it and used the RFT tag for the patch since v1. I
> apologize for missing this detail & understand that compile-time testing
> can't be sufficient here with all the changes introduced by this patch
> and also the concern of the possibility of regressions getting introduced.
>
> Going forward, I will be meticulous about clearly disclosing the testing
> status of the patch and if I am not able to test a patch, I will be sure
> to add RFT tag since v1 of the patch itself.
>
> Lastly, I wanted to kindly ask if it will be alright to send a v3 patch
> with the RFT tag, incorporating the changes discussed in this thread?
Yes please.
But remember to do only one logical thing per patch, I see multiple
things happening in this one :(
thanks,
greg k-h
next prev parent reply other threads:[~2026-03-30 16:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 16:29 [PATCH v2] staging: rtl8723bs: fix constant on left side of test checkpatch warnings Prithvi Tambewagh
2026-03-23 16:42 ` Andy Shevchenko
2026-03-24 13:02 ` Prithvi
2026-03-24 13:43 ` Andy Shevchenko
2026-03-24 13:55 ` Prithvi
2026-03-24 14:05 ` Andy Shevchenko
2026-03-24 16:02 ` Prithvi
2026-03-24 17:41 ` Shuah Khan
2026-03-25 7:22 ` Dan Carpenter
2026-03-25 17:57 ` Shuah Khan
2026-03-25 21:34 ` Dan Carpenter
2026-03-25 22:22 ` Shuah Khan
2026-03-28 17:47 ` Prithvi
2026-03-30 16:03 ` Greg KH [this message]
2026-04-03 7:31 ` Prithvi
2026-04-03 8:04 ` Greg KH
2026-04-03 9:46 ` Prithvi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026033047-explore-embody-564f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=abrahamadekunle50@gmail.com \
--cc=activprithvi@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=b9788213@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=david.hunter.linux@gmail.com \
--cc=dharanitharan725@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=ignacio.pena87@gmail.com \
--cc=karanja99erick@gmail.com \
--cc=khalid@kernel.org \
--cc=knavaneeth786@gmail.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lukagejak5@gmail.com \
--cc=s9430939@naver.com \
--cc=samasth.norway.ananda@oracle.com \
--cc=skhan@linuxfoundation.org \
--cc=straube.linux@gmail.com \
--cc=suunj1331@gmail.com \
--cc=weibu@redadmin.org \
--cc=ysinghcin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.