From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: drivers/input/misc/pf1550-onkey.c:113:10-35: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)
Date: Tue, 31 Mar 2026 01:11:05 +0800 [thread overview]
Message-ID: <202603310113.iIIMttUO-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Samuel Kayode <samuel.kayode@savoirfairelinux.com>
CC: Lee Jones <lee@kernel.org>
CC: Frank Li <Frank.Li@nxp.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7aaa8047eafd0bd628065b15757d9b48c5f9c07d
commit: 9acb215cbebdce721af2219e2859ad17342c9084 Input: pf1550 - add onkey support
date: 5 months ago
:::::: branch date: 18 hours ago
:::::: commit date: 5 months ago
config: powerpc64-randconfig-r052-20260330 (https://download.01.org/0day-ci/archive/20260331/202603310113.iIIMttUO-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 054e11d1a17e5ba88bb1a8ef32fad3346e80b186)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202603310113.iIIMttUO-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/input/misc/pf1550-onkey.c:113:10-35: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)
vim +113 drivers/input/misc/pf1550-onkey.c
9acb215cbebdce Samuel Kayode 2025-10-01 59
9acb215cbebdce Samuel Kayode 2025-10-01 60 static int pf1550_onkey_probe(struct platform_device *pdev)
9acb215cbebdce Samuel Kayode 2025-10-01 61 {
9acb215cbebdce Samuel Kayode 2025-10-01 62 struct onkey_drv_data *onkey;
9acb215cbebdce Samuel Kayode 2025-10-01 63 struct input_dev *input;
9acb215cbebdce Samuel Kayode 2025-10-01 64 bool key_power = false;
9acb215cbebdce Samuel Kayode 2025-10-01 65 int i, irq, error;
9acb215cbebdce Samuel Kayode 2025-10-01 66
9acb215cbebdce Samuel Kayode 2025-10-01 67 onkey = devm_kzalloc(&pdev->dev, sizeof(*onkey), GFP_KERNEL);
9acb215cbebdce Samuel Kayode 2025-10-01 68 if (!onkey)
9acb215cbebdce Samuel Kayode 2025-10-01 69 return -ENOMEM;
9acb215cbebdce Samuel Kayode 2025-10-01 70
9acb215cbebdce Samuel Kayode 2025-10-01 71 onkey->dev = &pdev->dev;
9acb215cbebdce Samuel Kayode 2025-10-01 72
9acb215cbebdce Samuel Kayode 2025-10-01 73 onkey->pf1550 = dev_get_drvdata(pdev->dev.parent);
9acb215cbebdce Samuel Kayode 2025-10-01 74 if (!onkey->pf1550->regmap)
9acb215cbebdce Samuel Kayode 2025-10-01 75 return dev_err_probe(&pdev->dev, -ENODEV,
9acb215cbebdce Samuel Kayode 2025-10-01 76 "failed to get regmap\n");
9acb215cbebdce Samuel Kayode 2025-10-01 77
9acb215cbebdce Samuel Kayode 2025-10-01 78 onkey->wakeup = device_property_read_bool(pdev->dev.parent,
9acb215cbebdce Samuel Kayode 2025-10-01 79 "wakeup-source");
9acb215cbebdce Samuel Kayode 2025-10-01 80
9acb215cbebdce Samuel Kayode 2025-10-01 81 if (device_property_read_bool(pdev->dev.parent,
9acb215cbebdce Samuel Kayode 2025-10-01 82 "nxp,disable-key-power")) {
9acb215cbebdce Samuel Kayode 2025-10-01 83 error = regmap_clear_bits(onkey->pf1550->regmap,
9acb215cbebdce Samuel Kayode 2025-10-01 84 PF1550_PMIC_REG_PWRCTRL1,
9acb215cbebdce Samuel Kayode 2025-10-01 85 PF1550_ONKEY_RST_EN);
9acb215cbebdce Samuel Kayode 2025-10-01 86 if (error)
9acb215cbebdce Samuel Kayode 2025-10-01 87 return dev_err_probe(&pdev->dev, error,
9acb215cbebdce Samuel Kayode 2025-10-01 88 "failed: disable turn system off");
9acb215cbebdce Samuel Kayode 2025-10-01 89 } else {
9acb215cbebdce Samuel Kayode 2025-10-01 90 key_power = true;
9acb215cbebdce Samuel Kayode 2025-10-01 91 }
9acb215cbebdce Samuel Kayode 2025-10-01 92
9acb215cbebdce Samuel Kayode 2025-10-01 93 input = devm_input_allocate_device(&pdev->dev);
9acb215cbebdce Samuel Kayode 2025-10-01 94 if (!input)
9acb215cbebdce Samuel Kayode 2025-10-01 95 return dev_err_probe(&pdev->dev, -ENOMEM,
9acb215cbebdce Samuel Kayode 2025-10-01 96 "failed to allocate the input device\n");
9acb215cbebdce Samuel Kayode 2025-10-01 97
9acb215cbebdce Samuel Kayode 2025-10-01 98 input->name = pdev->name;
9acb215cbebdce Samuel Kayode 2025-10-01 99 input->phys = "pf1550-onkey/input0";
9acb215cbebdce Samuel Kayode 2025-10-01 100 input->id.bustype = BUS_HOST;
9acb215cbebdce Samuel Kayode 2025-10-01 101
9acb215cbebdce Samuel Kayode 2025-10-01 102 if (key_power)
9acb215cbebdce Samuel Kayode 2025-10-01 103 input_set_capability(input, EV_KEY, KEY_POWER);
9acb215cbebdce Samuel Kayode 2025-10-01 104
9acb215cbebdce Samuel Kayode 2025-10-01 105 onkey->input = input;
9acb215cbebdce Samuel Kayode 2025-10-01 106 platform_set_drvdata(pdev, onkey);
9acb215cbebdce Samuel Kayode 2025-10-01 107
9acb215cbebdce Samuel Kayode 2025-10-01 108 for (i = 0; i < PF1550_ONKEY_IRQ_NR; i++) {
9acb215cbebdce Samuel Kayode 2025-10-01 109 irq = platform_get_irq(pdev, i);
9acb215cbebdce Samuel Kayode 2025-10-01 110 if (irq < 0)
9acb215cbebdce Samuel Kayode 2025-10-01 111 return irq;
9acb215cbebdce Samuel Kayode 2025-10-01 112
9acb215cbebdce Samuel Kayode 2025-10-01 @113 error = devm_request_threaded_irq(&pdev->dev, irq, NULL,
9acb215cbebdce Samuel Kayode 2025-10-01 114 pf1550_onkey_irq_handler,
9acb215cbebdce Samuel Kayode 2025-10-01 115 IRQF_NO_SUSPEND,
9acb215cbebdce Samuel Kayode 2025-10-01 116 "pf1550-onkey", onkey);
9acb215cbebdce Samuel Kayode 2025-10-01 117 if (error)
9acb215cbebdce Samuel Kayode 2025-10-01 118 return dev_err_probe(&pdev->dev, error,
9acb215cbebdce Samuel Kayode 2025-10-01 119 "failed: irq request (IRQ: %d)\n",
9acb215cbebdce Samuel Kayode 2025-10-01 120 i);
9acb215cbebdce Samuel Kayode 2025-10-01 121 }
9acb215cbebdce Samuel Kayode 2025-10-01 122
9acb215cbebdce Samuel Kayode 2025-10-01 123 error = input_register_device(input);
9acb215cbebdce Samuel Kayode 2025-10-01 124 if (error)
9acb215cbebdce Samuel Kayode 2025-10-01 125 return dev_err_probe(&pdev->dev, error,
9acb215cbebdce Samuel Kayode 2025-10-01 126 "failed to register input device\n");
9acb215cbebdce Samuel Kayode 2025-10-01 127
9acb215cbebdce Samuel Kayode 2025-10-01 128 device_init_wakeup(&pdev->dev, onkey->wakeup);
9acb215cbebdce Samuel Kayode 2025-10-01 129
9acb215cbebdce Samuel Kayode 2025-10-01 130 return 0;
9acb215cbebdce Samuel Kayode 2025-10-01 131 }
9acb215cbebdce Samuel Kayode 2025-10-01 132
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2026-03-30 17:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 17:11 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-10-05 2:08 drivers/input/misc/pf1550-onkey.c:113:10-35: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2026-01-25 17:35 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202603310113.iIIMttUO-lkp@intel.com \
--to=lkp@intel.com \
--cc=julia.lawall@inria.fr \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.