From: Jason Gunthorpe <jgg@nvidia.com>
To: Gary Guo <gary@garyguo.net>
Cc: Joel Fernandes <joelagnelf@nvidia.com>,
Zhi Wang <zhiw@nvidia.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
dakr@kernel.org, aliceryhl@google.com, bhelgaas@google.com,
kwilczynski@kernel.org, ojeda@kernel.org, alex.gaynor@gmail.com,
boqun.feng@gmail.com, bjorn3_gh@protonmail.com,
lossin@kernel.org, a.hindborg@kernel.org, tmgross@umich.edu,
markus.probst@posteo.de, helgaas@kernel.org, cjia@nvidia.com,
smitra@nvidia.com, ankita@nvidia.com, aniketa@nvidia.com,
kwankhede@nvidia.com, targupta@nvidia.com, acourbot@nvidia.com,
jhubbard@nvidia.com, zhiwang@kernel.org,
daniel.almeida@collabora.com
Subject: Re: [PATCH 2/2] gpu: nova-core: add fwctl driver for firmware control interface
Date: Tue, 31 Mar 2026 09:23:16 -0300 [thread overview]
Message-ID: <20260331122316.GX310919@nvidia.com> (raw)
In-Reply-To: <DHGCPLMB2J2T.1Y0V6KQUKVGPJ@garyguo.net>
On Mon, Mar 30, 2026 at 08:07:42PM +0100, Gary Guo wrote:
> On Mon Mar 30, 2026 at 7:18 PM BST, Jason Gunthorpe wrote:
> > On Mon, Mar 30, 2026 at 01:42:07PM -0400, Joel Fernandes wrote:
> >
> >> Just trying to confirm my understanding: Doesn't that mean
> >> NV2080_CTRL_CMD_VGPU_MGR_INTERNAL_PGPU_ADD_VGPU_TYPE becomes a part of UAPI
> >> then?
> >
> > Yes.
>
> I think it is probably undesirable for nova-core to expose GSP firmware detail
> to userspace directly.
Why? That is the whole point of this mechanism to remove kernel
involvement in the communication channel.
GSP firmware is supposed to commit to a stable ABI for anything
enabled for fwctl.
> > If you use fwctl it should be as I described, it is not an generic
> > interface to send SW command to the kernel, the commands have to be
> > delivered to FW.
>
> If fwctl isn't designed to provide abstraction layer between userspace/FW and is
> for raw access only, then an alternative mechanism should be used instead.
Why?
The purpose here is to upload a chunk of data to the FW. That is what
fwctl does.
> > This series adds a fwctl driver to nova-core, enabling userspace to issue
> > firmware commands to the GSP through the standard fwctl ioctl
> > interface. E.g. uploading the vGPU type blobs and managing the vGPU
> > lifecycle, which is previously implemented in sysfs.
>
> Zhi, is there a reason that sysfs is undesirable interface for this?
Please no, sysfs should not be abused for things like this.
Jason
prev parent reply other threads:[~2026-03-31 12:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 19:09 [PATCH 0/2] gpu: nova-core: add fwctl driver Zhi Wang
2026-03-05 19:09 ` [PATCH 1/2] fwctl: use subsys_initcall for built-in configuration Zhi Wang
2026-03-05 19:09 ` [PATCH 2/2] gpu: nova-core: add fwctl driver for firmware control interface Zhi Wang
2026-03-13 16:03 ` Danilo Krummrich
2026-03-13 16:26 ` Jason Gunthorpe
2026-03-30 12:58 ` Jason Gunthorpe
2026-03-30 17:42 ` Joel Fernandes
2026-03-30 18:18 ` Jason Gunthorpe
2026-03-30 19:07 ` Gary Guo
2026-03-31 12:23 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331122316.GX310919@nvidia.com \
--to=jgg@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=cjia@nvidia.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=helgaas@kernel.org \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=kwankhede@nvidia.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=markus.probst@posteo.de \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=smitra@nvidia.com \
--cc=targupta@nvidia.com \
--cc=tmgross@umich.edu \
--cc=zhiw@nvidia.com \
--cc=zhiwang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.