All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 06/11] target/i386: Treat qtest like TCG for supported-features
Date: Tue, 31 Mar 2026 15:15:08 +0200	[thread overview]
Message-ID: <20260331131514.21152-7-philmd@linaro.org> (raw)
In-Reply-To: <20260331131514.21152-1-philmd@linaro.org>

From: Peter Maydell <peter.maydell@linaro.org>

In x86_cpu_get_supported_feature_word() we figure out the supported
features differently for each accelerator. The default case is
"set all feature bits"; however this triggers a warning because
it enables two features which conflict with each other:

$ ./build/x86/qemu-system-x86_64   -cpu max -accel qtest -S
qemu-system-x86_64: warning: this feature conflicts with APX: CPUID[eax=07h,ecx=00h].EBX.mpx [bit 14]
qemu-system-x86_64: warning: this feature conflicts with MPX: CPUID[eax=07h,ecx=01h].EDX.apxf [bit 21]

Treat qtest like TCG here, to avoid the complaint.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Message-ID: <20260330151437.1787008-1-peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/i386/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 3b0a7c73632..c6fd1dc00eb 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -8087,7 +8087,7 @@ uint64_t x86_cpu_get_supported_feature_word(X86CPU *cpu, FeatureWord w)
         r = hvf_get_supported_cpuid(wi->cpuid.eax,
                                     wi->cpuid.ecx,
                                     wi->cpuid.reg);
-    } else if (tcg_enabled()) {
+    } else if (tcg_enabled() || qtest_enabled()) {
         r = wi->tcg_features;
     } else {
         return ~0;
-- 
2.53.0



  parent reply	other threads:[~2026-03-31 13:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 13:15 [PULL 00/11] Misc HW patches for 2026-03-31 Philippe Mathieu-Daudé
2026-03-31 13:15 ` [PULL 01/11] ppc/pnv: generate dtb after machine initialization is complete Philippe Mathieu-Daudé
2026-03-31 13:15 ` [PULL 02/11] MAINTAINERS: Separate QDev section from QOM one Philippe Mathieu-Daudé
2026-03-31 13:15 ` [PULL 03/11] target/mips: save CP0 timer in vmstate Philippe Mathieu-Daudé
2026-03-31 13:15 ` [PULL 04/11] backends/igvm: switch to PRIx64 Philippe Mathieu-Daudé
2026-03-31 13:15 ` [PULL 05/11] target/i386/cpu.c: Correct minor grammar error in warning Philippe Mathieu-Daudé
2026-03-31 13:15 ` Philippe Mathieu-Daudé [this message]
2026-03-31 13:15 ` [PULL 07/11] ati-vga: Silence warning about operator precedence Philippe Mathieu-Daudé
2026-03-31 13:15 ` [PULL 08/11] ati-vga: Add upper limit to x-linear-aper-size property Philippe Mathieu-Daudé
2026-03-31 13:15 ` [PULL 09/11] hw/pci-host/astro: Update copyright and documentation link Philippe Mathieu-Daudé
2026-03-31 13:15 ` [PULL 10/11] hw/hppa: Disable Artist graphics card on 64-bit machines Philippe Mathieu-Daudé
2026-03-31 13:15 ` [PULL 11/11] MAINTAINERS: fix OSUOSL typo Philippe Mathieu-Daudé
2026-03-31 16:34 ` [PULL 00/11] Misc HW patches for 2026-03-31 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260331131514.21152-7-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.