From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBB10109B46C for ; Tue, 31 Mar 2026 13:39:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m4Ho9kbIgK9nRfBUyF+gDfEmZb+Q7FhBYEHcrdLG8/A=; b=BViDcDLX6xAYDD7s+iLtpDFx2n CaWNHoZx+sHJ6TH9XPdH9BX04zsl5i7al52C5c+N0b8NEpX+PBisvQsHwaxE6jnHseQ4EQHBdRYmu vA/gYWzJic30xxVjgXYgHftGpRQ4NZ5xqDktI0U6mLSymSx9NjyTCFv+t53yZFjNQKPpBpuVa1I2W wrlXYvoOyIR71ThKvezg5L3cqaSQ+Mtbmr1tlFkMgFd0t0r2FqBZtjZOhS5/EkEeSfgyPaxQlD6nj CnL4Vbkr8efJy0XzzqfiRq8i2TUcIaMeCciQQG2AujRerujQv6nSZV4OoP7CbamAdZ+ucj2NcmA70 e1zkg1/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w7ZJk-0000000D1C8-20ME; Tue, 31 Mar 2026 13:39:40 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w7ZJi-0000000D1Bj-0sJ8; Tue, 31 Mar 2026 13:39:39 +0000 Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id CF21510D4; Tue, 31 Mar 2026 15:38:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774964294; bh=JJ7Re8324bMQSvbjwkjIGpdlNi77QJUISFYrAIkugaQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bJZhVXesNa5iBGvNJ6A0y3404JcqHsYqUZBzlfWEb1Xxm2UJ6eCnQEHL70vMeLWQT xnYroXBM6KdkzUisLRywkwKfVz4RiVCVH4QPhm8pTi6g7nXItkGnuyKxI8BTsS4iqN IWOoXKi6E6CdMW5iX2JbJIdgs+BO46qvFFlDF+2w= Date: Tue, 31 Mar 2026 16:39:34 +0300 From: Laurent Pinchart To: Jacopo Mondi Cc: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= , Dafna Hirschfeld , Mauro Carvalho Chehab , Heiko Stuebner , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] media: rkisp1: Add support for CAC Message-ID: <20260331133934.GC3357297@killaraus.ideasonboard.com> References: <20260323140216.1486161-1-barnabas.pocze@ideasonboard.com> <6c7ffd2d-94fa-4408-ac24-1e7adac95e5d@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260331_063938_562116_6518BD31 X-CRM114-Status: GOOD ( 52.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 31, 2026 at 02:42:33PM +0200, Jacopo Mondi wrote: > On Mon, Mar 30, 2026 at 04:40:18PM +0200, Barnabás Pőcze wrote: > > 2026. 03. 25. 16:21 keltezéssel, Jacopo Mondi írta: > > > On Mon, Mar 23, 2026 at 03:02:16PM +0100, Barnabás Pőcze wrote: > > > > The CAC block implements chromatic aberration correction. Expose it to > > > > userspace using the extensible parameters format. This was tested on the > > > > i.MX8MP platform, but based on available documentation it is also present > > > > in the RK3399 variant (V10). Thus presumably also in later versions, > > > > so no feature flag is introduced. > > > > > > > > Signed-off-by: Barnabás Pőcze > > > > > > Only minors.. > > > > > > > --- > > > > .../platform/rockchip/rkisp1/rkisp1-params.c | 69 ++++++++++++ > > > > .../platform/rockchip/rkisp1/rkisp1-regs.h | 21 +++- > > > > include/uapi/linux/rkisp1-config.h | 106 +++++++++++++++++- > > > > 3 files changed, 193 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c > > > > index 6442436a5e428..b889af9dcee45 100644 > > > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c > > > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c > > > > @@ -64,6 +64,7 @@ union rkisp1_ext_params_config { > > > > struct rkisp1_ext_params_compand_bls_config compand_bls; > > > > struct rkisp1_ext_params_compand_curve_config compand_curve; > > > > struct rkisp1_ext_params_wdr_config wdr; > > > > + struct rkisp1_ext_params_cac_config cac; > > > > }; > > > > > > > > enum rkisp1_params_formats { > > > > @@ -1413,6 +1414,48 @@ static void rkisp1_wdr_config(struct rkisp1_params *params, > > > > RKISP1_CIF_ISP_WDR_TONE_CURVE_YM_MASK); > > > > } > > > > > > > > +static void > > > > +rkisp1_cac_config(struct rkisp1_params *params, > > > > + const struct rkisp1_cif_isp_cac_config *arg) > > > > > > Fits in one line without going over 80 cols > > > > This is what the other functions looks like, so went this this. > > It seems to me not all of them are broken, but only the ones that go > over 80 cols > > in example: > > static void rkisp1_dpf_config(struct rkisp1_params *params, > const struct rkisp1_cif_isp_dpf_config *arg) > > A detail anyway, up to you > > > > > +{ > > > > + u32 regval; All other functions in this file name similar variables "val", "value" or "reg_val". Let's not introduce a fourth one. I have a small preference for "val", but that's not mandatory. > > > > + > > > > + /* > > > > + * The enable bit is in the same register (RKISP1_CIF_ISP_CAC_CTRL), > > > > + * so only set the clipping mode, and do not modify the other bits. > > > > + */ > > > > + regval = rkisp1_read(params->rkisp1, RKISP1_CIF_ISP_CAC_CTRL); > > > > + regval &= ~(RKISP1_CIF_ISP_CAC_CTRL_H_CLIP_MODE | > > > > + RKISP1_CIF_ISP_CAC_CTRL_V_CLIP_MODE); > > > > + regval |= FIELD_PREP(RKISP1_CIF_ISP_CAC_CTRL_H_CLIP_MODE, arg->h_clip_mode) | > > > > + FIELD_PREP(RKISP1_CIF_ISP_CAC_CTRL_V_CLIP_MODE, arg->v_clip_mode); > > > > + rkisp1_write(params->rkisp1, RKISP1_CIF_ISP_CAC_CTRL, regval); > > > > + > > > > + regval = FIELD_PREP(RKISP1_CIF_ISP_CAC_COUNT_START_H_MASK, arg->h_count_start) | > > > > + FIELD_PREP(RKISP1_CIF_ISP_CAC_COUNT_START_V_MASK, arg->v_count_start); > > > > + rkisp1_write(params->rkisp1, RKISP1_CIF_ISP_CAC_COUNT_START, regval); > > > > + > > > > + regval = FIELD_PREP(RKISP1_CIF_ISP_CAC_A_RED_MASK, arg->red[0]) | > > > > + FIELD_PREP(RKISP1_CIF_ISP_CAC_A_BLUE_MASK, arg->blue[0]); > > > > + rkisp1_write(params->rkisp1, RKISP1_CIF_ISP_CAC_A, regval); > > > > + > > > > + regval = FIELD_PREP(RKISP1_CIF_ISP_CAC_B_RED_MASK, arg->red[1]) | > > > > + FIELD_PREP(RKISP1_CIF_ISP_CAC_B_BLUE_MASK, arg->blue[1]); > > > > + rkisp1_write(params->rkisp1, RKISP1_CIF_ISP_CAC_B, regval); > > > > + > > > > + regval = FIELD_PREP(RKISP1_CIF_ISP_CAC_C_RED_MASK, arg->red[2]) | > > > > + FIELD_PREP(RKISP1_CIF_ISP_CAC_C_BLUE_MASK, arg->blue[2]); > > > > + rkisp1_write(params->rkisp1, RKISP1_CIF_ISP_CAC_C, regval); > > > > + > > > > + regval = FIELD_PREP(RKISP1_CIF_ISP_CAC_X_NORM_NF_MASK, arg->x_nf) | > > > > + FIELD_PREP(RKISP1_CIF_ISP_CAC_X_NORM_NS_MASK, arg->x_ns); > > > > + rkisp1_write(params->rkisp1, RKISP1_CIF_ISP_CAC_X_NORM, regval); > > > > + > > > > + regval = FIELD_PREP(RKISP1_CIF_ISP_CAC_Y_NORM_NF_MASK, arg->y_nf) | > > > > + FIELD_PREP(RKISP1_CIF_ISP_CAC_Y_NORM_NS_MASK, arg->y_ns); > > > > + rkisp1_write(params->rkisp1, RKISP1_CIF_ISP_CAC_Y_NORM, regval); > > > > +} > > > > + > > > > static void > > > > rkisp1_isp_isr_other_config(struct rkisp1_params *params, > > > > const struct rkisp1_params_cfg *new_params) > > > > @@ -2089,6 +2132,25 @@ static void rkisp1_ext_params_wdr(struct rkisp1_params *params, > > > > RKISP1_CIF_ISP_WDR_CTRL_ENABLE); > > > > } > > > > > > > > +static void rkisp1_ext_params_cac(struct rkisp1_params *params, > > > > + const union rkisp1_ext_params_config *block) > > > > +{ > > > > + const struct rkisp1_ext_params_cac_config *cac = &block->cac; > > > > + > > > > + if (cac->header.flags & RKISP1_EXT_PARAMS_FL_BLOCK_DISABLE) { > > > > + rkisp1_param_clear_bits(params, RKISP1_CIF_ISP_CAC_CTRL, > > > > + RKISP1_CIF_ISP_CAC_CTRL_ENABLE); > > > > + return; > > > > + } > > > > + > > > > + rkisp1_cac_config(params, &cac->config); > > > > + > > > > + if ((cac->header.flags & RKISP1_EXT_PARAMS_FL_BLOCK_ENABLE) && > > > > + !(params->enabled_blocks & BIT(cac->header.type))) > > > > + rkisp1_param_set_bits(params, RKISP1_CIF_ISP_CAC_CTRL, > > > > + RKISP1_CIF_ISP_CAC_CTRL_ENABLE); > > > > +} > > > > + > > > > typedef void (*rkisp1_block_handler)(struct rkisp1_params *params, > > > > const union rkisp1_ext_params_config *config); > > > > > > > > @@ -2185,6 +2247,10 @@ static const struct rkisp1_ext_params_handler { > > > > .handler = rkisp1_ext_params_wdr, > > > > .group = RKISP1_EXT_PARAMS_BLOCK_GROUP_OTHERS, > > > > }, > > > > + [RKISP1_EXT_PARAMS_BLOCK_TYPE_CAC] = { > > > > + .handler = rkisp1_ext_params_cac, > > > > + .group = RKISP1_EXT_PARAMS_BLOCK_GROUP_OTHERS, > > > > + }, > > > > }; > > > > > > > > #define RKISP1_PARAMS_BLOCK_INFO(block, data) \ > > > > @@ -2215,6 +2281,7 @@ rkisp1_ext_params_block_types_info[] = { > > > > RKISP1_PARAMS_BLOCK_INFO(COMPAND_EXPAND, compand_curve), > > > > RKISP1_PARAMS_BLOCK_INFO(COMPAND_COMPRESS, compand_curve), > > > > RKISP1_PARAMS_BLOCK_INFO(WDR, wdr), > > > > + RKISP1_PARAMS_BLOCK_INFO(CAC, cac), > > > > }; > > > > > > > > static_assert(ARRAY_SIZE(rkisp1_ext_params_handlers) == > > > > @@ -2474,6 +2541,8 @@ void rkisp1_params_disable(struct rkisp1_params *params) > > > > rkisp1_ie_enable(params, false); > > > > rkisp1_param_clear_bits(params, RKISP1_CIF_ISP_DPF_MODE, > > > > RKISP1_CIF_ISP_DPF_MODE_EN); > > > > + rkisp1_param_clear_bits(params, RKISP1_CIF_ISP_CAC_CTRL, > > > > + RKISP1_CIF_ISP_CAC_CTRL_ENABLE); > > > > } > > > > > > > > static const struct rkisp1_params_ops rkisp1_v10_params_ops = { > > > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h > > > > index fbeb186cde0d5..8e25537459bbd 100644 > > > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h > > > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h > > > > @@ -724,6 +724,23 @@ > > > > #define RKISP1_CIF_ISP_WDR_DMIN_STRENGTH_MASK GENMASK(20, 16) > > > > #define RKISP1_CIF_ISP_WDR_DMIN_STRENGTH_MAX 16U > > > > > > > > +/* CAC */ > > > > +#define RKISP1_CIF_ISP_CAC_CTRL_ENABLE BIT(0) > > > > +#define RKISP1_CIF_ISP_CAC_CTRL_V_CLIP_MODE GENMASK(2, 1) > > > > +#define RKISP1_CIF_ISP_CAC_CTRL_H_CLIP_MODE GENMASK(3, 3) I'd go for BIT(3) as you use BIT(0) for the enable bit. > > > > +#define RKISP1_CIF_ISP_CAC_COUNT_START_H_MASK GENMASK(12, 0) > > > > +#define RKISP1_CIF_ISP_CAC_COUNT_START_V_MASK GENMASK(28, 16) > > > > +#define RKISP1_CIF_ISP_CAC_A_RED_MASK GENMASK(8, 0) > > > > +#define RKISP1_CIF_ISP_CAC_A_BLUE_MASK GENMASK(24, 16) > > > > +#define RKISP1_CIF_ISP_CAC_B_RED_MASK GENMASK(8, 0) > > > > +#define RKISP1_CIF_ISP_CAC_B_BLUE_MASK GENMASK(24, 16) > > > > +#define RKISP1_CIF_ISP_CAC_C_RED_MASK GENMASK(8, 0) > > > > +#define RKISP1_CIF_ISP_CAC_C_BLUE_MASK GENMASK(24, 16) > > > > > > All these masks for coefficients 0, 1 and 2 are identical. Maybe > > > #define RKISP1_CIF_ISP_CAC_RED_MASK GENMASK(8, 0) > > > #define RKISP1_CIF_ISP_CAC_BLUE_MASK GENMASK(24, 16) > > > > > > is enough > > > > Adjusted. > > > > > > +#define RKISP1_CIF_ISP_CAC_X_NORM_NF_MASK GENMASK(4, 0) > > > > +#define RKISP1_CIF_ISP_CAC_X_NORM_NS_MASK GENMASK(19, 16) > > > > +#define RKISP1_CIF_ISP_CAC_Y_NORM_NF_MASK GENMASK(4, 0) > > > > +#define RKISP1_CIF_ISP_CAC_Y_NORM_NS_MASK GENMASK(19, 16) > > > > Did the same with these as well. > > Ah thanks! > > > > > + > > > > /* =================================================================== */ > > > > /* CIF Registers */ > > > > /* =================================================================== */ > > > > @@ -1196,8 +1213,8 @@ > > > > #define RKISP1_CIF_ISP_CAC_A (RKISP1_CIF_ISP_CAC_BASE + 0x00000008) > > > > #define RKISP1_CIF_ISP_CAC_B (RKISP1_CIF_ISP_CAC_BASE + 0x0000000c) > > > > #define RKISP1_CIF_ISP_CAC_C (RKISP1_CIF_ISP_CAC_BASE + 0x00000010) > > > > -#define RKISP1_CIF_ISP_X_NORM (RKISP1_CIF_ISP_CAC_BASE + 0x00000014) > > > > -#define RKISP1_CIF_ISP_Y_NORM (RKISP1_CIF_ISP_CAC_BASE + 0x00000018) > > > > +#define RKISP1_CIF_ISP_CAC_X_NORM (RKISP1_CIF_ISP_CAC_BASE + 0x00000014) > > > > +#define RKISP1_CIF_ISP_CAC_Y_NORM (RKISP1_CIF_ISP_CAC_BASE + 0x00000018) > > > > > > > > #define RKISP1_CIF_ISP_EXP_BASE 0x00002600 > > > > #define RKISP1_CIF_ISP_EXP_CTRL (RKISP1_CIF_ISP_EXP_BASE + 0x00000000) > > > > diff --git a/include/uapi/linux/rkisp1-config.h b/include/uapi/linux/rkisp1-config.h > > > > index b2d2a71f7baff..d8acccaddd0e9 100644 > > > > --- a/include/uapi/linux/rkisp1-config.h > > > > +++ b/include/uapi/linux/rkisp1-config.h > > > > @@ -967,6 +967,92 @@ struct rkisp1_cif_isp_wdr_config { > > > > __u8 use_iref; > > > > }; > > > > > > > > +/* > > > > + * enum rkisp1_cif_isp_cac_h_clip_mode - horizontal clipping mode > > > > + * > > > > + * @RKISP1_CIF_ISP_CAC_H_CLIP_MODE_4PX: +/- 4 pixels > > > > + * @RKISP1_CIF_ISP_CAC_H_CLIP_MODE_4_5PX: +/- 4/5 pixels depending on bayer position > > > > + */ > > > > +enum rkisp1_cif_isp_cac_h_clip_mode { > > > > + RKISP1_CIF_ISP_CAC_H_CLIP_MODE_4PX = 0, > > > > + RKISP1_CIF_ISP_CAC_H_CLIP_MODE_4_5PX = 1, > > > > +}; > > > > + > > > > +/** > > > > + * enum rkisp1_cif_isp_cac_v_clip_mode - vertical clipping mode > > > > + * > > > > + * @RKISP1_CIF_ISP_CAC_V_CLIP_MODE_2PX: +/- 2 pixels > > > > + * @RKISP1_CIF_ISP_CAC_V_CLIP_MODE_3PX: +/- 3 pixels > > > > + * @RKISP1_CIF_ISP_CAC_V_CLIP_MODE_3_4PX: +/- 3/4 pixels depending on bayer position > > > > + */ > > > > +enum rkisp1_cif_isp_cac_v_clip_mode { > > > > + RKISP1_CIF_ISP_CAC_V_CLIP_MODE_2PX = 0, > > > > + RKISP1_CIF_ISP_CAC_V_CLIP_MODE_3PX = 1, > > > > + RKISP1_CIF_ISP_CAC_V_CLIP_MODE_3_4PX = 2, > > > > +}; > > > > + > > > > +/** > > > > + * struct rkisp1_cif_isp_cac_config - chromatic aberration correction configuration > > > > + * > > > > + * The correction is carried out by shifting the red and blue pixels relative > > > > + * to the green ones, depending on the distance from the optical center: > > > > > > Yes, the distance to the center is one parameter, but the shifting > > > amount depends on other things. I would drop the last part of the > > > sentence and move the description of the two below fields after the > > > text > > > > That's true, but within a specific image, the only varying quantity > > is the distance, so I think it is important to emphasize that. > > > > And I also quite like this structure of > > - description of step > > - parameters of step > > - description of step > > ... > > > > so I would love to keep it like this, if that's ok? > > Ok! Ack. > > > > + * > > > > + * @h_count_start: horizontal coordinate of the optical center (13-bit unsigned integer; [1,8191]) > > > > + * @v_count_start: vertical coordinate of the optical center (13-bit unsigned integer; [1,8191]) > > > > > > so these could go just before @x_nf > > > > > > > + * > > > > + * For each pixel, the x/y distances from the optical center are calculated and > > > > > > I forgot: did we establish that the correction is applied to the > > > euclidean distance or to x and y separately ? > > > > Given that there are two sets of "normalization" parameters, the assumption is that > > at least the x/y distances are transformed separately. I see two reasonable choices > > after that: (a) use the two distances separately, (b) use the radial distance. The > > documentation says (b). However, testing with sensor test patterns suggests that > > it is not the case (a horizontal/vertical boundary between appropriately colored > > regions should have a curvature after the transformation with appropriate parameters). > > I now recall that you have been able to shift just one plan when using > the sensor's test pattern I agree about the normalization, but it sounds really weird that the hardware would then shift separately in the X and Y directions. Below you document the radial correction formula, which looks correct to me. > > > > + * then transformed into the [0,255] range based on the following formula: > > > > > > s/transformed/normalized ? > > > > To be honest I vastly prefer "transform" / "map" over "normalize" here. > > You're right here, the below formula doesn't normalize the > distance in an interval but just re-scale it > > > > > + * > > > > + * (((d << 4) >> s) * f) >> 5 > > > > + * > > > > + * where `d` is the distance, `s` and `f` are the normalization parameters: > > > > > > Can you use 'ns' and 'nf' to match the below ? > > > > Adjusted. > > Thanks! > > > > > + * > > > > + * @x_nf: horizontal normalization scale parameter (5-bit unsigned integer; [0,31]) > > > > + * @x_ns: horizontal normalization shift parameter (4-bit unsigned integer; [0,15]) > > > > + * > > > > + * @y_nf: vertical normalization scale parameter (5-bit unsigned integer; [0,31]) > > > > + * @y_ns: vertical normalization shift parameter (4-bit unsigned integer; [0,15]) > > > > + * > > > > + * These parameters should be chosen based on the image resolution, the position > > > > + * of the optical center, and the shape of pixels: so that no normalized distance > > > > > > s/pixels:/pixels/ > > > > Replaced `:` with `,`. > > > > > > + * is larger than 255. If the pixels have square shape, the two sets of parameters > > > > + * should be equal. I wonder if we could have anisotropic lenses (from the point of view of chromatic aberrations) with square pixels. We can deal with it later. > > > > + * > > > > + * The actual amount of correction is calculated with a third degree polynomial: > > > > + * > > > > + * c[0] * r + c[1] * r^2 + c[2] * r^3 > > > > + * > > > > + * where `c` is the set of coefficients for the given color, and `r` is distance: > > > > + * > > > > + * @red: red coefficients (5.4 two's complement; [-16,15.9375]) > > > > + * @blue: blue coefficients (5.4 two's complement; [-16,15.9375]) > > > > + * > > > > + * Finally, the amount is clipped as requested: > > > > + * > > > > + * @h_clip_mode: maximum horizontal shift (from enum rkisp1_cif_isp_cac_h_clip_mode) > > > > + * @v_clip_mode: maximum vertical shift (from enum rkisp1_cif_isp_cac_v_clip_mode) > > > > + * > > > > + * A positive result will shift away from the optical center, while a negative > > > > + * one will shift towards the optical center. In the latter case, the pixel > > > > + * values at the edges are duplicated. > > > > + */ > > > > +struct rkisp1_cif_isp_cac_config { > > > > + __u8 h_clip_mode; > > > > + __u8 v_clip_mode; > > > > + > > > > + __u16 h_count_start; > > > > + __u16 v_count_start; > > > > + > > > > + __u16 red[3]; > > > > + __u16 blue[3]; > > > > + > > > > + __u8 x_nf; > > > > + __u8 x_ns; > > > > + > > > > + __u8 y_nf; > > > > + __u8 y_ns; > > > > +}; > > > > + > > > > /*---------- PART2: Measurement Statistics ------------*/ > > > > > > > > /** > > > > @@ -1161,6 +1247,7 @@ enum rkisp1_ext_params_block_type { > > > > RKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_EXPAND, > > > > RKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_COMPRESS, > > > > RKISP1_EXT_PARAMS_BLOCK_TYPE_WDR, > > > > + RKISP1_EXT_PARAMS_BLOCK_TYPE_CAC, > > > > }; > > > > > > > > /* For backward compatibility */ > > > > @@ -1507,6 +1594,22 @@ struct rkisp1_ext_params_wdr_config { > > > > struct rkisp1_cif_isp_wdr_config config; > > > > } __attribute__((aligned(8))); > > > > > > > > +/** > > > > + * struct rkisp1_ext_params_cac_config - RkISP1 extensible params CAC config > > > > + * > > > > + * RkISP1 extensible parameters CAC block. > > > > + * Identified by :c:type:`RKISP1_EXT_PARAMS_BLOCK_TYPE_CAC`. > > > > + * > > > > + * @header: The RkISP1 extensible parameters header, see > > > > + * :c:type:`rkisp1_ext_params_block_header` > > > > + * @config: CAC configuration, see > > > > + * :c:type:`rkisp1_cif_isp_cac_config` > > > > + */ > > > > +struct rkisp1_ext_params_cac_config { > > > > + struct rkisp1_ext_params_block_header header; > > > > + struct rkisp1_cif_isp_cac_config config; > > > > +} __attribute__((aligned(8))); > > > > + > > > > /* > > > > * The rkisp1_ext_params_compand_curve_config structure is counted twice as it > > > > * is used for both the COMPAND_EXPAND and COMPAND_COMPRESS block types. > > > > @@ -1532,7 +1635,8 @@ struct rkisp1_ext_params_wdr_config { > > > > sizeof(struct rkisp1_ext_params_compand_bls_config) +\ > > > > sizeof(struct rkisp1_ext_params_compand_curve_config) +\ > > > > sizeof(struct rkisp1_ext_params_compand_curve_config) +\ > > > > - sizeof(struct rkisp1_ext_params_wdr_config)) > > > > + sizeof(struct rkisp1_ext_params_wdr_config) +\ > > > > + sizeof(struct rkisp1_ext_params_cac_config)) > > > > > > All minors, please add > > > Reviewed-by: Jacopo Mondi and Reviewed-by: Laurent Pinchart > > > > > > > > /** > > > > * enum rksip1_ext_param_buffer_version - RkISP1 extensible parameters version -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B85E9109B46C for ; Tue, 31 Mar 2026 13:39:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KWt4rIIAyYwYPUfyCXUp/nbYo9x+ZpLLh4fcCmG4uMs=; b=02tdL8iGYpW67h I4ynOuWrrokg3FhpkzvEMqm3YA40QWpZzie5NgwUoUVIwv0nNd8bdBMKco/LGRlfdH0j0zANpmdL2 L18lWiw+sPXHHRMcXR/BgIkvEWIf4EoJW/gy2irCkV/liHRD29JApZhjHXGvawKMQJW0vUMEmuYNt SaAUuhQS/Pv7Hwn9FiK/Ct8qmilSt1XhJ7hMcKyxp+XmT17licmtZQXQFcuErQU9dOiHsQe7HPXPU 2IFAraLzCux5gSSvPcT5x8VXsIjdNp97r6f+Pm4gW+5d6RkdhHqYA8ybhjzhwgb4+/Nr3MuZym1gZ b+RzfYnZIgnzAroLNszA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w7ZJk-0000000D1CC-3Bo9; Tue, 31 Mar 2026 13:39:40 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w7ZJi-0000000D1Bj-0sJ8; Tue, 31 Mar 2026 13:39:39 +0000 Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id CF21510D4; Tue, 31 Mar 2026 15:38:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774964294; bh=JJ7Re8324bMQSvbjwkjIGpdlNi77QJUISFYrAIkugaQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bJZhVXesNa5iBGvNJ6A0y3404JcqHsYqUZBzlfWEb1Xxm2UJ6eCnQEHL70vMeLWQT xnYroXBM6KdkzUisLRywkwKfVz4RiVCVH4QPhm8pTi6g7nXItkGnuyKxI8BTsS4iqN IWOoXKi6E6CdMW5iX2JbJIdgs+BO46qvFFlDF+2w= Date: Tue, 31 Mar 2026 16:39:34 +0300 From: Laurent Pinchart To: Jacopo Mondi Cc: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= , Dafna Hirschfeld , Mauro Carvalho Chehab , Heiko Stuebner , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] media: rkisp1: Add support for CAC Message-ID: <20260331133934.GC3357297@killaraus.ideasonboard.com> References: <20260323140216.1486161-1-barnabas.pocze@ideasonboard.com> <6c7ffd2d-94fa-4408-ac24-1e7adac95e5d@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260331_063938_562116_6518BD31 X-CRM114-Status: GOOD ( 52.39 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gVHVlLCBNYXIgMzEsIDIwMjYgYXQgMDI6NDI6MzNQTSArMDIwMCwgSmFjb3BvIE1vbmRpIHdy b3RlOgo+IE9uIE1vbiwgTWFyIDMwLCAyMDI2IGF0IDA0OjQwOjE4UE0gKzAyMDAsIEJhcm5hYsOh cyBQxZFjemUgd3JvdGU6Cj4gPiAyMDI2LiAwMy4gMjUuIDE2OjIxIGtlbHRlesOpc3NlbCwgSmFj b3BvIE1vbmRpIMOtcnRhOgo+ID4gPiBPbiBNb24sIE1hciAyMywgMjAyNiBhdCAwMzowMjoxNlBN ICswMTAwLCBCYXJuYWLDoXMgUMWRY3plIHdyb3RlOgo+ID4gPiA+IFRoZSBDQUMgYmxvY2sgaW1w bGVtZW50cyBjaHJvbWF0aWMgYWJlcnJhdGlvbiBjb3JyZWN0aW9uLiBFeHBvc2UgaXQgdG8KPiA+ ID4gPiB1c2Vyc3BhY2UgdXNpbmcgdGhlIGV4dGVuc2libGUgcGFyYW1ldGVycyBmb3JtYXQuIFRo aXMgd2FzIHRlc3RlZCBvbiB0aGUKPiA+ID4gPiBpLk1YOE1QIHBsYXRmb3JtLCBidXQgYmFzZWQg b24gYXZhaWxhYmxlIGRvY3VtZW50YXRpb24gaXQgaXMgYWxzbyBwcmVzZW50Cj4gPiA+ID4gaW4g dGhlIFJLMzM5OSB2YXJpYW50IChWMTApLiBUaHVzIHByZXN1bWFibHkgYWxzbyBpbiBsYXRlciB2 ZXJzaW9ucywKPiA+ID4gPiBzbyBubyBmZWF0dXJlIGZsYWcgaXMgaW50cm9kdWNlZC4KPiA+ID4g Pgo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEJhcm5hYsOhcyBQxZFjemUgPGJhcm5hYmFzLnBvY3pl QGlkZWFzb25ib2FyZC5jb20+Cj4gPiA+Cj4gPiA+IE9ubHkgbWlub3JzLi4KPiA+ID4KPiA+ID4g PiAtLS0KPiA+ID4gPiAgIC4uLi9wbGF0Zm9ybS9yb2NrY2hpcC9ya2lzcDEvcmtpc3AxLXBhcmFt cy5jICB8ICA2OSArKysrKysrKysrKysKPiA+ID4gPiAgIC4uLi9wbGF0Zm9ybS9yb2NrY2hpcC9y a2lzcDEvcmtpc3AxLXJlZ3MuaCAgICB8ICAyMSArKystCj4gPiA+ID4gICBpbmNsdWRlL3VhcGkv bGludXgvcmtpc3AxLWNvbmZpZy5oICAgICAgICAgICAgfCAxMDYgKysrKysrKysrKysrKysrKyst Cj4gPiA+ID4gICAzIGZpbGVzIGNoYW5nZWQsIDE5MyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9u cygtKQo+ID4gPiA+Cj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0v cm9ja2NoaXAvcmtpc3AxL3JraXNwMS1wYXJhbXMuYyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0v cm9ja2NoaXAvcmtpc3AxL3JraXNwMS1wYXJhbXMuYwo+ID4gPiA+IGluZGV4IDY0NDI0MzZhNWU0 MjguLmI4ODlhZjlkY2VlNDUgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9tZWRpYS9wbGF0 Zm9ybS9yb2NrY2hpcC9ya2lzcDEvcmtpc3AxLXBhcmFtcy5jCj4gPiA+ID4gKysrIGIvZHJpdmVy cy9tZWRpYS9wbGF0Zm9ybS9yb2NrY2hpcC9ya2lzcDEvcmtpc3AxLXBhcmFtcy5jCj4gPiA+ID4g QEAgLTY0LDYgKzY0LDcgQEAgdW5pb24gcmtpc3AxX2V4dF9wYXJhbXNfY29uZmlnIHsKPiA+ID4g PiAgIAlzdHJ1Y3Qgcmtpc3AxX2V4dF9wYXJhbXNfY29tcGFuZF9ibHNfY29uZmlnIGNvbXBhbmRf YmxzOwo+ID4gPiA+ICAgCXN0cnVjdCBya2lzcDFfZXh0X3BhcmFtc19jb21wYW5kX2N1cnZlX2Nv bmZpZyBjb21wYW5kX2N1cnZlOwo+ID4gPiA+ICAgCXN0cnVjdCBya2lzcDFfZXh0X3BhcmFtc193 ZHJfY29uZmlnIHdkcjsKPiA+ID4gPiArCXN0cnVjdCBya2lzcDFfZXh0X3BhcmFtc19jYWNfY29u ZmlnIGNhYzsKPiA+ID4gPiAgIH07Cj4gPiA+ID4KPiA+ID4gPiAgIGVudW0gcmtpc3AxX3BhcmFt c19mb3JtYXRzIHsKPiA+ID4gPiBAQCAtMTQxMyw2ICsxNDE0LDQ4IEBAIHN0YXRpYyB2b2lkIHJr aXNwMV93ZHJfY29uZmlnKHN0cnVjdCBya2lzcDFfcGFyYW1zICpwYXJhbXMsCj4gPiA+ID4gICAJ CQkJICAgICBSS0lTUDFfQ0lGX0lTUF9XRFJfVE9ORV9DVVJWRV9ZTV9NQVNLKTsKPiA+ID4gPiAg IH0KPiA+ID4gPgo+ID4gPiA+ICtzdGF0aWMgdm9pZAo+ID4gPiA+ICtya2lzcDFfY2FjX2NvbmZp ZyhzdHJ1Y3Qgcmtpc3AxX3BhcmFtcyAqcGFyYW1zLAo+ID4gPiA+ICsJCSAgY29uc3Qgc3RydWN0 IHJraXNwMV9jaWZfaXNwX2NhY19jb25maWcgKmFyZykKPiA+ID4KPiA+ID4gRml0cyBpbiBvbmUg bGluZSB3aXRob3V0IGdvaW5nIG92ZXIgODAgY29scwo+ID4KPiA+IFRoaXMgaXMgd2hhdCB0aGUg b3RoZXIgZnVuY3Rpb25zIGxvb2tzIGxpa2UsIHNvIHdlbnQgdGhpcyB0aGlzLgo+IAo+IEl0IHNl ZW1zIHRvIG1lIG5vdCBhbGwgb2YgdGhlbSBhcmUgYnJva2VuLCBidXQgb25seSB0aGUgb25lcyB0 aGF0IGdvCj4gb3ZlciA4MCBjb2xzCj4gCj4gaW4gZXhhbXBsZToKPiAKPiBzdGF0aWMgdm9pZCBy a2lzcDFfZHBmX2NvbmZpZyhzdHJ1Y3Qgcmtpc3AxX3BhcmFtcyAqcGFyYW1zLAo+IAkJCSAgICAg IGNvbnN0IHN0cnVjdCBya2lzcDFfY2lmX2lzcF9kcGZfY29uZmlnICphcmcpCj4gCj4gQSBkZXRh aWwgYW55d2F5LCB1cCB0byB5b3UKPiAKPiA+ID4gPiArewo+ID4gPiA+ICsJdTMyIHJlZ3ZhbDsK CkFsbCBvdGhlciBmdW5jdGlvbnMgaW4gdGhpcyBmaWxlIG5hbWUgc2ltaWxhciB2YXJpYWJsZXMg InZhbCIsICJ2YWx1ZSIKb3IgInJlZ192YWwiLiBMZXQncyBub3QgaW50cm9kdWNlIGEgZm91cnRo IG9uZS4gSSBoYXZlIGEgc21hbGwKcHJlZmVyZW5jZSBmb3IgInZhbCIsIGJ1dCB0aGF0J3Mgbm90 IG1hbmRhdG9yeS4KCj4gPiA+ID4gKwo+ID4gPiA+ICsJLyoKPiA+ID4gPiArCSAqIFRoZSBlbmFi bGUgYml0IGlzIGluIHRoZSBzYW1lIHJlZ2lzdGVyIChSS0lTUDFfQ0lGX0lTUF9DQUNfQ1RSTCks Cj4gPiA+ID4gKwkgKiBzbyBvbmx5IHNldCB0aGUgY2xpcHBpbmcgbW9kZSwgYW5kIGRvIG5vdCBt b2RpZnkgdGhlIG90aGVyIGJpdHMuCj4gPiA+ID4gKwkgKi8KPiA+ID4gPiArCXJlZ3ZhbCA9IHJr aXNwMV9yZWFkKHBhcmFtcy0+cmtpc3AxLCBSS0lTUDFfQ0lGX0lTUF9DQUNfQ1RSTCk7Cj4gPiA+ ID4gKwlyZWd2YWwgJj0gfihSS0lTUDFfQ0lGX0lTUF9DQUNfQ1RSTF9IX0NMSVBfTU9ERSB8Cj4g PiA+ID4gKwkJICAgIFJLSVNQMV9DSUZfSVNQX0NBQ19DVFJMX1ZfQ0xJUF9NT0RFKTsKPiA+ID4g PiArCXJlZ3ZhbCB8PSBGSUVMRF9QUkVQKFJLSVNQMV9DSUZfSVNQX0NBQ19DVFJMX0hfQ0xJUF9N T0RFLCBhcmctPmhfY2xpcF9tb2RlKSB8Cj4gPiA+ID4gKwkJICBGSUVMRF9QUkVQKFJLSVNQMV9D SUZfSVNQX0NBQ19DVFJMX1ZfQ0xJUF9NT0RFLCBhcmctPnZfY2xpcF9tb2RlKTsKPiA+ID4gPiAr CXJraXNwMV93cml0ZShwYXJhbXMtPnJraXNwMSwgUktJU1AxX0NJRl9JU1BfQ0FDX0NUUkwsIHJl Z3ZhbCk7Cj4gPiA+ID4gKwo+ID4gPiA+ICsJcmVndmFsID0gRklFTERfUFJFUChSS0lTUDFfQ0lG X0lTUF9DQUNfQ09VTlRfU1RBUlRfSF9NQVNLLCBhcmctPmhfY291bnRfc3RhcnQpIHwKPiA+ID4g PiArCQkgRklFTERfUFJFUChSS0lTUDFfQ0lGX0lTUF9DQUNfQ09VTlRfU1RBUlRfVl9NQVNLLCBh cmctPnZfY291bnRfc3RhcnQpOwo+ID4gPiA+ICsJcmtpc3AxX3dyaXRlKHBhcmFtcy0+cmtpc3Ax LCBSS0lTUDFfQ0lGX0lTUF9DQUNfQ09VTlRfU1RBUlQsIHJlZ3ZhbCk7Cj4gPiA+ID4gKwo+ID4g PiA+ICsJcmVndmFsID0gRklFTERfUFJFUChSS0lTUDFfQ0lGX0lTUF9DQUNfQV9SRURfTUFTSywg YXJnLT5yZWRbMF0pIHwKPiA+ID4gPiArCQkgRklFTERfUFJFUChSS0lTUDFfQ0lGX0lTUF9DQUNf QV9CTFVFX01BU0ssIGFyZy0+Ymx1ZVswXSk7Cj4gPiA+ID4gKwlya2lzcDFfd3JpdGUocGFyYW1z LT5ya2lzcDEsIFJLSVNQMV9DSUZfSVNQX0NBQ19BLCByZWd2YWwpOwo+ID4gPiA+ICsKPiA+ID4g PiArCXJlZ3ZhbCA9IEZJRUxEX1BSRVAoUktJU1AxX0NJRl9JU1BfQ0FDX0JfUkVEX01BU0ssIGFy Zy0+cmVkWzFdKSB8Cj4gPiA+ID4gKwkJIEZJRUxEX1BSRVAoUktJU1AxX0NJRl9JU1BfQ0FDX0Jf QkxVRV9NQVNLLCBhcmctPmJsdWVbMV0pOwo+ID4gPiA+ICsJcmtpc3AxX3dyaXRlKHBhcmFtcy0+ cmtpc3AxLCBSS0lTUDFfQ0lGX0lTUF9DQUNfQiwgcmVndmFsKTsKPiA+ID4gPiArCj4gPiA+ID4g KwlyZWd2YWwgPSBGSUVMRF9QUkVQKFJLSVNQMV9DSUZfSVNQX0NBQ19DX1JFRF9NQVNLLCBhcmct PnJlZFsyXSkgfAo+ID4gPiA+ICsJCSBGSUVMRF9QUkVQKFJLSVNQMV9DSUZfSVNQX0NBQ19DX0JM VUVfTUFTSywgYXJnLT5ibHVlWzJdKTsKPiA+ID4gPiArCXJraXNwMV93cml0ZShwYXJhbXMtPnJr aXNwMSwgUktJU1AxX0NJRl9JU1BfQ0FDX0MsIHJlZ3ZhbCk7Cj4gPiA+ID4gKwo+ID4gPiA+ICsJ cmVndmFsID0gRklFTERfUFJFUChSS0lTUDFfQ0lGX0lTUF9DQUNfWF9OT1JNX05GX01BU0ssIGFy Zy0+eF9uZikgfAo+ID4gPiA+ICsJCSBGSUVMRF9QUkVQKFJLSVNQMV9DSUZfSVNQX0NBQ19YX05P Uk1fTlNfTUFTSywgYXJnLT54X25zKTsKPiA+ID4gPiArCXJraXNwMV93cml0ZShwYXJhbXMtPnJr aXNwMSwgUktJU1AxX0NJRl9JU1BfQ0FDX1hfTk9STSwgcmVndmFsKTsKPiA+ID4gPiArCj4gPiA+ ID4gKwlyZWd2YWwgPSBGSUVMRF9QUkVQKFJLSVNQMV9DSUZfSVNQX0NBQ19ZX05PUk1fTkZfTUFT SywgYXJnLT55X25mKSB8Cj4gPiA+ID4gKwkJIEZJRUxEX1BSRVAoUktJU1AxX0NJRl9JU1BfQ0FD X1lfTk9STV9OU19NQVNLLCBhcmctPnlfbnMpOwo+ID4gPiA+ICsJcmtpc3AxX3dyaXRlKHBhcmFt cy0+cmtpc3AxLCBSS0lTUDFfQ0lGX0lTUF9DQUNfWV9OT1JNLCByZWd2YWwpOwo+ID4gPiA+ICt9 Cj4gPiA+ID4gKwo+ID4gPiA+ICAgc3RhdGljIHZvaWQKPiA+ID4gPiAgIHJraXNwMV9pc3BfaXNy X290aGVyX2NvbmZpZyhzdHJ1Y3Qgcmtpc3AxX3BhcmFtcyAqcGFyYW1zLAo+ID4gPiA+ICAgCQkJ ICAgIGNvbnN0IHN0cnVjdCBya2lzcDFfcGFyYW1zX2NmZyAqbmV3X3BhcmFtcykKPiA+ID4gPiBA QCAtMjA4OSw2ICsyMTMyLDI1IEBAIHN0YXRpYyB2b2lkIHJraXNwMV9leHRfcGFyYW1zX3dkcihz dHJ1Y3Qgcmtpc3AxX3BhcmFtcyAqcGFyYW1zLAo+ID4gPiA+ICAgCQkJCSAgICAgIFJLSVNQMV9D SUZfSVNQX1dEUl9DVFJMX0VOQUJMRSk7Cj4gPiA+ID4gICB9Cj4gPiA+ID4KPiA+ID4gPiArc3Rh dGljIHZvaWQgcmtpc3AxX2V4dF9wYXJhbXNfY2FjKHN0cnVjdCBya2lzcDFfcGFyYW1zICpwYXJh bXMsCj4gPiA+ID4gKwkJCQkgIGNvbnN0IHVuaW9uIHJraXNwMV9leHRfcGFyYW1zX2NvbmZpZyAq YmxvY2spCj4gPiA+ID4gK3sKPiA+ID4gPiArCWNvbnN0IHN0cnVjdCBya2lzcDFfZXh0X3BhcmFt c19jYWNfY29uZmlnICpjYWMgPSAmYmxvY2stPmNhYzsKPiA+ID4gPiArCj4gPiA+ID4gKwlpZiAo Y2FjLT5oZWFkZXIuZmxhZ3MgJiBSS0lTUDFfRVhUX1BBUkFNU19GTF9CTE9DS19ESVNBQkxFKSB7 Cj4gPiA+ID4gKwkJcmtpc3AxX3BhcmFtX2NsZWFyX2JpdHMocGFyYW1zLCBSS0lTUDFfQ0lGX0lT UF9DQUNfQ1RSTCwKPiA+ID4gPiArCQkJCQlSS0lTUDFfQ0lGX0lTUF9DQUNfQ1RSTF9FTkFCTEUp Owo+ID4gPiA+ICsJCXJldHVybjsKPiA+ID4gPiArCX0KPiA+ID4gPiArCj4gPiA+ID4gKwlya2lz cDFfY2FjX2NvbmZpZyhwYXJhbXMsICZjYWMtPmNvbmZpZyk7Cj4gPiA+ID4gKwo+ID4gPiA+ICsJ aWYgKChjYWMtPmhlYWRlci5mbGFncyAmIFJLSVNQMV9FWFRfUEFSQU1TX0ZMX0JMT0NLX0VOQUJM RSkgJiYKPiA+ID4gPiArCSAgICAhKHBhcmFtcy0+ZW5hYmxlZF9ibG9ja3MgJiBCSVQoY2FjLT5o ZWFkZXIudHlwZSkpKQo+ID4gPiA+ICsJCXJraXNwMV9wYXJhbV9zZXRfYml0cyhwYXJhbXMsIFJL SVNQMV9DSUZfSVNQX0NBQ19DVFJMLAo+ID4gPiA+ICsJCQkJICAgICAgUktJU1AxX0NJRl9JU1Bf Q0FDX0NUUkxfRU5BQkxFKTsKPiA+ID4gPiArfQo+ID4gPiA+ICsKPiA+ID4gPiAgIHR5cGVkZWYg dm9pZCAoKnJraXNwMV9ibG9ja19oYW5kbGVyKShzdHJ1Y3Qgcmtpc3AxX3BhcmFtcyAqcGFyYW1z LAo+ID4gPiA+ICAgCQkJICAgICBjb25zdCB1bmlvbiBya2lzcDFfZXh0X3BhcmFtc19jb25maWcg KmNvbmZpZyk7Cj4gPiA+ID4KPiA+ID4gPiBAQCAtMjE4NSw2ICsyMjQ3LDEwIEBAIHN0YXRpYyBj b25zdCBzdHJ1Y3Qgcmtpc3AxX2V4dF9wYXJhbXNfaGFuZGxlciB7Cj4gPiA+ID4gICAJCS5oYW5k bGVyCT0gcmtpc3AxX2V4dF9wYXJhbXNfd2RyLAo+ID4gPiA+ICAgCQkuZ3JvdXAJCT0gUktJU1Ax X0VYVF9QQVJBTVNfQkxPQ0tfR1JPVVBfT1RIRVJTLAo+ID4gPiA+ICAgCX0sCj4gPiA+ID4gKwlb UktJU1AxX0VYVF9QQVJBTVNfQkxPQ0tfVFlQRV9DQUNdID0gewo+ID4gPiA+ICsJCS5oYW5kbGVy CT0gcmtpc3AxX2V4dF9wYXJhbXNfY2FjLAo+ID4gPiA+ICsJCS5ncm91cAkJPSBSS0lTUDFfRVhU X1BBUkFNU19CTE9DS19HUk9VUF9PVEhFUlMsCj4gPiA+ID4gKwl9LAo+ID4gPiA+ICAgfTsKPiA+ ID4gPgo+ID4gPiA+ICAgI2RlZmluZSBSS0lTUDFfUEFSQU1TX0JMT0NLX0lORk8oYmxvY2ssIGRh dGEpIFwKPiA+ID4gPiBAQCAtMjIxNSw2ICsyMjgxLDcgQEAgcmtpc3AxX2V4dF9wYXJhbXNfYmxv Y2tfdHlwZXNfaW5mb1tdID0gewo+ID4gPiA+ICAgCVJLSVNQMV9QQVJBTVNfQkxPQ0tfSU5GTyhD T01QQU5EX0VYUEFORCwgY29tcGFuZF9jdXJ2ZSksCj4gPiA+ID4gICAJUktJU1AxX1BBUkFNU19C TE9DS19JTkZPKENPTVBBTkRfQ09NUFJFU1MsIGNvbXBhbmRfY3VydmUpLAo+ID4gPiA+ICAgCVJL SVNQMV9QQVJBTVNfQkxPQ0tfSU5GTyhXRFIsIHdkciksCj4gPiA+ID4gKwlSS0lTUDFfUEFSQU1T X0JMT0NLX0lORk8oQ0FDLCBjYWMpLAo+ID4gPiA+ICAgfTsKPiA+ID4gPgo+ID4gPiA+ICAgc3Rh dGljX2Fzc2VydChBUlJBWV9TSVpFKHJraXNwMV9leHRfcGFyYW1zX2hhbmRsZXJzKSA9PQo+ID4g PiA+IEBAIC0yNDc0LDYgKzI1NDEsOCBAQCB2b2lkIHJraXNwMV9wYXJhbXNfZGlzYWJsZShzdHJ1 Y3Qgcmtpc3AxX3BhcmFtcyAqcGFyYW1zKQo+ID4gPiA+ICAgCXJraXNwMV9pZV9lbmFibGUocGFy YW1zLCBmYWxzZSk7Cj4gPiA+ID4gICAJcmtpc3AxX3BhcmFtX2NsZWFyX2JpdHMocGFyYW1zLCBS S0lTUDFfQ0lGX0lTUF9EUEZfTU9ERSwKPiA+ID4gPiAgIAkJCQlSS0lTUDFfQ0lGX0lTUF9EUEZf TU9ERV9FTik7Cj4gPiA+ID4gKwlya2lzcDFfcGFyYW1fY2xlYXJfYml0cyhwYXJhbXMsIFJLSVNQ MV9DSUZfSVNQX0NBQ19DVFJMLAo+ID4gPiA+ICsJCQkJUktJU1AxX0NJRl9JU1BfQ0FDX0NUUkxf RU5BQkxFKTsKPiA+ID4gPiAgIH0KPiA+ID4gPgo+ID4gPiA+ICAgc3RhdGljIGNvbnN0IHN0cnVj dCBya2lzcDFfcGFyYW1zX29wcyBya2lzcDFfdjEwX3BhcmFtc19vcHMgPSB7Cj4gPiA+ID4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcm9ja2NoaXAvcmtpc3AxL3JraXNwMS1y ZWdzLmggYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3JvY2tjaGlwL3JraXNwMS9ya2lzcDEtcmVn cy5oCj4gPiA+ID4gaW5kZXggZmJlYjE4NmNkZTBkNS4uOGUyNTUzNzQ1OWJiZCAxMDA2NDQKPiA+ ID4gPiAtLS0gYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3JvY2tjaGlwL3JraXNwMS9ya2lzcDEt cmVncy5oCj4gPiA+ID4gKysrIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9yb2NrY2hpcC9ya2lz cDEvcmtpc3AxLXJlZ3MuaAo+ID4gPiA+IEBAIC03MjQsNiArNzI0LDIzIEBACj4gPiA+ID4gICAj ZGVmaW5lIFJLSVNQMV9DSUZfSVNQX1dEUl9ETUlOX1NUUkVOR1RIX01BU0sJCUdFTk1BU0soMjAs IDE2KQo+ID4gPiA+ICAgI2RlZmluZSBSS0lTUDFfQ0lGX0lTUF9XRFJfRE1JTl9TVFJFTkdUSF9N QVgJCTE2VQo+ID4gPiA+Cj4gPiA+ID4gKy8qIENBQyAqLwo+ID4gPiA+ICsjZGVmaW5lIFJLSVNQ MV9DSUZfSVNQX0NBQ19DVFJMX0VOQUJMRQkJQklUKDApCj4gPiA+ID4gKyNkZWZpbmUgUktJU1Ax X0NJRl9JU1BfQ0FDX0NUUkxfVl9DTElQX01PREUJR0VOTUFTSygyLCAxKQo+ID4gPiA+ICsjZGVm aW5lIFJLSVNQMV9DSUZfSVNQX0NBQ19DVFJMX0hfQ0xJUF9NT0RFCUdFTk1BU0soMywgMykKCkkn ZCBnbyBmb3IgQklUKDMpIGFzIHlvdSB1c2UgQklUKDApIGZvciB0aGUgZW5hYmxlIGJpdC4KCj4g PiA+ID4gKyNkZWZpbmUgUktJU1AxX0NJRl9JU1BfQ0FDX0NPVU5UX1NUQVJUX0hfTUFTSwlHRU5N QVNLKDEyLCAwKQo+ID4gPiA+ICsjZGVmaW5lIFJLSVNQMV9DSUZfSVNQX0NBQ19DT1VOVF9TVEFS VF9WX01BU0sJR0VOTUFTSygyOCwgMTYpCj4gPiA+ID4gKyNkZWZpbmUgUktJU1AxX0NJRl9JU1Bf Q0FDX0FfUkVEX01BU0sJCUdFTk1BU0soOCwgMCkKPiA+ID4gPiArI2RlZmluZSBSS0lTUDFfQ0lG X0lTUF9DQUNfQV9CTFVFX01BU0sJCUdFTk1BU0soMjQsIDE2KQo+ID4gPiA+ICsjZGVmaW5lIFJL SVNQMV9DSUZfSVNQX0NBQ19CX1JFRF9NQVNLCQlHRU5NQVNLKDgsIDApCj4gPiA+ID4gKyNkZWZp bmUgUktJU1AxX0NJRl9JU1BfQ0FDX0JfQkxVRV9NQVNLCQlHRU5NQVNLKDI0LCAxNikKPiA+ID4g PiArI2RlZmluZSBSS0lTUDFfQ0lGX0lTUF9DQUNfQ19SRURfTUFTSwkJR0VOTUFTSyg4LCAwKQo+ ID4gPiA+ICsjZGVmaW5lIFJLSVNQMV9DSUZfSVNQX0NBQ19DX0JMVUVfTUFTSwkJR0VOTUFTSygy NCwgMTYpCj4gPiA+Cj4gPiA+IEFsbCB0aGVzZSBtYXNrcyBmb3IgY29lZmZpY2llbnRzIDAsIDEg YW5kIDIgYXJlIGlkZW50aWNhbC4gTWF5YmUKPiA+ID4gI2RlZmluZSBSS0lTUDFfQ0lGX0lTUF9D QUNfUkVEX01BU0sJCUdFTk1BU0soOCwgMCkKPiA+ID4gI2RlZmluZSBSS0lTUDFfQ0lGX0lTUF9D QUNfQkxVRV9NQVNLCQlHRU5NQVNLKDI0LCAxNikKPiA+ID4KPiA+ID4gaXMgZW5vdWdoCj4gPgo+ ID4gQWRqdXN0ZWQuCj4gPgo+ID4gPiA+ICsjZGVmaW5lIFJLSVNQMV9DSUZfSVNQX0NBQ19YX05P Uk1fTkZfTUFTSwlHRU5NQVNLKDQsIDApCj4gPiA+ID4gKyNkZWZpbmUgUktJU1AxX0NJRl9JU1Bf Q0FDX1hfTk9STV9OU19NQVNLCUdFTk1BU0soMTksIDE2KQo+ID4gPiA+ICsjZGVmaW5lIFJLSVNQ MV9DSUZfSVNQX0NBQ19ZX05PUk1fTkZfTUFTSwlHRU5NQVNLKDQsIDApCj4gPiA+ID4gKyNkZWZp bmUgUktJU1AxX0NJRl9JU1BfQ0FDX1lfTk9STV9OU19NQVNLCUdFTk1BU0soMTksIDE2KQo+ID4K PiA+IERpZCB0aGUgc2FtZSB3aXRoIHRoZXNlIGFzIHdlbGwuCj4gCj4gQWggdGhhbmtzIQo+IAo+ ID4gPiA+ICsKPiA+ID4gPiAgIC8qID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0gKi8KPiA+ID4gPiAgIC8qICAgICAgICAg ICAgICAgICAgICAgICAgICAgIENJRiBSZWdpc3RlcnMgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKi8KPiA+ID4gPiAgIC8qID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0gKi8KPiA+ID4gPiBAQCAtMTE5Niw4ICsxMjEz LDggQEAKPiA+ID4gPiAgICNkZWZpbmUgUktJU1AxX0NJRl9JU1BfQ0FDX0EJCQkoUktJU1AxX0NJ Rl9JU1BfQ0FDX0JBU0UgKyAweDAwMDAwMDA4KQo+ID4gPiA+ICAgI2RlZmluZSBSS0lTUDFfQ0lG X0lTUF9DQUNfQgkJCShSS0lTUDFfQ0lGX0lTUF9DQUNfQkFTRSArIDB4MDAwMDAwMGMpCj4gPiA+ ID4gICAjZGVmaW5lIFJLSVNQMV9DSUZfSVNQX0NBQ19DCQkJKFJLSVNQMV9DSUZfSVNQX0NBQ19C QVNFICsgMHgwMDAwMDAxMCkKPiA+ID4gPiAtI2RlZmluZSBSS0lTUDFfQ0lGX0lTUF9YX05PUk0J CQkoUktJU1AxX0NJRl9JU1BfQ0FDX0JBU0UgKyAweDAwMDAwMDE0KQo+ID4gPiA+IC0jZGVmaW5l IFJLSVNQMV9DSUZfSVNQX1lfTk9STQkJCShSS0lTUDFfQ0lGX0lTUF9DQUNfQkFTRSArIDB4MDAw MDAwMTgpCj4gPiA+ID4gKyNkZWZpbmUgUktJU1AxX0NJRl9JU1BfQ0FDX1hfTk9STQkJKFJLSVNQ MV9DSUZfSVNQX0NBQ19CQVNFICsgMHgwMDAwMDAxNCkKPiA+ID4gPiArI2RlZmluZSBSS0lTUDFf Q0lGX0lTUF9DQUNfWV9OT1JNCQkoUktJU1AxX0NJRl9JU1BfQ0FDX0JBU0UgKyAweDAwMDAwMDE4 KQo+ID4gPiA+Cj4gPiA+ID4gICAjZGVmaW5lIFJLSVNQMV9DSUZfSVNQX0VYUF9CQVNFCQkJMHgw MDAwMjYwMAo+ID4gPiA+ICAgI2RlZmluZSBSS0lTUDFfQ0lGX0lTUF9FWFBfQ1RSTAkJCShSS0lT UDFfQ0lGX0lTUF9FWFBfQkFTRSArIDB4MDAwMDAwMDApCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2lu Y2x1ZGUvdWFwaS9saW51eC9ya2lzcDEtY29uZmlnLmggYi9pbmNsdWRlL3VhcGkvbGludXgvcmtp c3AxLWNvbmZpZy5oCj4gPiA+ID4gaW5kZXggYjJkMmE3MWY3YmFmZi4uZDhhY2NjYWRkZDBlOSAx MDA2NDQKPiA+ID4gPiAtLS0gYS9pbmNsdWRlL3VhcGkvbGludXgvcmtpc3AxLWNvbmZpZy5oCj4g PiA+ID4gKysrIGIvaW5jbHVkZS91YXBpL2xpbnV4L3JraXNwMS1jb25maWcuaAo+ID4gPiA+IEBA IC05NjcsNiArOTY3LDkyIEBAIHN0cnVjdCBya2lzcDFfY2lmX2lzcF93ZHJfY29uZmlnIHsKPiA+ ID4gPiAgIAlfX3U4IHVzZV9pcmVmOwo+ID4gPiA+ICAgfTsKPiA+ID4gPgo+ID4gPiA+ICsvKgo+ ID4gPiA+ICsgKiBlbnVtIHJraXNwMV9jaWZfaXNwX2NhY19oX2NsaXBfbW9kZSAtIGhvcml6b250 YWwgY2xpcHBpbmcgbW9kZQo+ID4gPiA+ICsgKgo+ID4gPiA+ICsgKiBAUktJU1AxX0NJRl9JU1Bf Q0FDX0hfQ0xJUF9NT0RFXzRQWDogKy8tIDQgcGl4ZWxzCj4gPiA+ID4gKyAqIEBSS0lTUDFfQ0lG X0lTUF9DQUNfSF9DTElQX01PREVfNF81UFg6ICsvLSA0LzUgcGl4ZWxzIGRlcGVuZGluZyBvbiBi YXllciBwb3NpdGlvbgo+ID4gPiA+ICsgKi8KPiA+ID4gPiArZW51bSBya2lzcDFfY2lmX2lzcF9j YWNfaF9jbGlwX21vZGUgewo+ID4gPiA+ICsJUktJU1AxX0NJRl9JU1BfQ0FDX0hfQ0xJUF9NT0RF XzRQWCA9IDAsCj4gPiA+ID4gKwlSS0lTUDFfQ0lGX0lTUF9DQUNfSF9DTElQX01PREVfNF81UFgg PSAxLAo+ID4gPiA+ICt9Owo+ID4gPiA+ICsKPiA+ID4gPiArLyoqCj4gPiA+ID4gKyAqIGVudW0g cmtpc3AxX2NpZl9pc3BfY2FjX3ZfY2xpcF9tb2RlIC0gdmVydGljYWwgY2xpcHBpbmcgbW9kZQo+ ID4gPiA+ICsgKgo+ID4gPiA+ICsgKiBAUktJU1AxX0NJRl9JU1BfQ0FDX1ZfQ0xJUF9NT0RFXzJQ WDogKy8tIDIgcGl4ZWxzCj4gPiA+ID4gKyAqIEBSS0lTUDFfQ0lGX0lTUF9DQUNfVl9DTElQX01P REVfM1BYOiArLy0gMyBwaXhlbHMKPiA+ID4gPiArICogQFJLSVNQMV9DSUZfSVNQX0NBQ19WX0NM SVBfTU9ERV8zXzRQWDogKy8tIDMvNCBwaXhlbHMgZGVwZW5kaW5nIG9uIGJheWVyIHBvc2l0aW9u Cj4gPiA+ID4gKyAqLwo+ID4gPiA+ICtlbnVtIHJraXNwMV9jaWZfaXNwX2NhY192X2NsaXBfbW9k ZSB7Cj4gPiA+ID4gKwlSS0lTUDFfQ0lGX0lTUF9DQUNfVl9DTElQX01PREVfMlBYID0gMCwKPiA+ ID4gPiArCVJLSVNQMV9DSUZfSVNQX0NBQ19WX0NMSVBfTU9ERV8zUFggPSAxLAo+ID4gPiA+ICsJ UktJU1AxX0NJRl9JU1BfQ0FDX1ZfQ0xJUF9NT0RFXzNfNFBYID0gMiwKPiA+ID4gPiArfTsKPiA+ ID4gPiArCj4gPiA+ID4gKy8qKgo+ID4gPiA+ICsgKiBzdHJ1Y3Qgcmtpc3AxX2NpZl9pc3BfY2Fj X2NvbmZpZyAtIGNocm9tYXRpYyBhYmVycmF0aW9uIGNvcnJlY3Rpb24gY29uZmlndXJhdGlvbgo+ ID4gPiA+ICsgKgo+ID4gPiA+ICsgKiBUaGUgY29ycmVjdGlvbiBpcyBjYXJyaWVkIG91dCBieSBz aGlmdGluZyB0aGUgcmVkIGFuZCBibHVlIHBpeGVscyByZWxhdGl2ZQo+ID4gPiA+ICsgKiB0byB0 aGUgZ3JlZW4gb25lcywgZGVwZW5kaW5nIG9uIHRoZSBkaXN0YW5jZSBmcm9tIHRoZSBvcHRpY2Fs IGNlbnRlcjoKPiA+ID4KPiA+ID4gWWVzLCB0aGUgZGlzdGFuY2UgdG8gdGhlIGNlbnRlciBpcyBv bmUgcGFyYW1ldGVyLCBidXQgdGhlIHNoaWZ0aW5nCj4gPiA+IGFtb3VudCBkZXBlbmRzIG9uIG90 aGVyIHRoaW5ncy4gSSB3b3VsZCBkcm9wIHRoZSBsYXN0IHBhcnQgb2YgdGhlCj4gPiA+IHNlbnRl bmNlIGFuZCBtb3ZlIHRoZSBkZXNjcmlwdGlvbiBvZiB0aGUgdHdvIGJlbG93IGZpZWxkcyBhZnRl ciB0aGUKPiA+ID4gdGV4dAo+ID4KPiA+IFRoYXQncyB0cnVlLCBidXQgd2l0aGluIGEgc3BlY2lm aWMgaW1hZ2UsIHRoZSBvbmx5IHZhcnlpbmcgcXVhbnRpdHkKPiA+IGlzIHRoZSBkaXN0YW5jZSwg c28gSSB0aGluayBpdCBpcyBpbXBvcnRhbnQgdG8gZW1waGFzaXplIHRoYXQuCj4gPgo+ID4gQW5k IEkgYWxzbyBxdWl0ZSBsaWtlIHRoaXMgc3RydWN0dXJlIG9mCj4gPiAgIC0gZGVzY3JpcHRpb24g b2Ygc3RlcAo+ID4gICAtIHBhcmFtZXRlcnMgb2Ygc3RlcAo+ID4gICAtIGRlc2NyaXB0aW9uIG9m IHN0ZXAKPiA+ICAgLi4uCj4gPgo+ID4gc28gSSB3b3VsZCBsb3ZlIHRvIGtlZXAgaXQgbGlrZSB0 aGlzLCBpZiB0aGF0J3Mgb2s/Cj4gCj4gT2shCgpBY2suCgo+ID4gPiA+ICsgKgo+ID4gPiA+ICsg KiBAaF9jb3VudF9zdGFydDogaG9yaXpvbnRhbCBjb29yZGluYXRlIG9mIHRoZSBvcHRpY2FsIGNl bnRlciAoMTMtYml0IHVuc2lnbmVkIGludGVnZXI7IFsxLDgxOTFdKQo+ID4gPiA+ICsgKiBAdl9j b3VudF9zdGFydDogdmVydGljYWwgY29vcmRpbmF0ZSBvZiB0aGUgb3B0aWNhbCBjZW50ZXIgKDEz LWJpdCB1bnNpZ25lZCBpbnRlZ2VyOyBbMSw4MTkxXSkKPiA+ID4KPiA+ID4gc28gdGhlc2UgY291 bGQgZ28ganVzdCBiZWZvcmUgQHhfbmYKPiA+ID4KPiA+ID4gPiArICoKPiA+ID4gPiArICogRm9y IGVhY2ggcGl4ZWwsIHRoZSB4L3kgZGlzdGFuY2VzIGZyb20gdGhlIG9wdGljYWwgY2VudGVyIGFy ZSBjYWxjdWxhdGVkIGFuZAo+ID4gPgo+ID4gPiBJIGZvcmdvdDogZGlkIHdlIGVzdGFibGlzaCB0 aGF0IHRoZSBjb3JyZWN0aW9uIGlzIGFwcGxpZWQgdG8gdGhlCj4gPiA+IGV1Y2xpZGVhbiBkaXN0 YW5jZSBvciB0byB4IGFuZCB5IHNlcGFyYXRlbHkgPwo+ID4KPiA+IEdpdmVuIHRoYXQgdGhlcmUg YXJlIHR3byBzZXRzIG9mICJub3JtYWxpemF0aW9uIiBwYXJhbWV0ZXJzLCB0aGUgYXNzdW1wdGlv biBpcyB0aGF0Cj4gPiBhdCBsZWFzdCB0aGUgeC95IGRpc3RhbmNlcyBhcmUgdHJhbnNmb3JtZWQg c2VwYXJhdGVseS4gSSBzZWUgdHdvIHJlYXNvbmFibGUgY2hvaWNlcwo+ID4gYWZ0ZXIgdGhhdDog KGEpIHVzZSB0aGUgdHdvIGRpc3RhbmNlcyBzZXBhcmF0ZWx5LCAoYikgdXNlIHRoZSByYWRpYWwg ZGlzdGFuY2UuIFRoZQo+ID4gZG9jdW1lbnRhdGlvbiBzYXlzIChiKS4gSG93ZXZlciwgdGVzdGlu ZyB3aXRoIHNlbnNvciB0ZXN0IHBhdHRlcm5zIHN1Z2dlc3RzIHRoYXQKPiA+IGl0IGlzIG5vdCB0 aGUgY2FzZSAoYSBob3Jpem9udGFsL3ZlcnRpY2FsIGJvdW5kYXJ5IGJldHdlZW4gYXBwcm9wcmlh dGVseSBjb2xvcmVkCj4gPiByZWdpb25zIHNob3VsZCBoYXZlIGEgY3VydmF0dXJlIGFmdGVyIHRo ZSB0cmFuc2Zvcm1hdGlvbiB3aXRoIGFwcHJvcHJpYXRlIHBhcmFtZXRlcnMpLgo+IAo+IEkgbm93 IHJlY2FsbCB0aGF0IHlvdSBoYXZlIGJlZW4gYWJsZSB0byBzaGlmdCBqdXN0IG9uZSBwbGFuIHdo ZW4gdXNpbmcKPiB0aGUgc2Vuc29yJ3MgdGVzdCBwYXR0ZXJuCgpJIGFncmVlIGFib3V0IHRoZSBu b3JtYWxpemF0aW9uLCBidXQgaXQgc291bmRzIHJlYWxseSB3ZWlyZCB0aGF0IHRoZQpoYXJkd2Fy ZSB3b3VsZCB0aGVuIHNoaWZ0IHNlcGFyYXRlbHkgaW4gdGhlIFggYW5kIFkgZGlyZWN0aW9ucy4g QmVsb3cKeW91IGRvY3VtZW50IHRoZSByYWRpYWwgY29ycmVjdGlvbiBmb3JtdWxhLCB3aGljaCBs b29rcyBjb3JyZWN0IHRvIG1lLgoKPiA+ID4gPiArICogdGhlbiB0cmFuc2Zvcm1lZCBpbnRvIHRo ZSBbMCwyNTVdIHJhbmdlIGJhc2VkIG9uIHRoZSBmb2xsb3dpbmcgZm9ybXVsYToKPiA+ID4KPiA+ ID4gcy90cmFuc2Zvcm1lZC9ub3JtYWxpemVkID8KPiA+Cj4gPiBUbyBiZSBob25lc3QgSSB2YXN0 bHkgcHJlZmVyICJ0cmFuc2Zvcm0iIC8gIm1hcCIgb3ZlciAibm9ybWFsaXplIiBoZXJlLgo+IAo+ IFlvdSdyZSByaWdodCBoZXJlLCB0aGUgYmVsb3cgZm9ybXVsYSBkb2Vzbid0IG5vcm1hbGl6ZSB0 aGUKPiBkaXN0YW5jZSBpbiBhbiBpbnRlcnZhbCBidXQganVzdCByZS1zY2FsZSBpdAo+IAo+ID4g PiA+ICsgKgo+ID4gPiA+ICsgKiAgICgoKGQgPDwgNCkgPj4gcykgKiBmKSA+PiA1Cj4gPiA+ID4g KyAqCj4gPiA+ID4gKyAqIHdoZXJlIGBkYCBpcyB0aGUgZGlzdGFuY2UsIGBzYCBhbmQgYGZgIGFy ZSB0aGUgbm9ybWFsaXphdGlvbiBwYXJhbWV0ZXJzOgo+ID4gPgo+ID4gPiBDYW4geW91IHVzZSAn bnMnIGFuZCAnbmYnIHRvIG1hdGNoIHRoZSBiZWxvdyA/Cj4gPgo+ID4gQWRqdXN0ZWQuCj4gCj4g VGhhbmtzIQo+IAo+ID4gPiA+ICsgKgo+ID4gPiA+ICsgKiBAeF9uZjogaG9yaXpvbnRhbCBub3Jt YWxpemF0aW9uIHNjYWxlIHBhcmFtZXRlciAoNS1iaXQgdW5zaWduZWQgaW50ZWdlcjsgWzAsMzFd KQo+ID4gPiA+ICsgKiBAeF9uczogaG9yaXpvbnRhbCBub3JtYWxpemF0aW9uIHNoaWZ0IHBhcmFt ZXRlciAoNC1iaXQgdW5zaWduZWQgaW50ZWdlcjsgWzAsMTVdKQo+ID4gPiA+ICsgKgo+ID4gPiA+ ICsgKiBAeV9uZjogdmVydGljYWwgbm9ybWFsaXphdGlvbiBzY2FsZSBwYXJhbWV0ZXIgKDUtYml0 IHVuc2lnbmVkIGludGVnZXI7IFswLDMxXSkKPiA+ID4gPiArICogQHlfbnM6IHZlcnRpY2FsIG5v cm1hbGl6YXRpb24gc2hpZnQgcGFyYW1ldGVyICg0LWJpdCB1bnNpZ25lZCBpbnRlZ2VyOyBbMCwx NV0pCj4gPiA+ID4gKyAqCj4gPiA+ID4gKyAqIFRoZXNlIHBhcmFtZXRlcnMgc2hvdWxkIGJlIGNo b3NlbiBiYXNlZCBvbiB0aGUgaW1hZ2UgcmVzb2x1dGlvbiwgdGhlIHBvc2l0aW9uCj4gPiA+ID4g KyAqIG9mIHRoZSBvcHRpY2FsIGNlbnRlciwgYW5kIHRoZSBzaGFwZSBvZiBwaXhlbHM6IHNvIHRo YXQgbm8gbm9ybWFsaXplZCBkaXN0YW5jZQo+ID4gPgo+ID4gPiBzL3BpeGVsczovcGl4ZWxzLwo+ ID4KPiA+IFJlcGxhY2VkIGA6YCB3aXRoIGAsYC4KPiA+Cj4gPiA+ID4gKyAqIGlzIGxhcmdlciB0 aGFuIDI1NS4gSWYgdGhlIHBpeGVscyBoYXZlIHNxdWFyZSBzaGFwZSwgdGhlIHR3byBzZXRzIG9m IHBhcmFtZXRlcnMKPiA+ID4gPiArICogc2hvdWxkIGJlIGVxdWFsLgoKSSB3b25kZXIgaWYgd2Ug Y291bGQgaGF2ZSBhbmlzb3Ryb3BpYyBsZW5zZXMgKGZyb20gdGhlIHBvaW50IG9mIHZpZXcgb2YK Y2hyb21hdGljIGFiZXJyYXRpb25zKSB3aXRoIHNxdWFyZSBwaXhlbHMuIFdlIGNhbiBkZWFsIHdp dGggaXQgbGF0ZXIuCgo+ID4gPiA+ICsgKgo+ID4gPiA+ICsgKiBUaGUgYWN0dWFsIGFtb3VudCBv ZiBjb3JyZWN0aW9uIGlzIGNhbGN1bGF0ZWQgd2l0aCBhIHRoaXJkIGRlZ3JlZSBwb2x5bm9taWFs Ogo+ID4gPiA+ICsgKgo+ID4gPiA+ICsgKiAgIGNbMF0gKiByICsgY1sxXSAqIHJeMiArIGNbMl0g KiByXjMKPiA+ID4gPiArICoKPiA+ID4gPiArICogd2hlcmUgYGNgIGlzIHRoZSBzZXQgb2YgY29l ZmZpY2llbnRzIGZvciB0aGUgZ2l2ZW4gY29sb3IsIGFuZCBgcmAgaXMgZGlzdGFuY2U6Cj4gPiA+ ID4gKyAqCj4gPiA+ID4gKyAqIEByZWQ6IHJlZCBjb2VmZmljaWVudHMgKDUuNCB0d28ncyBjb21w bGVtZW50OyBbLTE2LDE1LjkzNzVdKQo+ID4gPiA+ICsgKiBAYmx1ZTogYmx1ZSBjb2VmZmljaWVu dHMgKDUuNCB0d28ncyBjb21wbGVtZW50OyBbLTE2LDE1LjkzNzVdKQo+ID4gPiA+ICsgKgo+ID4g PiA+ICsgKiBGaW5hbGx5LCB0aGUgYW1vdW50IGlzIGNsaXBwZWQgYXMgcmVxdWVzdGVkOgo+ID4g PiA+ICsgKgo+ID4gPiA+ICsgKiBAaF9jbGlwX21vZGU6IG1heGltdW0gaG9yaXpvbnRhbCBzaGlm dCAoZnJvbSBlbnVtIHJraXNwMV9jaWZfaXNwX2NhY19oX2NsaXBfbW9kZSkKPiA+ID4gPiArICog QHZfY2xpcF9tb2RlOiBtYXhpbXVtIHZlcnRpY2FsIHNoaWZ0IChmcm9tIGVudW0gcmtpc3AxX2Np Zl9pc3BfY2FjX3ZfY2xpcF9tb2RlKQo+ID4gPiA+ICsgKgo+ID4gPiA+ICsgKiBBIHBvc2l0aXZl IHJlc3VsdCB3aWxsIHNoaWZ0IGF3YXkgZnJvbSB0aGUgb3B0aWNhbCBjZW50ZXIsIHdoaWxlIGEg bmVnYXRpdmUKPiA+ID4gPiArICogb25lIHdpbGwgc2hpZnQgdG93YXJkcyB0aGUgb3B0aWNhbCBj ZW50ZXIuIEluIHRoZSBsYXR0ZXIgY2FzZSwgdGhlIHBpeGVsCj4gPiA+ID4gKyAqIHZhbHVlcyBh dCB0aGUgZWRnZXMgYXJlIGR1cGxpY2F0ZWQuCj4gPiA+ID4gKyAqLwo+ID4gPiA+ICtzdHJ1Y3Qg cmtpc3AxX2NpZl9pc3BfY2FjX2NvbmZpZyB7Cj4gPiA+ID4gKwlfX3U4IGhfY2xpcF9tb2RlOwo+ ID4gPiA+ICsJX191OCB2X2NsaXBfbW9kZTsKPiA+ID4gPiArCj4gPiA+ID4gKwlfX3UxNiBoX2Nv dW50X3N0YXJ0Owo+ID4gPiA+ICsJX191MTYgdl9jb3VudF9zdGFydDsKPiA+ID4gPiArCj4gPiA+ ID4gKwlfX3UxNiByZWRbM107Cj4gPiA+ID4gKwlfX3UxNiBibHVlWzNdOwo+ID4gPiA+ICsKPiA+ ID4gPiArCV9fdTggeF9uZjsKPiA+ID4gPiArCV9fdTggeF9uczsKPiA+ID4gPiArCj4gPiA+ID4g KwlfX3U4IHlfbmY7Cj4gPiA+ID4gKwlfX3U4IHlfbnM7Cj4gPiA+ID4gK307Cj4gPiA+ID4gKwo+ ID4gPiA+ICAgLyotLS0tLS0tLS0tIFBBUlQyOiBNZWFzdXJlbWVudCBTdGF0aXN0aWNzIC0tLS0t LS0tLS0tLSovCj4gPiA+ID4KPiA+ID4gPiAgIC8qKgo+ID4gPiA+IEBAIC0xMTYxLDYgKzEyNDcs NyBAQCBlbnVtIHJraXNwMV9leHRfcGFyYW1zX2Jsb2NrX3R5cGUgewo+ID4gPiA+ICAgCVJLSVNQ MV9FWFRfUEFSQU1TX0JMT0NLX1RZUEVfQ09NUEFORF9FWFBBTkQsCj4gPiA+ID4gICAJUktJU1Ax X0VYVF9QQVJBTVNfQkxPQ0tfVFlQRV9DT01QQU5EX0NPTVBSRVNTLAo+ID4gPiA+ICAgCVJLSVNQ MV9FWFRfUEFSQU1TX0JMT0NLX1RZUEVfV0RSLAo+ID4gPiA+ICsJUktJU1AxX0VYVF9QQVJBTVNf QkxPQ0tfVFlQRV9DQUMsCj4gPiA+ID4gICB9Owo+ID4gPiA+Cj4gPiA+ID4gICAvKiBGb3IgYmFj a3dhcmQgY29tcGF0aWJpbGl0eSAqLwo+ID4gPiA+IEBAIC0xNTA3LDYgKzE1OTQsMjIgQEAgc3Ry dWN0IHJraXNwMV9leHRfcGFyYW1zX3dkcl9jb25maWcgewo+ID4gPiA+ICAgCXN0cnVjdCBya2lz cDFfY2lmX2lzcF93ZHJfY29uZmlnIGNvbmZpZzsKPiA+ID4gPiAgIH0gX19hdHRyaWJ1dGVfXygo YWxpZ25lZCg4KSkpOwo+ID4gPiA+Cj4gPiA+ID4gKy8qKgo+ID4gPiA+ICsgKiBzdHJ1Y3Qgcmtp c3AxX2V4dF9wYXJhbXNfY2FjX2NvbmZpZyAtIFJrSVNQMSBleHRlbnNpYmxlIHBhcmFtcyBDQUMg Y29uZmlnCj4gPiA+ID4gKyAqCj4gPiA+ID4gKyAqIFJrSVNQMSBleHRlbnNpYmxlIHBhcmFtZXRl cnMgQ0FDIGJsb2NrLgo+ID4gPiA+ICsgKiBJZGVudGlmaWVkIGJ5IDpjOnR5cGU6YFJLSVNQMV9F WFRfUEFSQU1TX0JMT0NLX1RZUEVfQ0FDYC4KPiA+ID4gPiArICoKPiA+ID4gPiArICogQGhlYWRl cjogVGhlIFJrSVNQMSBleHRlbnNpYmxlIHBhcmFtZXRlcnMgaGVhZGVyLCBzZWUKPiA+ID4gPiAr ICoJICAgIDpjOnR5cGU6YHJraXNwMV9leHRfcGFyYW1zX2Jsb2NrX2hlYWRlcmAKPiA+ID4gPiAr ICogQGNvbmZpZzogQ0FDIGNvbmZpZ3VyYXRpb24sIHNlZQo+ID4gPiA+ICsgKgkgICAgOmM6dHlw ZTpgcmtpc3AxX2NpZl9pc3BfY2FjX2NvbmZpZ2AKPiA+ID4gPiArICovCj4gPiA+ID4gK3N0cnVj dCBya2lzcDFfZXh0X3BhcmFtc19jYWNfY29uZmlnIHsKPiA+ID4gPiArCXN0cnVjdCBya2lzcDFf ZXh0X3BhcmFtc19ibG9ja19oZWFkZXIgaGVhZGVyOwo+ID4gPiA+ICsJc3RydWN0IHJraXNwMV9j aWZfaXNwX2NhY19jb25maWcgY29uZmlnOwo+ID4gPiA+ICt9IF9fYXR0cmlidXRlX18oKGFsaWdu ZWQoOCkpKTsKPiA+ID4gPiArCj4gPiA+ID4gICAvKgo+ID4gPiA+ICAgICogVGhlIHJraXNwMV9l eHRfcGFyYW1zX2NvbXBhbmRfY3VydmVfY29uZmlnIHN0cnVjdHVyZSBpcyBjb3VudGVkIHR3aWNl IGFzIGl0Cj4gPiA+ID4gICAgKiBpcyB1c2VkIGZvciBib3RoIHRoZSBDT01QQU5EX0VYUEFORCBh bmQgQ09NUEFORF9DT01QUkVTUyBibG9jayB0eXBlcy4KPiA+ID4gPiBAQCAtMTUzMiw3ICsxNjM1 LDggQEAgc3RydWN0IHJraXNwMV9leHRfcGFyYW1zX3dkcl9jb25maWcgewo+ID4gPiA+ICAgCXNp emVvZihzdHJ1Y3Qgcmtpc3AxX2V4dF9wYXJhbXNfY29tcGFuZF9ibHNfY29uZmlnKQkJK1wKPiA+ ID4gPiAgIAlzaXplb2Yoc3RydWN0IHJraXNwMV9leHRfcGFyYW1zX2NvbXBhbmRfY3VydmVfY29u ZmlnKQkJK1wKPiA+ID4gPiAgIAlzaXplb2Yoc3RydWN0IHJraXNwMV9leHRfcGFyYW1zX2NvbXBh bmRfY3VydmVfY29uZmlnKQkJK1wKPiA+ID4gPiAtCXNpemVvZihzdHJ1Y3Qgcmtpc3AxX2V4dF9w YXJhbXNfd2RyX2NvbmZpZykpCj4gPiA+ID4gKwlzaXplb2Yoc3RydWN0IHJraXNwMV9leHRfcGFy YW1zX3dkcl9jb25maWcpCQkJK1wKPiA+ID4gPiArCXNpemVvZihzdHJ1Y3Qgcmtpc3AxX2V4dF9w YXJhbXNfY2FjX2NvbmZpZykpCj4gPiA+Cj4gPiA+IEFsbCBtaW5vcnMsIHBsZWFzZSBhZGQKPiA+ ID4gUmV2aWV3ZWQtYnk6IEphY29wbyBNb25kaSA8amFjb3BvLm1vbmRpQGlkZWFzb25ib2FyZC5j b20+CgphbmQKClJldmlld2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0 QGlkZWFzb25ib2FyZC5jb20+Cgo+ID4gPiA+Cj4gPiA+ID4gICAvKioKPiA+ID4gPiAgICAqIGVu dW0gcmtzaXAxX2V4dF9wYXJhbV9idWZmZXJfdmVyc2lvbiAtIFJrSVNQMSBleHRlbnNpYmxlIHBh cmFtZXRlcnMgdmVyc2lvbgoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBt YWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg==