All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Ghadi Rahme <ghadi.rahme@canonical.com>
Cc: stable@vger.kernel.org, Steve French <sfrench@samba.org>,
	Paulo Alcantara <pc@cjr.nz>,
	Ronnie Sahlberg <lsahlber@redhat.com>,
	Shyam Prasad N <sprasad@microsoft.com>,
	Tom Talpey <tom@talpey.com>, Aurelien Aptel <aaptel@suse.com>,
	linux-cifs@vger.kernel.org, samba-technical@lists.samba.org
Subject: Re: [PATCH v2 6.1.y] smb/dfs_cache: Fix NULL pointer dereference on session connection failure
Date: Tue, 31 Mar 2026 10:27:38 +0200	[thread overview]
Message-ID: <2026033136-refining-ladybug-08b0@gregkh> (raw)
In-Reply-To: <0dcbb073-4745-479a-8d55-bdb0a3fe55e8@canonical.com>

On Tue, Mar 31, 2026 at 10:54:08AM +0300, Ghadi Rahme wrote:
> > Then why not backport the specific changes that caused newer kernels to
> not be affected?
> 
> Based on the documentation [1] for submitting patches to stable, the patch
> cannot be over 100 lines long with context.
> 
> The upstream patch exceeds this limit by a lot and cherry picking the
> specific changes from it that remove this function is not feasible without
> causing the driver to break. In other words the removal of
> "find_ipc_from_server_path" is dependent on this refactor.
> 
> > Backport the same changes?
> 
> I can go ahead with this solution, given I get the green light to ignore the
> 100 line rule.
> 
> [1] https://www.kernel.org/doc/html/v4.11/process/stable-kernel-rules.html#

We take "large" backports from mainline all the time, as long as the
maintainers for the subsystem are ok with it.  to take one-off patches
is usually much harder as the change itself is almost always "wrong",
and then future changes are even harder to backport.

So I recommend working with the maintainers here please and see what
they want to do, if anything.

thanks,

greg k-h

      reply	other threads:[~2026-03-31  8:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19 14:49 [PATCH v2 6.1.y] smb/dfs_cache: Fix NULL pointer dereference on session connection failure Ghadi Elie Rahme
2026-03-23 13:01 ` Greg KH
2026-03-31  6:59   ` Ghadi Rahme
2026-03-31  7:10     ` Greg KH
2026-03-31  7:54       ` Ghadi Rahme
2026-03-31  8:27         ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026033136-refining-ladybug-08b0@gregkh \
    --to=greg@kroah.com \
    --cc=aaptel@suse.com \
    --cc=ghadi.rahme@canonical.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=lsahlber@redhat.com \
    --cc=pc@cjr.nz \
    --cc=samba-technical@lists.samba.org \
    --cc=sfrench@samba.org \
    --cc=sprasad@microsoft.com \
    --cc=stable@vger.kernel.org \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.