Re: [LTP] [PATCH v2] userfaultfd: Add new test using UFFDIO_CONTINUE

[Petr Vorel <pvorel@suse.cz>]

Hi Ricardo,

> On 3/31/26 12:18 PM, Petr Vorel wrote:
> > Maybe SAFE_SYSCONF(_SC_PAGE_SIZE) or because it should be safe:
> > getpagesize();

> Opted for SAFE_SYSCONF as getpagesize() returns int.
+1

> > > +	}
> > > +
> > > +	if (uffd != -1) {
> > > +		SAFE_CLOSE(uffd);
> > > +		uffd = -1;
> > And here.

> Andrea pointed me to this LLM suggestion that got it wrong:
> https://github.com/acerv/ltp-agent/actions/runs/23788068990

> It's a cool thing that we're reviewing code that I used as template
> to fix the userfaultfd tests in the other PR with fixes.

Yeah, I already asked him yesterday to teach agent to have look into includes as
well :).

Kind regards,
Petr

> Best,
> Ricardo.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp