From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A72632F25F5 for ; Wed, 1 Apr 2026 06:31:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775025110; cv=none; b=j7wIwmPzlherF1GjZc6MhrdpseAgozzOLjq/AcHD0dUGG1IvvwxCjiet02YPldhmiK78pIE4J1hMW6CGsTV9cX6/tiABxgrFwpvzpFj7Lbg1Uc59nrDi79gWL1VYkZUhY0JNayqaHIGlVmPFH6/B2dozh51Zq5m5OSi7OehtDic= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775025110; c=relaxed/simple; bh=FmG9+oEc3u0Io3xHytit6dYoUo70py6nf+qvoLgQLuc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M/aeauuwy4Ce0BIjXeyhPkPnSVsDFRy55DX3CZIZ5K6qG4l3HWjiqavgsUk3FAnGNAgI/nEpFmUhl9o2lHEM7CpG1oGh4GuAkQfQIC6JlwAS8bjHS/9rybjibuTyMk5Vn4Mgyi1vcfwBNlTOSv3kXA7ZBHpRqk+dYjdQR+WjvM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 56EA368AFE; Wed, 1 Apr 2026 08:31:47 +0200 (CEST) Date: Wed, 1 Apr 2026 08:31:46 +0200 From: Christoph Hellwig To: Andrey Albershteyn Cc: linux-xfs@vger.kernel.org, fsverity@lists.linux.dev, linux-fsdevel@vger.kernel.org, ebiggers@kernel.org, hch@lst.de, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-btrfs@vger.kernel.org, djwong@kernel.org Subject: Re: [PATCH v6 21/22] xfs: add fsverity traces Message-ID: <20260401063146.GD24459@lst.de> References: <20260331212827.2631020-1-aalbersh@kernel.org> <20260331212827.2631020-22-aalbersh@kernel.org> Precedence: bulk X-Mailing-List: fsverity@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260331212827.2631020-22-aalbersh@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Wouldn't most of these trace points make more sense in the core fsverity code before calling into the file system? Otherwise they look good to me. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 616DF1076372 for ; Wed, 1 Apr 2026 06:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0LHgJGnO7hpnwCFqWjZTH8sfT9StWTjTfOO69oVmQGQ=; b=SpspOdx0qaCBMlAqWEmanv+eqZ SjcqttWh2XPfcbg/guFuC2YhzkHszo9+qNShOnbiEfuqeSzTFSEw7O1nm/tvhXqZus09bqPuhxi4x QGj8KmQZn43wh7EWBKnkHGy8MrHp6voDpt/bJBYOxIZ9rwJZO35RyAk0aqwnca8eU850=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1w7p7M-00083p-PJ; Wed, 01 Apr 2026 06:31:56 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1w7p7K-00083i-W7 for linux-f2fs-devel@lists.sourceforge.net; Wed, 01 Apr 2026 06:31:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FmG9+oEc3u0Io3xHytit6dYoUo70py6nf+qvoLgQLuc=; b=eR1+DK1FvjdTub0f8hI8XIhClP b8HVFkmYbQW+jTaC07Q6jFf5d8BLhh7jABiCGjwJQJFOfFAXSqHgBIprBpD9hmkQJcGiEtZOQK6dP zwGzEB55AJ9CtgxWFU7H0DNxLRngDZfSWvk2BXYJzGJ+6lSctHxflZO1gTy7TjAEOAO4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FmG9+oEc3u0Io3xHytit6dYoUo70py6nf+qvoLgQLuc=; b=KywzfzzmQY/+kpBQrkl2HHZJJJ PEqiw2jh94etPDokY3j//J08lZTTRAe/Xt+1ELxw7x4borbyJLT+CpYTRajU98PMFC0oJd3LBF8zY MlQGHtvz15FQlRjPXupCP5qjAXzWs5gftYffUDKOx495aQ3CX/aoYnyNKvu0uNGzMVFc=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1w7p7K-0000lU-HI for linux-f2fs-devel@lists.sourceforge.net; Wed, 01 Apr 2026 06:31:54 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 56EA368AFE; Wed, 1 Apr 2026 08:31:47 +0200 (CEST) Date: Wed, 1 Apr 2026 08:31:46 +0200 From: Christoph Hellwig To: Andrey Albershteyn Message-ID: <20260401063146.GD24459@lst.de> References: <20260331212827.2631020-1-aalbersh@kernel.org> <20260331212827.2631020-22-aalbersh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260331212827.2631020-22-aalbersh@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1w7p7K-0000lU-HI Subject: Re: [f2fs-dev] [PATCH v6 21/22] xfs: add fsverity traces X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fsverity@lists.linux.dev, ebiggers@kernel.org, djwong@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, hch@lst.de, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Wouldn't most of these trace points make more sense in the core fsverity code before calling into the file system? Otherwise they look good to me. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel