From: Jackie Liu <liu.yun@linux.dev>
To: axboe@kernel.dk, yukuai@fnnas.com
Cc: linux-block@vger.kernel.org
Subject: [PATCH 09/10] block: replace simple_strtoul() with kstrtoint() in part_timeout_store()
Date: Wed, 1 Apr 2026 15:07:15 +0800 [thread overview]
Message-ID: <20260401070716.991-10-liu.yun@linux.dev> (raw)
In-Reply-To: <20260401070716.991-1-liu.yun@linux.dev>
From: Jackie Liu <liuyun01@kylinos.cn>
simple_strtoul() is deprecated. Switch to kstrtoint() which also
removes the need for the const-discarding cast and the if (count)
wrapper.
Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
---
block/blk-timeout.c | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/block/blk-timeout.c b/block/blk-timeout.c
index eab6422fad4b..ea3c5451d6cf 100644
--- a/block/blk-timeout.c
+++ b/block/blk-timeout.c
@@ -49,18 +49,16 @@ ssize_t part_timeout_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
{
struct gendisk *disk = dev_to_disk(dev);
+ struct request_queue *q = disk->queue;
int val;
- if (count) {
- struct request_queue *q = disk->queue;
- char *p = (char *) buf;
+ if (kstrtoint(buf, 10, &val))
+ return -EINVAL;
- val = simple_strtoul(p, &p, 10);
- if (val)
- blk_queue_flag_set(QUEUE_FLAG_FAIL_IO, q);
- else
- blk_queue_flag_clear(QUEUE_FLAG_FAIL_IO, q);
- }
+ if (val)
+ blk_queue_flag_set(QUEUE_FLAG_FAIL_IO, q);
+ else
+ blk_queue_flag_clear(QUEUE_FLAG_FAIL_IO, q);
return count;
}
--
2.51.1
next prev parent reply other threads:[~2026-04-01 7:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 7:07 [PATCH 00/10] block: sysfs cleanup for deprecated API usage Jackie Liu
2026-04-01 7:07 ` [PATCH 01/10] block: convert to sysfs_emit() in blk_ia_range show() Jackie Liu
2026-04-01 7:07 ` [PATCH 02/10] block: convert blk-mq hw sysfs show to sysfs_emit/sysfs_emit_at Jackie Liu
2026-04-01 7:07 ` [PATCH 03/10] block: convert disk events " Jackie Liu
2026-04-01 7:07 ` [PATCH 04/10] block: convert partition sysfs show to sysfs_emit() Jackie Liu
2026-04-01 7:07 ` [PATCH 05/10] block: convert part_timeout_show() " Jackie Liu
2026-04-01 7:07 ` [PATCH 06/10] block: convert kyber latency show " Jackie Liu
2026-04-01 7:07 ` [PATCH 07/10] block: convert bfq_var_show() " Jackie Liu
2026-04-01 7:07 ` [PATCH 08/10] block: use kstrtol() instead of sscanf() in disk_events_poll_msecs_store() Jackie Liu
2026-04-01 7:07 ` Jackie Liu [this message]
2026-04-01 7:07 ` [PATCH 10/10] block: replace sscanf() with kstrtoint() in part_fail_store() Jackie Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260401070716.991-10-liu.yun@linux.dev \
--to=liu.yun@linux.dev \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=yukuai@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.