From: Andrew Morton <akpm@linux-foundation.org>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: Muchun Song <muchun.song@linux.dev>,
Muchun Song <songmuchun@bytedance.com>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Petr Tesarik <ptesarik@suse.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/sparse: fix BUILD_BUG_ON check for section map alignment
Date: Wed, 1 Apr 2026 09:33:08 -0700 [thread overview]
Message-ID: <20260401093308.6fe32f4de4bc15ee6495fa68@linux-foundation.org> (raw)
In-Reply-To: <1f8d0cd2-c990-4597-bf47-5a8217acc464@kernel.org>
On Wed, 1 Apr 2026 09:26:49 +0200 "David Hildenbrand (Arm)" <david@kernel.org> wrote:
> > My original motivation was simply that when I read this part of the code,
> > the comment felt a bit off to me, so I just fixed it casually. But if it
> > ends up creating the impression that "we might be supporting something
> > we don't," as you said, then I'm fine with dropping this patch.
>
> Can you rework your patch to only simplify the comment, and to clarify
> that we always expect a single section to cover full pages?
And to fix the sh4-allnoconfig build breakage ;)
https://lkml.kernel.org/r/202604011400.OFLcOOmf-lkp@intel.com
I'll disappear this patch.
next prev parent reply other threads:[~2026-04-01 16:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 11:30 [PATCH] mm/sparse: fix BUILD_BUG_ON check for section map alignment Muchun Song
2026-03-31 19:55 ` Andrew Morton
2026-03-31 20:04 ` David Hildenbrand (Arm)
2026-04-01 2:47 ` Muchun Song
2026-03-31 20:07 ` Andrew Morton
2026-04-01 2:47 ` Muchun Song
2026-03-31 20:29 ` David Hildenbrand (Arm)
2026-04-01 2:57 ` Muchun Song
2026-04-01 2:59 ` Muchun Song
2026-04-01 4:01 ` Muchun Song
2026-04-01 7:08 ` David Hildenbrand (Arm)
2026-04-01 7:23 ` Muchun Song
2026-04-01 7:26 ` David Hildenbrand (Arm)
2026-04-01 7:28 ` Muchun Song
2026-04-01 16:33 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-04-03 8:45 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260401093308.6fe32f4de4bc15ee6495fa68@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=david@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=ptesarik@suse.com \
--cc=rppt@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.