From: Christoph Hellwig <hch@lst.de>
To: Jeff Layton <jlayton@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Chuck Lever <chuck.lever@oracle.com>,
Amir Goldstein <amir73il@gmail.com>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/4] nfsd/blocklayout: always ignore loca_time_modify
Date: Wed, 1 Apr 2026 16:25:14 +0200 [thread overview]
Message-ID: <20260401142514.GA22685@lst.de> (raw)
In-Reply-To: <47bf9653ce304f973cef6248e10a7dba4d958140.camel@kernel.org>
On Tue, Mar 31, 2026 at 01:09:28PM -0400, Jeff Layton wrote:
> > iattr.ia_valid |= ATTR_ATIME | ATTR_CTIME | ATTR_MTIME;
> > - iattr.ia_atime = iattr.ia_ctime = iattr.ia_mtime = lcp->lc_mtime;
> > + iattr.ia_atime = iattr.ia_ctime = iattr.ia_mtime = current_time(inode);
>
> Technically, these fields are completely ignored by notify_change,
> unless their counterpart ATTR_?TIME_SET flag is set, so you could just
> leave them unset.
We're not actually going through notify_change here, so for now we'll
need this assignment for non-mgtime file systems.
Btw, shouldn't we move the actual time sampling from notify_change into
->setattr for non-mgtime file systems to avoid the extra sampling in
notify_change for the mgtime fast path?
next prev parent reply other threads:[~2026-04-01 14:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 15:33 cleanup block-style layouts exports Christoph Hellwig
2026-03-31 15:33 ` [PATCH 1/4] nfsd/blocklayout: always ignore loca_time_modify Christoph Hellwig
2026-03-31 17:09 ` Jeff Layton
2026-04-01 14:25 ` Christoph Hellwig [this message]
2026-03-31 15:33 ` [PATCH 2/4] exportfs: split out the ops for layout-based block device access Christoph Hellwig
2026-03-31 17:24 ` Jeff Layton
2026-04-01 14:27 ` Christoph Hellwig
2026-03-31 18:07 ` Chuck Lever
2026-04-01 6:23 ` Christoph Hellwig
2026-03-31 15:33 ` [PATCH 3/4] exportfs: don't pass struct iattr to ->commit_blocks Christoph Hellwig
2026-03-31 17:26 ` Jeff Layton
2026-03-31 17:30 ` Chuck Lever
2026-03-31 17:33 ` Jeff Layton
2026-04-01 6:24 ` Christoph Hellwig
2026-03-31 15:33 ` [PATCH 4/4] exportfs,nfsd: rework checking for layout-based block device access support Christoph Hellwig
2026-03-31 17:52 ` Jeff Layton
2026-03-31 18:00 ` Chuck Lever
2026-03-31 17:33 ` cleanup block-style layouts exports Chuck Lever
2026-04-01 6:19 ` Christoph Hellwig
2026-04-01 13:39 ` Chuck Lever
-- strict thread matches above, loose matches on Subject: below --
2026-04-01 14:40 cleanup block-style layouts exports v2 Christoph Hellwig
2026-04-01 14:40 ` [PATCH 1/4] nfsd/blocklayout: always ignore loca_time_modify Christoph Hellwig
2026-04-23 18:15 [PATCH 0/4] cleanup block-style layouts exports v3 Chuck Lever
2026-04-23 18:15 ` [PATCH 1/4] nfsd/blocklayout: always ignore loca_time_modify Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260401142514.GA22685@lst.de \
--to=hch@lst.de \
--cc=Dai.Ngo@oracle.com \
--cc=amir73il@gmail.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.