From: Jakub Kicinski <kuba@kernel.org>
To: Tyllis Xu <livelycarpet87@gmail.com>
Cc: haren@linux.ibm.com, ricklind@linux.ibm.com,
nnac123@linux.ibm.com, sukadev@linux.ibm.com,
davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
andrew+netdev@lunn.ch, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
ychen@northwestern.edu, Yuhao Jiang <danisjiang@gmail.com>
Subject: Re: [PATCH v2] ibmvnic: fix OOB array access in ibmvnic_xmit on queue count reduction
Date: Wed, 1 Apr 2026 18:43:55 -0700 [thread overview]
Message-ID: <20260401184355.2a063cb4@kernel.org> (raw)
In-Reply-To: <20260401050845.1388145-1-LivelyCarpet87@gmail.com>
On Wed, 1 Apr 2026 00:08:45 -0500 Tyllis Xu wrote:
> When the number of TX queues is reduced (e.g., via ethtool -L), the
> Qdisc layer retains previously enqueued skbs with queue mappings from
> before the reduction. After the reset completes and tx_queues_active is
> set to true, netif_tx_start_all_queues() drains these stale skbs through
> ibmvnic_xmit(). The queue index from skb_get_queue_mapping() may exceed
> the newly allocated array bounds, causing out-of-bounds reads on
> tx_scrq[] and tx_pool[]/tso_pool[].
This should not happen if the interface configures itself correctly, see
https://lore.kernel.org/all/20260106182244.7188a8f6@kernel.org/
Please share are a repro if you have one.
prev parent reply other threads:[~2026-04-02 1:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 3:54 [PATCH] ibmvnic: fix OOB array access in ibmvnic_xmit on queue count reduction Tyllis Xu
2026-03-23 14:45 ` Simon Horman
2026-03-24 6:16 ` Tyllis Xu
2026-04-01 5:08 ` [PATCH v2] " Tyllis Xu
2026-04-02 1:43 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260401184355.2a063cb4@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=danisjiang@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haren@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=livelycarpet87@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nnac123@linux.ibm.com \
--cc=pabeni@redhat.com \
--cc=ricklind@linux.ibm.com \
--cc=stable@vger.kernel.org \
--cc=sukadev@linux.ibm.com \
--cc=ychen@northwestern.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.