From: Sudarshan Srinivasan <ss22.kern.dev@gmail.com>
To: mchehab@kernel.org, gregkh@linuxfoundation.org, error27@gmail.com
Cc: Sudarshan Srinivasan <ss22.kern.dev@gmail.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: [PATCH v4] staging: media: av7110: coding style fixes: too many tabs
Date: Thu, 2 Apr 2026 00:47:42 +0530 [thread overview]
Message-ID: <20260401191743.26951-1-ss22.kern.dev@gmail.com> (raw)
Fix warning reported by checkpatch.pl
"WARNING: Too many leading tabs - consider code refactoring"
Signed-off-by: Sudarshan Srinivasan <ss22.kern.dev@gmail.com>
---
v4:
- Added the missing check for "feed->ts_type"
- Removed initialization of 'ret'
- handle_ts_memory_fe() accepts only "feed", "demux" and "av7110" extracted thereafter
- demux->playing assigned to int, instead of bool to maintain original style
v3:
- Removed the additional tabs in handle_ts_memory_fe() as indicated by Greg KH
- Retained the original code style as suggested by Dan Carpenter
v2:
- Refactored change by adding function handle_ts_memory_fe
v2: https://lore.kernel.org/linux-staging/20260318191149.109616-1-ss22.kern.dev@gmail.com/
v1: https://lore.kernel.org/linux-staging/20260316152340.238100-1-ss22.kern.dev@gmail.com/
drivers/staging/media/av7110/av7110.c | 36 +++++++++++++++++++--------
1 file changed, 26 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c
index 607992100baf..486dd8010e7f 100644
--- a/drivers/staging/media/av7110/av7110.c
+++ b/drivers/staging/media/av7110/av7110.c
@@ -932,6 +932,31 @@ static int dvb_feed_stop_pid(struct dvb_demux_feed *dvbdmxfeed)
return ret;
}
+static int handle_ts_memory_fe(struct dvb_demux_feed *feed)
+{
+ struct dvb_demux *demux = feed->demux;
+ struct av7110 *av7110 = demux->priv;
+ int ret;
+
+ if (!(feed->ts_type & TS_DECODER))
+ return 0;
+
+ if (feed->pes_type >= 2)
+ return 0;
+
+ if ((demux->pids[0] & 0x8000) || (demux->pids[1] & 0x8000))
+ return 0;
+
+ dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout);
+ dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout);
+
+ ret = av7110_av_start_play(av7110, RP_AV);
+ if (!ret)
+ demux->playing = 1;
+
+ return ret;
+}
+
static int av7110_start_feed(struct dvb_demux_feed *feed)
{
struct dvb_demux *demux = feed->demux;
@@ -951,16 +976,7 @@ static int av7110_start_feed(struct dvb_demux_feed *feed)
(feed->pes_type <= DMX_PES_PCR)) {
switch (demux->dmx.frontend->source) {
case DMX_MEMORY_FE:
- if (feed->ts_type & TS_DECODER)
- if (feed->pes_type < 2 &&
- !(demux->pids[0] & 0x8000) &&
- !(demux->pids[1] & 0x8000)) {
- dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout);
- dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout);
- ret = av7110_av_start_play(av7110, RP_AV);
- if (!ret)
- demux->playing = 1;
- }
+ ret = handle_ts_memory_fe(feed);
break;
default:
ret = dvb_feed_start_pid(feed);
--
2.43.0
next reply other threads:[~2026-04-01 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 19:17 Sudarshan Srinivasan [this message]
2026-04-02 12:50 ` [PATCH v4] staging: media: av7110: coding style fixes: too many tabs Dan Carpenter
2026-05-05 12:43 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260401191743.26951-1-ss22.kern.dev@gmail.com \
--to=ss22.kern.dev@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.