From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46A55175A79; Wed, 1 Apr 2026 21:19:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775078344; cv=none; b=o9y4uugMKHGO4xCvNzmTz2BWoPHVg3hWgaT3I0IqKWZYpN4BVGVPviNPvf0nM4ocX42u1f64A7B82CGaNMsaYK74Z6Axn7qJFIBYmCAkf61pXvNMZIC2ujwZDC/jGMcOcnxwrv6YNVX9aE4rNEgKwOh2xz1+ZBfARX76qlzq2q0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775078344; c=relaxed/simple; bh=ZUftJy/Eg2vooutQH6w/+XirdMYySx6JVlXp754Vgdk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V5zhdi62WO3MjJvhmedDJg6252op22AGTnw8XdIM0UmPqOYWinnxOk6Q3T5S5+2QnatnUouJcdAzq7LPYYiKd31s1ruI3ISfLhnWs/A1Jp8U+NuAUOvtuRJXQlU+Ikd2Rq5KXfV5m7vGHnI1sPRe883kTvu4z7GMd/SU7jbYf4E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jD3Jb1ty; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jD3Jb1ty" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92E56C4CEF7; Wed, 1 Apr 2026 21:19:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775078343; bh=ZUftJy/Eg2vooutQH6w/+XirdMYySx6JVlXp754Vgdk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jD3Jb1tyAXHJ7rlEQVgRfpLV2q36bVM+ZajV5KTZtkYLuqlKdfLGdjCpcy0YnRnbi LoLgBIqHi+42FatuccDnBFDivdoaKpF07bf+PUeofoud0KB0kILvHTwfnNr+wV1Aa6 ojA8OH7ghnBr07KKD5W+MJmxN0ig7il2HpVBOqc3Si1yz5HvBAiqiaYP7rfDfiQXz5 gvCbKx8DnrxuEsyb7EO6QrlJeDeTqifD0tfUem+skhvVcglnV+FvF/Xw4hsMFllqjZ y+d3meadPcE1/VqbKbjkdKbo9sj1+GwnPXFD2uG1NnYG5a8cUTLgXieYD+hkSeKO8n ECkQRhTDfjUOA== Date: Wed, 1 Apr 2026 14:19:01 -0700 From: Eric Biggers To: Andrey Albershteyn Cc: linux-xfs@vger.kernel.org, fsverity@lists.linux.dev, linux-fsdevel@vger.kernel.org, hch@lst.de, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-btrfs@vger.kernel.org, djwong@kernel.org Subject: Re: [PATCH v6 01/22] fsverity: report validation errors through fserror to fsnotify Message-ID: <20260401211901.GF2466@quark> References: <20260331212827.2631020-1-aalbersh@kernel.org> <20260331212827.2631020-2-aalbersh@kernel.org> Precedence: bulk X-Mailing-List: fsverity@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260331212827.2631020-2-aalbersh@kernel.org> On Tue, Mar 31, 2026 at 11:28:02PM +0200, Andrey Albershteyn wrote: > Reported verification errors to fsnotify through recently added fserror > interface. > > Signed-off-by: Andrey Albershteyn > Reviewed-by: "Darrick J. Wong" > Reviewed-by: Christoph Hellwig > --- > fs/verity/verify.c | 4 ++++ > 1 file changed, 4 insertions(+) Acked-by: Eric Biggers > if (memchr_inv(dblock->data, 0, params->block_size)) { > + fserror_report_data_lost(inode, data_pos, > + params->block_size, GFP_NOFS); > fsverity_err(inode, > "FILE CORRUPTED! Data past EOF is not zeroed"); > return false; > @@ -312,6 +315,7 @@ static bool verify_data_block(struct fsverity_info *vi, > data_pos, level - 1, params->hash_alg->name, hsize, want_hash, > params->hash_alg->name, hsize, > level == 0 ? dblock->real_hash : real_hash); > + fserror_report_data_lost(inode, data_pos, params->block_size, GFP_NOFS); The first case does the fserror call first and the log message second, and the second case does them in the opposite order. I don't think it matters what the order is, but they should be consistent. - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC1F110FCAE6 for ; Wed, 1 Apr 2026 21:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aJLVSIHw/KpTUKn7dHYolEJXhQp2RxxpMiq2pcbGY6U=; b=TGfDbe2NKUg8BoFeA/0vdGddMk j2lo7avKD85JVNg+bvr3O1cRKs+ShXWIjIujA6LVaFBDYxJrYFRL+DKyIDh2Qr8AtYggoB1G0lyjw 4OuQiwH3smk+zKuhw2tDKTCdzZF2lQV0FEpEW/V468624ZaIdOez2LP8bKE0qG9SdJFA=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1w82y4-0005iA-N1; Wed, 01 Apr 2026 21:19:16 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1w82y3-0005i2-Hg for linux-f2fs-devel@lists.sourceforge.net; Wed, 01 Apr 2026 21:19:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DV65+fK+aTlygf1u1TAw1mumFxNjza5Cu2q1OKV9vVY=; b=WBOOFHOCvXnafSIRvs2/3/s0m6 tlvGvuUEzHjMUXe6lnuZQWGOMLTMp9ne+lrdZh22d1w0ckc1frsb8+NxuVJ+YUQpAVBRoVgEjIFXR FXlnT+lYx1YVcll221o96++L48SkpRjX5RjkYLzonKlhatGdv/avnwGkoiJAmQc0Y7sg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=DV65+fK+aTlygf1u1TAw1mumFxNjza5Cu2q1OKV9vVY=; b=K4+p6ljwQVBuBMGQUfg0nejoK2 JEGiE97VzrPCUrUh8Px345P0xSVoVJwsvhbhPSAOhiHaCEWBwmsBOFM/KPQfzT8RM0eh4rTXX+F7W f8DyncO/oNZemYvHgXMxrZ8cwNuOxfWy5JurYtAvwXTgCL9K7VsqUjWVZEp1UPcu9lOI=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1w82y3-0000PL-3l for linux-f2fs-devel@lists.sourceforge.net; Wed, 01 Apr 2026 21:19:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 37583600CB; Wed, 1 Apr 2026 21:19:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92E56C4CEF7; Wed, 1 Apr 2026 21:19:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775078343; bh=ZUftJy/Eg2vooutQH6w/+XirdMYySx6JVlXp754Vgdk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jD3Jb1tyAXHJ7rlEQVgRfpLV2q36bVM+ZajV5KTZtkYLuqlKdfLGdjCpcy0YnRnbi LoLgBIqHi+42FatuccDnBFDivdoaKpF07bf+PUeofoud0KB0kILvHTwfnNr+wV1Aa6 ojA8OH7ghnBr07KKD5W+MJmxN0ig7il2HpVBOqc3Si1yz5HvBAiqiaYP7rfDfiQXz5 gvCbKx8DnrxuEsyb7EO6QrlJeDeTqifD0tfUem+skhvVcglnV+FvF/Xw4hsMFllqjZ y+d3meadPcE1/VqbKbjkdKbo9sj1+GwnPXFD2uG1NnYG5a8cUTLgXieYD+hkSeKO8n ECkQRhTDfjUOA== Date: Wed, 1 Apr 2026 14:19:01 -0700 To: Andrey Albershteyn Message-ID: <20260401211901.GF2466@quark> References: <20260331212827.2631020-1-aalbersh@kernel.org> <20260331212827.2631020-2-aalbersh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260331212827.2631020-2-aalbersh@kernel.org> X-Headers-End: 1w82y3-0000PL-3l Subject: Re: [f2fs-dev] [PATCH v6 01/22] fsverity: report validation errors through fserror to fsnotify X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eric Biggers via Linux-f2fs-devel Reply-To: Eric Biggers Cc: fsverity@lists.linux.dev, djwong@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, hch@lst.de, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Mar 31, 2026 at 11:28:02PM +0200, Andrey Albershteyn wrote: > Reported verification errors to fsnotify through recently added fserror > interface. > > Signed-off-by: Andrey Albershteyn > Reviewed-by: "Darrick J. Wong" > Reviewed-by: Christoph Hellwig > --- > fs/verity/verify.c | 4 ++++ > 1 file changed, 4 insertions(+) Acked-by: Eric Biggers > if (memchr_inv(dblock->data, 0, params->block_size)) { > + fserror_report_data_lost(inode, data_pos, > + params->block_size, GFP_NOFS); > fsverity_err(inode, > "FILE CORRUPTED! Data past EOF is not zeroed"); > return false; > @@ -312,6 +315,7 @@ static bool verify_data_block(struct fsverity_info *vi, > data_pos, level - 1, params->hash_alg->name, hsize, want_hash, > params->hash_alg->name, hsize, > level == 0 ? dblock->real_hash : real_hash); > + fserror_report_data_lost(inode, data_pos, params->block_size, GFP_NOFS); The first case does the fserror call first and the log message second, and the second case does them in the opposite order. I don't think it matters what the order is, but they should be consistent. - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel