From: "Piotr Piórkowski" <piotr.piorkowski@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH 10/13] drm/xe/pf: Reprovision scheduling to default when no VFs
Date: Thu, 2 Apr 2026 17:22:52 +0200 [thread overview]
Message-ID: <20260402152252.mpmp3vfcvqiqnfn2@intel.com> (raw)
In-Reply-To: <20260330204046.567-11-michal.wajdeczko@intel.com>
Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on pon [2026-mar-30 22:40:41 +0200]:
> Once we have disabled VFs there is no point in keeping potentially
> limited PF scheduling provisioning as we want to complete a cleanup
> of the VFs resources and return to the pure native mode, the same
> as before VFs were enabled, as soon as possible.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
> drivers/gpu/drm/xe/xe_pci_sriov.c | 2 ++
> drivers/gpu/drm/xe/xe_sriov_pf_provision.c | 39 ++++++++++++++++++++++
> drivers/gpu/drm/xe/xe_sriov_pf_provision.h | 1 +
> 3 files changed, 42 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_pci_sriov.c b/drivers/gpu/drm/xe/xe_pci_sriov.c
> index 3fd22034f03e..35e6b53e18ce 100644
> --- a/drivers/gpu/drm/xe/xe_pci_sriov.c
> +++ b/drivers/gpu/drm/xe/xe_pci_sriov.c
> @@ -191,6 +191,8 @@ static int pf_disable_vfs(struct xe_device *xe)
>
> pci_disable_sriov(pdev);
>
> + xe_sriov_pf_reprovision_default(xe);
> +
> pf_reset_vfs(xe, num_vfs);
>
> xe_sriov_pf_unprovision_vfs(xe, num_vfs);
> diff --git a/drivers/gpu/drm/xe/xe_sriov_pf_provision.c b/drivers/gpu/drm/xe/xe_sriov_pf_provision.c
> index abe3677d33ed..e11874d689fa 100644
> --- a/drivers/gpu/drm/xe/xe_sriov_pf_provision.c
> +++ b/drivers/gpu/drm/xe/xe_sriov_pf_provision.c
> @@ -103,6 +103,45 @@ int xe_sriov_pf_unprovision_vfs(struct xe_device *xe, unsigned int num_vfs)
> return 0;
> }
>
> +static int pf_reprovision_default(struct xe_device *xe)
> +{
> + struct xe_gt *gt;
> + unsigned int id;
> + int result = 0;
> + int err;
> +
> + guard(mutex)(xe_sriov_pf_master_mutex(xe));
> +
> + for_each_gt(gt, xe, id) {
> + err = xe_gt_sriov_pf_policy_set_sched_if_idle_locked(gt, false);
> + result = result ?: err;
> + err = xe_gt_sriov_pf_config_set_exec_quantum_locked(gt, PFID, 0);
> + result = result ?: err;
> + err = xe_gt_sriov_pf_config_set_preempt_timeout_locked(gt, PFID, 0);
> + result = result ?: err;
> + }
> +
> + return result;
> +}
> +
> +/**
> + * xe_sriov_pf_reprovision_default() - Reprovision default PF in auto-mode.
> + * @xe: the PF &xe_device
> + *
> + * This function can only be called on PF.
> + *
> + * Return: 0 on success or a negative error code on failure.
> + */
> +int xe_sriov_pf_reprovision_default(struct xe_device *xe)
> +{
> + xe_assert(xe, IS_SRIOV_PF(xe));
> +
> + if (!pf_auto_provisioning_mode(xe))
> + return 0;
> +
> + return pf_reprovision_default(xe);
> +}
> +
> /**
> * xe_sriov_pf_provision_set_mode() - Change VFs provision mode.
> * @xe: the PF &xe_device
> diff --git a/drivers/gpu/drm/xe/xe_sriov_pf_provision.h b/drivers/gpu/drm/xe/xe_sriov_pf_provision.h
> index f26f49539697..b15e4d7ad940 100644
> --- a/drivers/gpu/drm/xe/xe_sriov_pf_provision.h
> +++ b/drivers/gpu/drm/xe/xe_sriov_pf_provision.h
> @@ -30,6 +30,7 @@ int xe_sriov_pf_provision_query_vf_vram(struct xe_device *xe, unsigned int vfid,
>
> int xe_sriov_pf_provision_vfs(struct xe_device *xe, unsigned int num_vfs);
> int xe_sriov_pf_unprovision_vfs(struct xe_device *xe, unsigned int num_vfs);
> +int xe_sriov_pf_reprovision_default(struct xe_device *xe);
>
> int xe_sriov_pf_provision_set_mode(struct xe_device *xe, enum xe_sriov_provisioning_mode mode);
LGTM:
Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>
>
> --
> 2.47.1
>
--
next prev parent reply other threads:[~2026-04-02 15:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 20:40 [PATCH 00/13] drm/xe/pf: Improve EQ/PT provisioning Michal Wajdeczko
2026-03-30 20:40 ` [PATCH 01/13] drm/xe/guc: Update POLICY_SCHED_IF_IDLE documentation Michal Wajdeczko
2026-04-02 7:54 ` Piotr Piórkowski
2026-03-30 20:40 ` [PATCH 02/13] drm/xe/pf: Fix pf_get_sched_priority() function signature Michal Wajdeczko
2026-04-02 7:55 ` Piotr Piórkowski
2026-03-30 20:40 ` [PATCH 03/13] drm/xe/pf: Force new VFs prorities only once Michal Wajdeczko
2026-04-02 10:22 ` Piotr Piórkowski
2026-04-02 16:13 ` Michal Wajdeczko
2026-03-30 20:40 ` [PATCH 04/13] drm/xe/pf: Print applied policy KLVs Michal Wajdeczko
2026-04-02 10:56 ` Piotr Piórkowski
2026-03-30 20:40 ` [PATCH 05/13] drm/xe/pf: Reprovision policy settings after GT reset Michal Wajdeczko
2026-04-02 11:23 ` Piotr Piórkowski
2026-03-30 20:40 ` [PATCH 06/13] drm/xe/pf: Don't reprovision policies if already default Michal Wajdeczko
2026-04-02 11:23 ` Piotr Piórkowski
2026-03-30 20:40 ` [PATCH 07/13] drm/xe/pf: Encode scheduling priority KLV if needed Michal Wajdeczko
2026-04-02 13:18 ` Piotr Piórkowski
2026-03-30 20:40 ` [PATCH 08/13] drm/xe/pf: Check EQ/PT/PRIO when testing VF config Michal Wajdeczko
2026-04-02 13:30 ` Piotr Piórkowski
2026-03-30 20:40 ` [PATCH 09/13] drm/xe/pf: Allow to change sched_if_idle policy under lock Michal Wajdeczko
2026-04-02 13:33 ` Piotr Piórkowski
2026-03-30 20:40 ` [PATCH 10/13] drm/xe/pf: Reprovision scheduling to default when no VFs Michal Wajdeczko
2026-04-02 15:22 ` Piotr Piórkowski [this message]
2026-03-30 20:40 ` [PATCH 11/13] drm/xe/pf: Extract helper to show which VFs are provisioned Michal Wajdeczko
2026-04-02 15:40 ` Piotr Piórkowski
2026-03-30 20:40 ` [PATCH 12/13] drm/xe/pf: Extract helpers for bulk EQ/PT provisioning Michal Wajdeczko
2026-04-02 15:57 ` Piotr Piórkowski
2026-03-30 20:40 ` [PATCH 13/13] drm/xe/pf: Perform fair scheduling auto-provisioning Michal Wajdeczko
2026-04-02 16:06 ` Piotr Piórkowski
2026-03-30 21:09 ` ✓ CI.KUnit: success for drm/xe/pf: Improve EQ/PT provisioning Patchwork
2026-03-30 21:41 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-31 0:28 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-04-02 16:20 ` Michal Wajdeczko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260402152252.mpmp3vfcvqiqnfn2@intel.com \
--to=piotr.piorkowski@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.