From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com
Subject: drivers/gpu/drm/bridge/inno-hdmi.c:833:21: sparse: sparse: unsigned value that used to be signed checked against zero?
Date: Fri, 03 Apr 2026 16:41:04 +0800 [thread overview]
Message-ID: <202604022112.HuUam6IX-lkp@intel.com> (raw)
::::::
:::::: Manual check reason: "low confidence static check warning: drivers/gpu/drm/bridge/inno-hdmi.c:833:21: sparse: sparse: unsigned value that used to be signed checked against zero?"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Andy Yan <andy.yan@rock-chips.com>
CC: Dmitry Baryshkov <lumag@kernel.org>
CC: Heiko Stuebner <heiko@sntech.de>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 9147566d801602c9e7fc7f85e989735735bf38ba
commit: 969325a2597ebc4cb001a92992f06f698ab2b467 drm/rockchip: inno-hdmi: Convert to drm bridge
date: 3 months ago
:::::: branch date: 2 days ago
:::::: commit date: 3 months ago
config: sparc64-randconfig-r131-20260402 (https://download.01.org/0day-ci/archive/20260402/202604022112.HuUam6IX-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 11.5.0
sparse: v0.6.5-rc1
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260402/202604022112.HuUam6IX-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 969325a2597e ("drm/rockchip: inno-hdmi: Convert to drm bridge")
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202604022112.HuUam6IX-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/bridge/inno-hdmi.c:833:21: sparse: sparse: unsigned value that used to be signed checked against zero?
drivers/gpu/drm/bridge/inno-hdmi.c:818:35: sparse: signed value source
vim +833 drivers/gpu/drm/bridge/inno-hdmi.c
412d4ae6b7a508 drivers/gpu/drm/rockchip/inno_hdmi.c Yakir Yang 2016-02-03 805
969325a2597ebc drivers/gpu/drm/bridge/inno-hdmi.c Andy Yan 2025-10-16 806 static enum drm_mode_status inno_hdmi_bridge_mode_valid(struct drm_bridge *bridge,
969325a2597ebc drivers/gpu/drm/bridge/inno-hdmi.c Andy Yan 2025-10-16 807 const struct drm_display_info *info,
26d6fd81916e62 drivers/gpu/drm/rockchip/inno_hdmi.c Dmitry Baryshkov 2024-12-14 808 const struct drm_display_mode *mode)
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 809 {
969325a2597ebc drivers/gpu/drm/bridge/inno-hdmi.c Andy Yan 2025-10-16 810 struct inno_hdmi *hdmi = bridge_to_inno_hdmi(bridge);
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 811 unsigned long mpixelclk, max_tolerance;
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 812 long rounded_refclk;
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 813
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 814 /* No support for double-clock modes */
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 815 if (mode->flags & DRM_MODE_FLAG_DBLCLK)
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 816 return MODE_BAD;
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 817
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 818 mpixelclk = mode->clock * 1000;
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 819
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 820 if (mpixelclk < INNO_HDMI_MIN_TMDS_CLOCK)
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 821 return MODE_CLOCK_LOW;
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 822
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 823 if (inno_hdmi_find_phy_config(hdmi, mpixelclk) < 0)
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 824 return MODE_CLOCK_HIGH;
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 825
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 826 if (hdmi->refclk) {
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 827 rounded_refclk = clk_round_rate(hdmi->refclk, mpixelclk);
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 828 if (rounded_refclk < 0)
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 829 return MODE_BAD;
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 830
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 831 /* Vesa DMT standard mentions +/- 0.5% max tolerance */
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 832 max_tolerance = mpixelclk / 200;
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 @833 if (abs_diff((unsigned long)rounded_refclk, mpixelclk) > max_tolerance)
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 834 return MODE_NOCLOCK;
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 835 }
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 836
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 837 return MODE_OK;
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 838 }
701029621d4141 drivers/gpu/drm/rockchip/inno_hdmi.c Alex Bee 2023-12-22 839
:::::: The code at line 833 was first introduced by commit
:::::: 701029621d4141d0c9f8b81a88a37b95ec84ce65 drm/rockchip: inno_hdmi: Add basic mode validation
:::::: TO: Alex Bee <knaerzche@gmail.com>
:::::: CC: Heiko Stuebner <heiko@sntech.de>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2026-04-03 8:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 8:41 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-02 12:11 drivers/gpu/drm/bridge/inno-hdmi.c:833:21: sparse: sparse: unsigned value that used to be signed checked against zero? kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202604022112.HuUam6IX-lkp@intel.com \
--to=lkp@intel.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.