All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Georg Klima <Georg.Klima@durst-group.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Georg Klima <georg_klima@gmx.at>, Lukas Wunner <lukas@wunner.de>,
	Andreas Noever <andreas.noever@gmail.com>,
	Mika Westerberg <westeri@kernel.org>,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	linux-usb@vger.kernel.org
Subject: Re: AW: [BUG] Thunderbolt runtime resume during PCIe removal causes IRQ warning and shutdown failure.
Date: Thu, 2 Apr 2026 17:20:55 -0500	[thread overview]
Message-ID: <20260402222055.GA293966@bhelgaas> (raw)
In-Reply-To: <AM9PR10MB4231D6536D271E1F5A81F3D1B757A@AM9PR10MB4231.EURPRD10.PROD.OUTLOOK.COM>

[+cc Thunderbolt & pciehp folks, initial report of system poweroff
failure at
https://lore.kernel.org/all/AM9PR10MB42316BF3E59B29E1EA3E5600B756A@AM9PR10MB4231.EURPRD10.PROD.OUTLOOK.COM]

On Fri, Mar 27, 2026 at 05:28:28PM +0000, Georg Klima wrote:
> Hi Bjorn,
> 
> Upstream without nvidia, more debug, same issue with aspm default:

Thanks for this test with an upstream kernel (6.19.10).  Complete
dmesg log was attached to
https://lore.kernel.org/all/AM9PR10MB4231D6536D271E1F5A81F3D1B757A@AM9PR10MB4231.EURPRD10.PROD.OUTLOOK.COM/

Linux only requests control of PME, AER, hotplug, etc if Linux
supports ASPM and MSI.  "pcie_aspm=off" means Linux doesn't support
ASPM, so it doesn't request control:

  --- dmesg_aspm_off.txt
  +++ dmesg_actual.txt
  - acpi PNP0A08:01: _OSC: OS supports [ExtendedConfig Segments MSI EDR HPX-Type3]
  + acpi PNP0A08:01: _OSC: OS supports [ExtendedConfig ASPM ClockPM Segments MSI EDR HPX-Type3]
  - acpi PNP0A08:01: _OSC: not requesting OS control; OS requires [ExtendedConfig ASPM ClockPM MSI]
  + acpi PNP0A08:01: _OSC: OS now controls [PCIeHotplug SHPCHotplug PME AER PCIeCapability LTR DPC]

I suspect the issue is related to those services, not to ASPM itself.
Booting with "pcie_port_pm=off" might be a more targeted workaround.

You have this topology:

  0000:80:1b.4: [8086:7f44] PCIe Root Port to [bus 88-d8]
  0000:88:00.0: [8086:5780] PCIe Switch Upstream Port (JHL9580 Thunderbolt 5)

and the first thing I see in the 6.19.10 log is this, which makes me
think we put the Thunderbolt controller at 88:00.0 into D3 and are
trying to bring it back to D0 but it took too long, so we can't access
downstream devices like b1:00.0:

  Mar 27 18:08:40 fedora kernel: pcieport 0000:80:1b.4: Data Link Layer Link Active not set in 100 msec
  Mar 27 18:08:40 fedora kernel: pcieport 0000:80:1b.4: pciehp: Slot(25): Card not present
  Mar 27 18:08:40 fedora kernel: xhci_hcd 0000:b1:00.0: Controller not ready at resume -19
  Mar 27 18:08:40 fedora kernel: ------------[ cut here ]------------
  Mar 27 18:08:40 fedora kernel: xhci_hcd 0000:b1:00.0: PCI post-resume error -19!
  Mar 27 18:08:40 fedora kernel: thunderbolt 0000:8a:00.0: interrupt for TX ring 0 is already enabled
  Mar 27 18:08:40 fedora kernel:  tb_ring_start+0x149/0x330 [thunderbolt]
  Mar 27 18:08:40 fedora kernel:  tb_ctl_start+0x1b/0xc0 [thunderbolt]
  Mar 27 18:08:40 fedora kernel:  tb_domain_runtime_resume+0x19/0x40 [thunderbolt]
  Mar 27 18:08:40 fedora kernel:  __rpm_callback+0x48/0x1f0
  Mar 27 18:08:40 fedora kernel:  rpm_callback+0x6d/0x80
  Mar 27 18:08:40 fedora kernel:  rpm_resume+0x4ab/0x6d0

  reply	other threads:[~2026-04-02 22:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26 16:09 [BUG] Thunderbolt runtime resume during PCIe removal causes IRQ warning and shutdown failure Georg Klima
2026-03-26 17:57 ` Bjorn Helgaas
2026-03-27  7:01   ` AW: " Georg Klima
2026-03-27 17:28     ` Georg Klima
2026-04-02 22:20       ` Bjorn Helgaas [this message]
2026-04-05  8:59 ` Lukas Wunner
2026-04-07  5:41   ` Mika Westerberg
2026-04-10  5:20     ` AW: " Georg Klima
2026-04-10  5:46       ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260402222055.GA293966@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=Georg.Klima@durst-group.com \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=georg_klima@gmx.at \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=westeri@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.