All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xin Wang <x.wang@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Xin Wang <x.wang@intel.com>
Subject: [PATCH v2 0/4] lib/xe: query engine class capabilities from debugfs info
Date: Fri,  3 Apr 2026 00:13:18 -0700	[thread overview]
Message-ID: <20260403071322.366766-1-x.wang@intel.com> (raw)

The xe kernel driver recently started exposing engine class capability
bitmasks in the debugfs "info" node:

  multi_lrc_engine_classes vcs vecs
  gt0 multi_queue_engine_classes bcs ccs

These entries were introduced by the following KMD series:
  https://patchwork.freedesktop.org/series/163802/
  - drm/xe: improve readability of debugfs engine info output
  - drm/xe: expose multi-lrc engine classes in debugfs info

This series wires up IGT to consume these debugfs entries:

Patch 1 adds two bitmask fields to struct xe_device (multi_lrc_mask and
multi_queue_engine_class_mask) and populates them in xe_device_get() by
reading the debugfs "info" file line-by-line.  UINT16_MAX is used as a
sentinel meaning "not available" so that older kernels that do not expose
these entries continue to work via the existing hardcoded fallbacks.

Patch 2 implements xe_engine_class_supports_multi_lrc(fd, engine_class).
When the kernel-reported bitmask is available it is used directly; otherwise
the function falls back to returning true only for VIDEO_DECODE and
VIDEO_ENHANCE, matching the previous hardcoded behaviour.

Patch 3 refactors xe_engine_class_supports_multi_queue() in the same way,
adding an fd parameter so it can consult the kernel-reported bitmask.  All
callers (direct calls in xe_exec_threads.c and macro users in
xe_exec_multi_queue.c) are updated accordingly.  Note that
xe_for_each_multi_queue_engine_class() gains a mandatory fd parameter as
part of this change.

Patch 4 guards the balancer and multi-LRC codepaths in xe_exec_balancer,
xe_exec_reset, xe_exec_threads and xe_drm_fdinfo with
xe_engine_class_supports_multi_lrc() so that tests are skipped rather than
failing on engine classes whose hardware does not support multi-LRC
submission.  It also ensures the parallel-queue rejection check in
xe_exec_multi_queue __test_sanity() is only exercised for engine classes
that support multi-LRC.

v2:
  - Merged previous xe_exec_multi_queue expected-error fix into patch 4 two
    patches share the same logical motivation.
  - xe_exec_multi_queue: use `if (n > 1 && xe_engine_class_supports_multi_lrc())`
    instead of a ternary to select the error code (Niranjana)

Xin Wang (4):
  lib/xe: cache engine class masks from debugfs info
  lib/xe: add xe_engine_class_supports_multi_lrc()
  lib/xe: use debugfs info to implement
    xe_engine_class_supports_multi_queue()
  tests/intel: skip or adjust tests for non-multi-LRC engine classes

 lib/xe/xe_query.c                 | 156 +++++++++++++++++++++++++++---
 lib/xe/xe_query.h                 |  21 +++-
 tests/intel/xe_drm_fdinfo.c       |   2 +-
 tests/intel/xe_exec_balancer.c    |   6 +-
 tests/intel/xe_exec_multi_queue.c |   6 +-
 tests/intel/xe_exec_reset.c       |   2 +-
 tests/intel/xe_exec_threads.c     |   5 +-
 7 files changed, 168 insertions(+), 30 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-04-03  7:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-03  7:13 Xin Wang [this message]
2026-04-03  7:13 ` [PATCH v2 1/4] lib/xe: cache engine class masks from debugfs info Xin Wang
2026-04-06 22:25   ` [v2,1/4] " Daniel Charles
2026-04-03  7:13 ` [PATCH v2 2/4] lib/xe: add xe_engine_class_supports_multi_lrc() Xin Wang
2026-04-06 22:32   ` [v2,2/4] " Daniel Charles
2026-04-03  7:13 ` [PATCH v2 3/4] lib/xe: use debugfs info to implement xe_engine_class_supports_multi_queue() Xin Wang
2026-04-06 22:34   ` [v2,3/4] " Daniel Charles
2026-04-03  7:13 ` [PATCH v2 4/4] tests/intel: skip or adjust tests for non-multi-LRC engine classes Xin Wang
2026-04-06 22:35   ` [v2,4/4] " Daniel Charles
2026-04-03  8:03 ` ✓ i915.CI.BAT: success for lib/xe: query engine class capabilities from debugfs info (rev2) Patchwork
2026-04-03  8:06 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-03 13:37 ` ✓ Xe.CI.FULL: " Patchwork
2026-04-03 23:35 ` ✗ i915.CI.Full: failure " Patchwork
2026-04-08  2:15   ` Wang, X

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260403071322.366766-1-x.wang@intel.com \
    --to=x.wang@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.