From: Christoph Hellwig <hch@lst.de>
To: Shivaji Kant <shivajikant@google.com>
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org,
Pranjal Shrivastava <praan@google.com>
Subject: Re: [RFC PATCH v2] nvme: enable PCI P2PDMA support for RDMA transport
Date: Mon, 6 Apr 2026 07:41:20 +0200 [thread overview]
Message-ID: <20260406054120.GA16443@lst.de> (raw)
In-Reply-To: <20260402073001.2039625-1-shivajikant@google.com>
On Thu, Apr 02, 2026 at 07:30:01AM +0000, Shivaji Kant wrote:
> Enable BLK_FEAT_PCI_P2PDMA on the NVMe when the underlying
> RDMA controller supports it.
You can use up to 73 characters per line.
>
> This patch depends on the PCI P2PDMA support added in this
> patch [1].
I don't think it actually does. To support multi-path capable RDMA
controllers, and those the vast majority, you need the multipath
support. But for non-multipath capable controllers your patch
just works. So I'd suggest to drop this paragraph and reference
from the commit log.
Otherwise looks good.
next prev parent reply other threads:[~2026-04-06 5:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 7:30 [RFC PATCH v2] nvme: enable PCI P2PDMA support for RDMA transport Shivaji Kant
2026-04-02 16:03 ` Pranjal Shrivastava
2026-04-04 5:16 ` Shivaji Kant
2026-04-06 5:41 ` Christoph Hellwig [this message]
[not found] ` <azabfvzjn4juc77xdq6qhszd6py6hkb35jgi2xymplpnkj5ra4@vpjpaoeenvlu>
2026-04-06 9:15 ` Shivaji Kant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260406054120.GA16443@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=praan@google.com \
--cc=sagi@grimberg.me \
--cc=shivajikant@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.