All of lore.kernel.org
 help / color / mirror / Atom feed
From: Caleb Ethridge <jcethrid@gmail.com>
To: malysagreg@gmail.com
Cc: caleb.ethridge@analog.com, jcethrid@gmail.com, linux@analog.com,
	ozan.durgut@analog.com, philip@philipmolloy.com,
	trini@konsulko.com, u-boot@lists.denx.de
Subject: Re: [RESEND v2 12/13] arm: sc5xx: remove LOADADDR and use kernel_addr_r
Date: Mon,  6 Apr 2026 09:32:52 -0400	[thread overview]
Message-ID: <20260406133252.4709-1-jcethrid@gmail.com> (raw)
In-Reply-To: <CABdDSeVpWbu+hadgWJVWaeU7=4xKuvpitbRU+ScP2Za=3dbP5A@mail.gmail.com>

Hi Greg, 

> I agree with dropping SC5XX_LOADADDRR and replacing with
> CONFIG_SYS_LOAD_ADDR . But should we really replace ${loadaddr} with
> ${kernel_addr_r}? We're loading/booting a fit image not a raw kernel.
> bootm defaults to CONFIG_SYS_LOAD_ADDR which is exported as loadaddr
> in include/env_default.h.

We have recently opened up our support to include build systems which
produce a kernel image + dtb combo instead of the full fit image. It 
probably makes sense then to leave the kernel_addr_r define in for use
with booti if needed, but remove the kernel_addr_r from the bootm commands since
they are redundant.

I will let Ozan chime in as well, as this was originally his commit that
I attached to my original series.

Thanks,

Caleb

  reply	other threads:[~2026-04-06 16:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02 15:28 [RESEND v2 00/13] sc5xx Environment Cleanup and Fixes Caleb Ethridge
2026-04-02 15:28 ` [RESEND v2 01/13] configs: sc5xx: Do not store environment in SPI flash Caleb Ethridge
2026-04-02 15:28 ` [RESEND v2 02/13] mach-sc5xx: Remove update commands from default environment Caleb Ethridge
2026-04-02 15:28 ` [RESEND v2 03/13] mach-sc5xx: Update boot commands Caleb Ethridge
2026-04-02 15:28 ` [RESEND v2 04/13] mach-sc5xx: Switch from tftp to wget Caleb Ethridge
2026-04-02 15:28 ` [RESEND v2 05/13] mach-sc5xx: Add USB boot command Caleb Ethridge
2026-04-02 15:28 ` [RESEND v2 06/13] mach-sc5xx: Remove preliminary binman support Caleb Ethridge
2026-04-02 15:28 ` [RESEND v2 07/13] dts: sc594: Fix gige-reset line on EZKIT Caleb Ethridge
2026-04-02 15:28 ` [RESEND v2 08/13] mach-sc5xx: sc573: Rename EZKIT board to EZLITE Caleb Ethridge
2026-04-02 15:28 ` [RESEND v2 09/13] mach-sc5xx: Update image load address Caleb Ethridge
2026-04-02 15:28 ` [RESEND v2 10/13] mach-sc5xx: Update SPI bootargs for ubifs Caleb Ethridge
2026-04-02 15:28 ` [RESEND v2 11/13] configs: sc5xx: Set default bootcmd to SPI boot Caleb Ethridge
2026-04-02 15:28 ` [RESEND v2 12/13] arm: sc5xx: remove LOADADDR and use kernel_addr_r Caleb Ethridge
2026-04-06  2:22   ` Greg Malysa
2026-04-06 13:32     ` Caleb Ethridge [this message]
2026-04-06 17:48       ` Greg Malysa
2026-04-02 15:28 ` [RESEND v2 13/13] arm: sc5xx: add missing boot env selectors Caleb Ethridge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260406133252.4709-1-jcethrid@gmail.com \
    --to=jcethrid@gmail.com \
    --cc=caleb.ethridge@analog.com \
    --cc=linux@analog.com \
    --cc=malysagreg@gmail.com \
    --cc=ozan.durgut@analog.com \
    --cc=philip@philipmolloy.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.