From: Al Viro <viro@zeniv.linux.org.uk>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: brauner@kernel.org, jack@suse.cz, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: hide file and bfile caches behind runtime const machinery
Date: Mon, 6 Apr 2026 22:16:50 +0100 [thread overview]
Message-ID: <20260406211650.GD3836593@ZenIV> (raw)
In-Reply-To: <20260328173728.3388070-1-mjguzik@gmail.com>
On Sat, Mar 28, 2026 at 06:37:28PM +0100, Mateusz Guzik wrote:
> -static struct kmem_cache *filp_cachep __ro_after_init;
> -static struct kmem_cache *bfilp_cachep __ro_after_init;
> +static struct kmem_cache *__filp_cache __ro_after_init;
> +#define filp_cache runtime_const_ptr(__filp_cache)
> +static struct kmem_cache *__bfilp_cache __ro_after_init;
> +#define bfilp_cache runtime_const_ptr(__bfilp_cache)
IMO the entire runtime_const_ptr thing for caches is wrong;
statically allocated kmem_cache series got stalled, but I'm
bringing it back next cycle and this stuff is going to get
reverted as part of that.
next prev parent reply other threads:[~2026-04-06 21:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-28 17:37 [PATCH] fs: hide file and bfile caches behind runtime const machinery Mateusz Guzik
2026-03-30 8:47 ` Jan Kara
2026-03-31 9:44 ` Christian Brauner
2026-04-06 21:16 ` Al Viro [this message]
2026-04-06 21:45 ` Mateusz Guzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260406211650.GD3836593@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.