From: Christoph Hellwig <hch@lst.de>
To: Geliang Tang <geliang@kernel.org>
Cc: Justin Tee <justin.tee@broadcom.com>,
Naresh Gottumukkala <nareshgottumukkala83@gmail.com>,
Paul Ely <paul.ely@broadcom.com>, Keith Busch <kbusch@kernel.org>,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>,
Geliang Tang <tanggeliang@kylinos.cn>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: add missing MODULE_ALIAS for fabrics transports
Date: Wed, 8 Apr 2026 08:10:28 +0200 [thread overview]
Message-ID: <20260408061028.GA24559@lst.de> (raw)
In-Reply-To: <e3076c80ee2e0c4a2cae0374afb617a3365946ea.1774944415.git.tanggeliang@kylinos.cn>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
> Recently, I've been working on adding MPTCP support for NVMe over TCP, so
> I added a new transport called "nvme-mptcp". The AI review in [1] reminded
> me that I should add MODULE_ALIAS("nvme-mptcp"). Then I checked the other
> transports and found that they were all missing the MODULE_ALIAS as well.
> I felt it was necessary to add them, so I sent this patch.
As a reminder: if you want that to go anywhere you need to engage with
the nvme technical working group, which requires a nvme membership
first. There will be no point in posting or even discussing this on
Linux mailing lists if it isn't approved by nvme.
next prev parent reply other threads:[~2026-04-08 6:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 8:17 [PATCH] nvme: add missing MODULE_ALIAS for fabrics transports Geliang Tang
2026-04-08 6:10 ` Christoph Hellwig [this message]
2026-04-10 6:20 ` Geliang Tang
2026-04-08 15:12 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260408061028.GA24559@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=geliang@kernel.org \
--cc=hare@suse.de \
--cc=justin.tee@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nareshgottumukkala83@gmail.com \
--cc=paul.ely@broadcom.com \
--cc=sagi@grimberg.me \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.