From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9337833B95C for ; Wed, 8 Apr 2026 06:11:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775628711; cv=none; b=antuUuSDa1Qh6n3Pz44ktmiyTUbzL7g4sO7frjOUJMTHR6ObN7cRUFAN1GpGxS5M5LGYWlfuddVwKchwKZuu4lJj37Y9kcQwvkN+lND7xsmUJYOG6NXMDZgqfKoaG/p6n5uRSyTJWbsitfY+kEzI0rMer48Kw+JpMS/kTGXmIWg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775628711; c=relaxed/simple; bh=PE/7KOQTUUI4eFe1WC1G6sJrqh0+D5Qk7KgGxUkU91A=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sDsYyVXZB2tPJHnId+qTHCK9gDC6GpjJwRJJSKUNXT8EPTbgcEpJ73xhFRDqzGlQJdBXHZ0MlFibrpfuXWrJEbTtRwB58PrCs+pDra8lEwPt0rLyrp2gAqcT3RYBJrGFeGEtQWFrx4fKyLKVoHpuc63SoFlEVCw9aIQ5MG6QBpQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-43cfb723698so5009252f8f.3 for ; Tue, 07 Apr 2026 23:11:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775628708; x=1776233508; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+aQ7qZB62vw22URUg0yl7/bcBDdLQ6KVExRcwvTyWNM=; b=GisejcwQhTLO/MTdC1Qu+mASFGILK2/OLhp09xqRS9J5/RUgakKdYOJXnUe3T6qtyd k2bz2Krwu3n2r3VsVYpFpxW22ScgZfyMb3anC+rgoAXTyvFW2ktRpfYygUA3twloZ6Ha HSwufKgNdbhLCiOWNTKsX8lxxwBiNfbduE7slS4tYZyK8mS8kjUz+tRA0ws4+PajzyjB JyC+n3K6qFJkiu8G27i05I4WVv6JIh+mZk6hH87NZXpRFOWGPBdNRudCH8MCZqUwuRpf /VCojTzigwzcP0MBGMX1t1PduXrrhjkUMI5VH+FbrO8fNsXP624AOx5x4eRv1KZU915/ FkOg== X-Gm-Message-State: AOJu0YwJZOOEESmf3v9l+raHBKbM/5XmAEPDGmIQvGsdDZ6xMTan5HIU phkD989cs6zBcsg0CQrFEfcQ9/VazoOjhndJAmG3avah+T389bb23reiVrC2DFt6/xA= X-Gm-Gg: AeBDiev7kmInaq+N0LynG3YmJkxCkWiAZJdHfxmFiHwhT0bptBUXPS9JYgEu22BT9fw zbVFtz3E8l1sIEaEmy9aVWTVbDeKd66pOICkUZIPx/OPhhe5B+3iZUS1CJIrUG2kHJ04RVf2CBH 4gx3JoHobd0gE8g7OksdDqOk06902MikDE71kytMItJKT9uthB80PZdKVytD1VzlUW2zX1xMyoh 3U/KkAfoeNOYhnIn6RgEI4+0gMS++9rk7IDD4bSgCzujINI57Ihfu5/o2F17SNScM8b+eS2Wm9X A3c98iSkZlMnu2eyjqKOriE9zzgTZkYt8KpgKyCGDudFHj0larzg+A6FhAUSyVSNmTNCS8QBbDb Axcq0mfIuXa5Tcn1pZtmWluwujFd214m3D3/VQrhpBgjIUPy9ETCm/i2A3CHI09LgR8kB5+T638 kea9EDuF/2Q/BlJAVkX48vk5mEsWddfLSuBRfHjq0j49iWsph2NYRpJA== X-Received: by 2002:a05:6000:400a:b0:43d:4c:229f with SMTP id ffacd0b85a97d-43d292e27admr28657828f8f.44.1775628707632; Tue, 07 Apr 2026 23:11:47 -0700 (PDT) Received: from hackbase (95-24-76-124.broadband.corbina.ru. [95.24.76.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e4f843dsm53745270f8f.37.2026.04.07.23.11.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 23:11:47 -0700 (PDT) From: Alexander Popov To: stable@vger.kernel.org, Greg KH , Johannes Berg , Johannes Berg , Breno Leitao , Alexander Popov Subject: [PATCH] wifi: virt_wifi: remove SET_NETDEV_DEV to avoid use-after-free Date: Wed, 8 Apr 2026 09:10:52 +0300 Message-ID: <20260408061057.30531-1-alex.popov@linux.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026040715-good-overture-8018@gregkh> References: <2026040715-good-overture-8018@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently we execute `SET_NETDEV_DEV(dev, &priv->lowerdev->dev)` for the virt_wifi net devices. However, unregistering a virt_wifi device in netdev_run_todo() can happen together with the device referenced by SET_NETDEV_DEV(). It can result in use-after-free during the ethtool operations performed on a virt_wifi device that is currently being unregistered. Such a net device can have the `dev.parent` field pointing to the freed memory, but ethnl_ops_begin() calls `pm_runtime_get_sync(dev->dev.parent)`. Let's remove SET_NETDEV_DEV for virt_wifi to avoid bugs like this: ================================================================== BUG: KASAN: slab-use-after-free in __pm_runtime_resume+0xe2/0xf0 Read of size 2 at addr ffff88810cfc46f8 by task pm/606 Call Trace: dump_stack_lvl+0x4d/0x70 print_report+0x170/0x4f3 ? __pfx__raw_spin_lock_irqsave+0x10/0x10 kasan_report+0xda/0x110 ? __pm_runtime_resume+0xe2/0xf0 ? __pm_runtime_resume+0xe2/0xf0 __pm_runtime_resume+0xe2/0xf0 ethnl_ops_begin+0x49/0x270 ethnl_set_features+0x23c/0xab0 ? __pfx_ethnl_set_features+0x10/0x10 ? kvm_sched_clock_read+0x11/0x20 ? local_clock_noinstr+0xf/0xf0 ? local_clock+0x10/0x30 ? kasan_save_track+0x25/0x60 ? __kasan_kmalloc+0x7f/0x90 ? genl_family_rcv_msg_attrs_parse.isra.0+0x150/0x2c0 genl_family_rcv_msg_doit+0x1e7/0x2c0 ? __pfx_genl_family_rcv_msg_doit+0x10/0x10 ? __pfx_cred_has_capability.isra.0+0x10/0x10 ? stack_trace_save+0x8e/0xc0 genl_rcv_msg+0x411/0x660 ? __pfx_genl_rcv_msg+0x10/0x10 ? __pfx_ethnl_set_features+0x10/0x10 netlink_rcv_skb+0x121/0x380 ? __pfx_genl_rcv_msg+0x10/0x10 ? __pfx_netlink_rcv_skb+0x10/0x10 ? __pfx_down_read+0x10/0x10 genl_rcv+0x23/0x30 netlink_unicast+0x60f/0x830 ? __pfx_netlink_unicast+0x10/0x10 ? __pfx___alloc_skb+0x10/0x10 netlink_sendmsg+0x6ea/0xbc0 ? __pfx_netlink_sendmsg+0x10/0x10 ? __futex_queue+0x10b/0x1f0 ____sys_sendmsg+0x7a2/0x950 ? copy_msghdr_from_user+0x26b/0x430 ? __pfx_____sys_sendmsg+0x10/0x10 ? __pfx_copy_msghdr_from_user+0x10/0x10 ___sys_sendmsg+0xf8/0x180 ? __pfx____sys_sendmsg+0x10/0x10 ? __pfx_futex_wait+0x10/0x10 ? fdget+0x2e4/0x4a0 __sys_sendmsg+0x11f/0x1c0 ? __pfx___sys_sendmsg+0x10/0x10 do_syscall_64+0xe2/0x570 ? exc_page_fault+0x66/0xb0 entry_SYSCALL_64_after_hwframe+0x77/0x7f This fix may be combined with another one in the ethtool subsystem: https://lore.kernel.org/all/20260322075917.254874-1-alex.popov@linux.com/T/#u Fixes: d43c65b05b848e0b ("ethtool: runtime-resume netdev parent in ethnl_ops_begin") Cc: stable@vger.kernel.org Signed-off-by: Alexander Popov Acked-by: Greg Kroah-Hartman Reviewed-by: Breno Leitao Link: https://patch.msgid.link/20260324224607.374327-1-alex.popov@linux.com Signed-off-by: Johannes Berg (cherry picked from commit 789b06f9f39cdc7e895bdab2c034e39c41c8f8d6) --- drivers/net/wireless/virtual/virt_wifi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/virtual/virt_wifi.c b/drivers/net/wireless/virtual/virt_wifi.c index 4eae89376feb..cd6b66242bff 100644 --- a/drivers/net/wireless/virtual/virt_wifi.c +++ b/drivers/net/wireless/virtual/virt_wifi.c @@ -557,7 +557,6 @@ static int virt_wifi_newlink(struct net_device *dev, eth_hw_addr_inherit(dev, priv->lowerdev); netif_stacked_transfer_operstate(priv->lowerdev, dev); - SET_NETDEV_DEV(dev, &priv->lowerdev->dev); dev->ieee80211_ptr = kzalloc(sizeof(*dev->ieee80211_ptr), GFP_KERNEL); if (!dev->ieee80211_ptr) { -- 2.53.0