From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A405210FC441 for ; Wed, 8 Apr 2026 21:14:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ATN+RfwG5zGYHghfAiux3U74SHsIwC6CnyZT3oLFglg=; b=LuqbjzSLL1eOrf qoemya4InsZeR6BWZREbOe3OhAKueDFc+3XimOFejjWz07J1Fys2BwtmaTkqjvhDZabiMGXzHRCyA OYWwFSnRsLMhX2anqv9qdSiYeeJqf8NaLLXW2YKjjbSkioeKxsXk75qeelvjrwQzYU4GJNhn4HMTN OVBh7SM3Ci+rt4hyG6L5bKSHwk89HMAQ1xI5De7Oq5Y9e869ywmt0100sJ93wD4xRPOwR3vWJ5cyo d/9FJd9Lv51zEko0kyeKVdCEQCDF4doRytd85utYiq5PZF0Ixb4SBVPIHqO9qv5mkdwokYiM4hwIi 7DGNfskuKkIsTx2vG3aQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wAaEB-00000009QIo-0qHN; Wed, 08 Apr 2026 21:14:23 +0000 Received: from mgamail.intel.com ([198.175.65.19]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wAaE8-00000009QIM-051F for linux-mtd@lists.infradead.org; Wed, 08 Apr 2026 21:14:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775682860; x=1807218860; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=9ANUT8QdPo5iyQxCYTvuSXlBIUzBWrhApFgNzvDSbLM=; b=UF2kW1O4ILHP7CMx/lQ2gYrjuuxplBQAg+w7C/AiPdOAFAh6hnorzuhm oHvcyjhV8Ws8ZcyKKEPbfGQSbM9I5tUU96Ro782SKAuqXgeSvyPOznPgn xLB0D9M9a0zWzBfp38A3pMKEFbJoS5JHAHG4whRki428ePUwaDeqvJrsM c0lJLVKBlLbc7W8kGJn8aZu6XYMSJmXixE+Ui8MLcWWvO1bwoH7FYgkF4 huwSCNe5Ov2o7x3uqzVVKqHHqYW4Ux0I8RQ0dgbi19e+AdiiL1jgFIjhP F9WPlBVaUZMrTnFp4LaV9YfYZitSjJzj2e4RLwx3qLMLuIi4v5V+PUkW0 A==; X-CSE-ConnectionGUID: GhlSiwPfRk6iPm7/fOYCOg== X-CSE-MsgGUID: nD0IlihaQVydbeMupyIoFA== X-IronPort-AV: E=McAfee;i="6800,10657,11753"; a="76583112" X-IronPort-AV: E=Sophos;i="6.23,168,1770624000"; d="scan'208";a="76583112" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2026 14:14:17 -0700 X-CSE-ConnectionGUID: pMtrtxS2QqKzYiiMiOok4Q== X-CSE-MsgGUID: Ydf4K/UpR8anBuZiejN56Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,168,1770624000"; d="scan'208";a="227586491" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa006.jf.intel.com with ESMTP; 08 Apr 2026 14:14:14 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id C928C95; Wed, 08 Apr 2026 23:14:13 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Lukas Wunner , Andrew Morton Subject: [PATCH v3 1/1] mtd: cfi_cmdset_0001: Factor out do_write_buffer_locked() to reduce stack frame Date: Wed, 8 Apr 2026 23:11:48 +0200 Message-ID: <20260408211407.2295175-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260408_141420_125135_8A88F935 X-CRM114-Status: GOOD ( 18.45 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Q29tcGlsZXIgaXMgbm90IGhhcHB5IGFib3V0IHVzZWQgc3RhY2sgZnJhbWU6Cgpkcml2ZXJzL210 ZC9jaGlwcy9jZmlfY21kc2V0XzAwMDEuYzogSW4gZnVuY3Rpb24gJ2RvX3dyaXRlX2J1ZmZlcic6 CmRyaXZlcnMvbXRkL2NoaXBzL2NmaV9jbWRzZXRfMDAwMS5jOjE4ODc6MTogZXJyb3I6IHRoZSBm cmFtZSBzaXplIG9mIDEyOTYgYnl0ZXMgaXMgbGFyZ2VyIHRoYW4gMTI4MCBieXRlcyBbLVdlcnJv cj1mcmFtZS1sYXJnZXItdGhhbj1dCgpGaXggdGhpcyBieSBmYWN0b3Jpbmcgb3V0IGRvX3dyaXRl X2J1ZmZlcl9sb2NrZWQoKS4KClNpZ25lZC1vZmYtYnk6IEFuZHkgU2hldmNoZW5rbyA8YW5kcml5 LnNoZXZjaGVua29AbGludXguaW50ZWwuY29tPgotLS0KdjM6IGFkZHJlc3NlZCBzZXQgYnV0IHVu dXNlZCB2YXJpYWJsZXMgd2hlbiBNVERfWElQPXkgKExLUCkKdjI6IGtlcHQgRElTL0VOQUJMRV9W UFAgcGFpcmVkCgogZHJpdmVycy9tdGQvY2hpcHMvY2ZpX2NtZHNldF8wMDAxLmMgfCA4OCArKysr KysrKysrKysrKysrKy0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDUxIGluc2VydGlvbnMo KyksIDM3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL2NoaXBzL2NmaV9j bWRzZXRfMDAwMS5jIGIvZHJpdmVycy9tdGQvY2hpcHMvY2ZpX2NtZHNldF8wMDAxLmMKaW5kZXgg NWE0ZDJlMTZhOWQxLi43NzMzZTA3NmFkNDAgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvbXRkL2NoaXBz L2NmaV9jbWRzZXRfMDAwMS5jCisrKyBiL2RyaXZlcnMvbXRkL2NoaXBzL2NmaV9jbWRzZXRfMDAw MS5jCkBAIC0xMTU0LDcgKzExNTQsOCBAQCBzdGF0aWMgdm9pZCBfX3hpcHJhbSB4aXBfZW5hYmxl KHN0cnVjdCBtYXBfaW5mbyAqbWFwLCBzdHJ1Y3QgZmxjaGlwICpjaGlwLAogCiBzdGF0aWMgaW50 IF9feGlwcmFtIHhpcF93YWl0X2Zvcl9vcGVyYXRpb24oCiAJCXN0cnVjdCBtYXBfaW5mbyAqbWFw LCBzdHJ1Y3QgZmxjaGlwICpjaGlwLAotCQl1bnNpZ25lZCBsb25nIGFkciwgdW5zaWduZWQgaW50 IGNoaXBfb3BfdGltZV9tYXgpCisJCXVuc2lnbmVkIGxvbmcgYWRyLCB1bnNpZ25lZCBsb25nIGlu dmFsX2FkciwgaW50IGludmFsX2xlbiwKKwkJdW5zaWduZWQgaW50IGNoaXBfb3BfdGltZSwgdW5z aWduZWQgaW50IGNoaXBfb3BfdGltZV9tYXgpCiB7CiAJc3RydWN0IGNmaV9wcml2YXRlICpjZmkg PSBtYXAtPmZsZHJ2X3ByaXY7CiAJc3RydWN0IGNmaV9wcmlfaW50ZWxleHQgKmNmaXAgPSBjZmkt PmNtZHNldF9wcml2OwpAQCAtMTI3Niw4ICsxMjc3LDcgQEAgc3RhdGljIGludCBfX3hpcHJhbSB4 aXBfd2FpdF9mb3Jfb3BlcmF0aW9uKAogI2RlZmluZSBYSVBfSU5WQUxfQ0FDSEVEX1JBTkdFKG1h cCwgZnJvbSwgc2l6ZSkgIFwKIAlJTlZBTElEQVRFX0NBQ0hFRF9SQU5HRShtYXAsIGZyb20sIHNp emUpCiAKLSNkZWZpbmUgSU5WQUxfQ0FDSEVfQU5EX1dBSVQobWFwLCBjaGlwLCBjbWRfYWRyLCBp bnZhbF9hZHIsIGludmFsX2xlbiwgdXNlYywgdXNlY19tYXgpIFwKLQl4aXBfd2FpdF9mb3Jfb3Bl cmF0aW9uKG1hcCwgY2hpcCwgY21kX2FkciwgdXNlY19tYXgpCisjZGVmaW5lIElOVkFMX0NBQ0hF X0FORF9XQUlUIHhpcF93YWl0X2Zvcl9vcGVyYXRpb24KIAogI2Vsc2UKIApAQCAtMTcyMCw0MiAr MTcyMCwyNCBAQCBzdGF0aWMgaW50IGNmaV9pbnRlbGV4dF93cml0ZV93b3JkcyAoc3RydWN0IG10 ZF9pbmZvICptdGQsIGxvZmZfdCB0byAsIHNpemVfdCBsZQogfQogCiAKLXN0YXRpYyBpbnQgX194 aXByYW0gZG9fd3JpdGVfYnVmZmVyKHN0cnVjdCBtYXBfaW5mbyAqbWFwLCBzdHJ1Y3QgZmxjaGlw ICpjaGlwLAotCQkJCSAgICB1bnNpZ25lZCBsb25nIGFkciwgY29uc3Qgc3RydWN0IGt2ZWMgKipw dmVjLAotCQkJCSAgICB1bnNpZ25lZCBsb25nICpwdmVjX3NlZWssIGludCBsZW4pCitzdGF0aWMg aW50IF9feGlwcmFtIGRvX3dyaXRlX2J1ZmZlcl9sb2NrZWQoc3RydWN0IG1hcF9pbmZvICptYXAs IHN0cnVjdCBmbGNoaXAgKmNoaXAsCisJCQkJCSAgIHVuc2lnbmVkIGxvbmcgY21kX2FkciwgdW5z aWduZWQgbG9uZyBhZHIsCisJCQkJCSAgIGNvbnN0IHN0cnVjdCBrdmVjICoqcHZlYywKKwkJCQkJ ICAgdW5zaWduZWQgbG9uZyAqcHZlY19zZWVrLCBpbnQgbGVuKQogewogCXN0cnVjdCBjZmlfcHJp dmF0ZSAqY2ZpID0gbWFwLT5mbGRydl9wcml2OwogCW1hcF93b3JkIHN0YXR1cywgd3JpdGVfY21k LCBkYXR1bTsKLQl1bnNpZ25lZCBsb25nIGNtZF9hZHI7Ci0JaW50IHJldCwgd2J1ZnNpemUsIHdv cmRfZ2FwLCB3b3JkczsKKwlpbnQgcmV0LCB3b3JkX2dhcCwgd29yZHM7CiAJY29uc3Qgc3RydWN0 IGt2ZWMgKnZlYzsKIAl1bnNpZ25lZCBsb25nIHZlY19zZWVrOwogCXVuc2lnbmVkIGxvbmcgaW5p dGlhbF9hZHI7CiAJaW50IGluaXRpYWxfbGVuID0gbGVuOwogCi0Jd2J1ZnNpemUgPSBjZmlfaW50 ZXJsZWF2ZShjZmkpIDw8IGNmaS0+Y2ZpcS0+TWF4QnVmV3JpdGVTaXplOwotCWFkciArPSBjaGlw LT5zdGFydDsKIAlpbml0aWFsX2FkciA9IGFkcjsKLQljbWRfYWRyID0gYWRyICYgfih3YnVmc2l6 ZS0xKTsKLQotCS8qIFNoYXJwIExIMjhGNjQwQkYgY2hpcHMgbmVlZCB0aGUgZmlyc3QgYWRkcmVz cyBmb3IgdGhlCi0JICogUGFnZSBCdWZmZXIgUHJvZ3JhbSBjb21tYW5kLiBTZWUgVGFibGUgNSBv ZgotCSAqIExIMjhGMzIwQkYsIExIMjhGNjQwQkYsIExIMjhGMTI4QkYgU2VyaWVzIChBcHBlbmRp eCBGVU0wMDcwMSkgKi8KLQlpZiAoaXNfTEgyOEY2NDBCRihjZmkpKQotCQljbWRfYWRyID0gYWRy OwogCiAJLyogTGV0J3MgZGV0ZXJtaW5lIHRoaXMgYWNjb3JkaW5nIHRvIHRoZSBpbnRlcmxlYXZl IG9ubHkgb25jZSAqLwogCXdyaXRlX2NtZCA9IChjZmktPmNmaXEtPlBfSUQgIT0gUF9JRF9JTlRF TF9QRVJGT1JNQU5DRSkgPyBDTUQoMHhlOCkgOiBDTUQoMHhlOSk7CiAKLQltdXRleF9sb2NrKCZj aGlwLT5tdXRleCk7Ci0JcmV0ID0gZ2V0X2NoaXAobWFwLCBjaGlwLCBjbWRfYWRyLCBGTF9XUklU SU5HKTsKLQlpZiAocmV0KSB7Ci0JCW11dGV4X3VubG9jaygmY2hpcC0+bXV0ZXgpOwotCQlyZXR1 cm4gcmV0OwotCX0KLQotCVhJUF9JTlZBTF9DQUNIRURfUkFOR0UobWFwLCBpbml0aWFsX2Fkciwg aW5pdGlhbF9sZW4pOwotCUVOQUJMRV9WUFAobWFwKTsKIAl4aXBfZGlzYWJsZShtYXAsIGNoaXAs IGNtZF9hZHIpOwogCiAJLyogwqc0Ljggb2YgdGhlIDI4Rnh4eEozQSBkYXRhc2hlZXQgc2F5cyAi QW55IHRpbWUgU1IuNCBhbmQvb3IgU1IuNSBpcyBzZXQKQEAgLTE3ODksNyArMTc3MSw3IEBAIHN0 YXRpYyBpbnQgX194aXByYW0gZG9fd3JpdGVfYnVmZmVyKHN0cnVjdCBtYXBfaW5mbyAqbWFwLCBz dHJ1Y3QgZmxjaGlwICpjaGlwLAogCQl4aXBfZW5hYmxlKG1hcCwgY2hpcCwgY21kX2Fkcik7CiAJ CXByaW50ayhLRVJOX0VSUiAiJXM6IENoaXAgbm90IHJlYWR5IGZvciBidWZmZXIgd3JpdGUuIFhz dGF0dXMgPSAlbHgsIHN0YXR1cyA9ICVseFxuIiwKIAkJCQltYXAtPm5hbWUsIFhzdGF0dXMueFsw XSwgc3RhdHVzLnhbMF0pOwotCQlnb3RvIG91dDsKKwkJcmV0dXJuIHJldDsKIAl9CiAKIAkvKiBG aWd1cmUgb3V0IHRoZSBudW1iZXIgb2Ygd29yZHMgdG8gd3JpdGUgKi8KQEAgLTE4NTMsNyArMTgz NSw3IEBAIHN0YXRpYyBpbnQgX194aXByYW0gZG9fd3JpdGVfYnVmZmVyKHN0cnVjdCBtYXBfaW5m byAqbWFwLCBzdHJ1Y3QgZmxjaGlwICpjaGlwLAogCQljaGlwLT5zdGF0ZSA9IEZMX1NUQVRVUzsK IAkJeGlwX2VuYWJsZShtYXAsIGNoaXAsIGNtZF9hZHIpOwogCQlwcmludGsoS0VSTl9FUlIgIiVz OiBidWZmZXIgd3JpdGUgZXJyb3IgKHN0YXR1cyB0aW1lb3V0KVxuIiwgbWFwLT5uYW1lKTsKLQkJ Z290byBvdXQ7CisJCXJldHVybiByZXQ7CiAJfQogCiAJLyogY2hlY2sgZm9yIGVycm9ycyAqLwpA QCAtMTg2NiwyMSArMTg0OCw1MyBAQCBzdGF0aWMgaW50IF9feGlwcmFtIGRvX3dyaXRlX2J1ZmZl cihzdHJ1Y3QgbWFwX2luZm8gKm1hcCwgc3RydWN0IGZsY2hpcCAqY2hpcCwKIAkJbWFwX3dyaXRl KG1hcCwgQ01EKDB4NzApLCBjbWRfYWRyKTsKIAkJeGlwX2VuYWJsZShtYXAsIGNoaXAsIGNtZF9h ZHIpOwogCi0JCWlmIChjaGlwc3RhdHVzICYgMHgwMikgewotCQkJcmV0ID0gLUVST0ZTOwotCQl9 IGVsc2UgaWYgKGNoaXBzdGF0dXMgJiAweDA4KSB7CisJCWlmIChjaGlwc3RhdHVzICYgMHgwMikK KwkJCXJldHVybiAtRVJPRlM7CisKKwkJaWYgKGNoaXBzdGF0dXMgJiAweDA4KSB7CiAJCQlwcmlu dGsoS0VSTl9FUlIgIiVzOiBidWZmZXIgd3JpdGUgZXJyb3IgKGJhZCBWUFApXG4iLCBtYXAtPm5h bWUpOwotCQkJcmV0ID0gLUVJTzsKLQkJfSBlbHNlIHsKLQkJCXByaW50ayhLRVJOX0VSUiAiJXM6 IGJ1ZmZlciB3cml0ZSBlcnJvciAoc3RhdHVzIDB4JWx4KVxuIiwgbWFwLT5uYW1lLCBjaGlwc3Rh dHVzKTsKLQkJCXJldCA9IC1FSU5WQUw7CisJCQlyZXR1cm4gIC1FSU87CiAJCX0KIAotCQlnb3Rv IG91dDsKKwkJcHJpbnRrKEtFUk5fRVJSICIlczogYnVmZmVyIHdyaXRlIGVycm9yIChzdGF0dXMg MHglbHgpXG4iLCBtYXAtPm5hbWUsIGNoaXBzdGF0dXMpOworCQlyZXR1cm4gLUVJTlZBTDsKIAl9 CiAKIAl4aXBfZW5hYmxlKG1hcCwgY2hpcCwgY21kX2Fkcik7Ci0gb3V0OglESVNBQkxFX1ZQUCht YXApOworCXJldHVybiAwOworfQorCitzdGF0aWMgaW50IF9feGlwcmFtIGRvX3dyaXRlX2J1ZmZl cihzdHJ1Y3QgbWFwX2luZm8gKm1hcCwgc3RydWN0IGZsY2hpcCAqY2hpcCwKKwkJCQkgICAgdW5z aWduZWQgbG9uZyBhZHIsIGNvbnN0IHN0cnVjdCBrdmVjICoqcHZlYywKKwkJCQkgICAgdW5zaWdu ZWQgbG9uZyAqcHZlY19zZWVrLCBpbnQgbGVuKQoreworCXN0cnVjdCBjZmlfcHJpdmF0ZSAqY2Zp ID0gbWFwLT5mbGRydl9wcml2OworCXVuc2lnbmVkIGxvbmcgY21kX2FkcjsKKwlpbnQgcmV0LCB3 YnVmc2l6ZTsKKworCXdidWZzaXplID0gY2ZpX2ludGVybGVhdmUoY2ZpKSA8PCBjZmktPmNmaXEt Pk1heEJ1ZldyaXRlU2l6ZTsKKwlhZHIgKz0gY2hpcC0+c3RhcnQ7CisJY21kX2FkciA9IGFkciAm IH4od2J1ZnNpemUgLSAxKTsKKworCS8qIFNoYXJwIExIMjhGNjQwQkYgY2hpcHMgbmVlZCB0aGUg Zmlyc3QgYWRkcmVzcyBmb3IgdGhlCisJICogUGFnZSBCdWZmZXIgUHJvZ3JhbSBjb21tYW5kLiBT ZWUgVGFibGUgNSBvZgorCSAqIExIMjhGMzIwQkYsIExIMjhGNjQwQkYsIExIMjhGMTI4QkYgU2Vy aWVzIChBcHBlbmRpeCBGVU0wMDcwMSkgKi8KKwlpZiAoaXNfTEgyOEY2NDBCRihjZmkpKQorCQlj bWRfYWRyID0gYWRyOworCisJbXV0ZXhfbG9jaygmY2hpcC0+bXV0ZXgpOworCXJldCA9IGdldF9j aGlwKG1hcCwgY2hpcCwgY21kX2FkciwgRkxfV1JJVElORyk7CisJaWYgKHJldCkgeworCQltdXRl eF91bmxvY2soJmNoaXAtPm11dGV4KTsKKwkJcmV0dXJuIHJldDsKKwl9CisKKwlYSVBfSU5WQUxf Q0FDSEVEX1JBTkdFKG1hcCwgYWRyLCBsZW4pOworCUVOQUJMRV9WUFAobWFwKTsKKworCXJldCA9 IGRvX3dyaXRlX2J1ZmZlcl9sb2NrZWQobWFwLCBjaGlwLCBjbWRfYWRyLCBhZHIsIHB2ZWMsIHB2 ZWNfc2VlaywgbGVuKTsKKworCURJU0FCTEVfVlBQKG1hcCk7CiAJcHV0X2NoaXAobWFwLCBjaGlw LCBjbWRfYWRyKTsKIAltdXRleF91bmxvY2soJmNoaXAtPm11dGV4KTsKIAlyZXR1cm4gcmV0Owot LSAKMi41MC4xCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ABC1346AC3 for ; Wed, 8 Apr 2026 21:14:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775682858; cv=none; b=nT+IkRGXTcju5xnA5S/hXkA6h7TquhqcHnLe5vlaLex1nMgwIJPIQOamNUzgNbl99yPNscbYfhnWuTZJzzRQTReUyB1j9uaIL2yrGhdLSvYeyJLVcd8X+kcui4q7oRhcPXhfY4wgV2c4unVbb98tHuKu+C0YBzurH9TFAwv0y1U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775682858; c=relaxed/simple; bh=9ANUT8QdPo5iyQxCYTvuSXlBIUzBWrhApFgNzvDSbLM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=qxYSAQtAXGUEoJMY3OeqgbrxsyE/I3rd+kylm4oRqFHDSkkIVLBUUScP911MSvqkP2w2SHCALoSIIAIjFz2bH7n8/TNzrbMpODLjAXlygK2upCaMON+klfBHu/905Sso9q0Kw8ansLWbLLcMvZBThexjxoEIQuOLnpGWqz/whsU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Ch14bO7v; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Ch14bO7v" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775682857; x=1807218857; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=9ANUT8QdPo5iyQxCYTvuSXlBIUzBWrhApFgNzvDSbLM=; b=Ch14bO7vtuAkDVNrSCja/bqCu+Fz9Ixu0GT6lGikxjMa9r+ukzYvqxsn lrQLTGYouQECL96Jad5nD7e9R5PAlzX2Y2mkcLYb5TFdPAoutrf6p1E8G +QW+LSzeZKxl8X8qCEZ/jYka9h+xlgTTIr/vlMhvUy1bs+hgvUFmnzDyl 2e/B5a4RX4YNQ7KUyW2Y1n+TiHx9O6ZLsvSGb5DKI+xbQjkQMRn6v7Ekm oohhdwxoYXTg6qnTZRWHVFC0l/PL5qeynFbFTOC4WY1IZTNMmft7CJX8o ujiby3RSCJYYFs0kvh4QR9nxq+rVaRWQF9p+mtBVHPMa7uavrvw+OqfHq A==; X-CSE-ConnectionGUID: AOjze7q3TnC2XSMTnGy2Lw== X-CSE-MsgGUID: 4J3DEg+8TI66xvhR6CCXTQ== X-IronPort-AV: E=McAfee;i="6800,10657,11753"; a="76583110" X-IronPort-AV: E=Sophos;i="6.23,168,1770624000"; d="scan'208";a="76583110" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2026 14:14:17 -0700 X-CSE-ConnectionGUID: pMtrtxS2QqKzYiiMiOok4Q== X-CSE-MsgGUID: Ydf4K/UpR8anBuZiejN56Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,168,1770624000"; d="scan'208";a="227586491" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa006.jf.intel.com with ESMTP; 08 Apr 2026 14:14:14 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id C928C95; Wed, 08 Apr 2026 23:14:13 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Lukas Wunner , Andrew Morton Subject: [PATCH v3 1/1] mtd: cfi_cmdset_0001: Factor out do_write_buffer_locked() to reduce stack frame Date: Wed, 8 Apr 2026 23:11:48 +0200 Message-ID: <20260408211407.2295175-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Compiler is not happy about used stack frame: drivers/mtd/chips/cfi_cmdset_0001.c: In function 'do_write_buffer': drivers/mtd/chips/cfi_cmdset_0001.c:1887:1: error: the frame size of 1296 bytes is larger than 1280 bytes [-Werror=frame-larger-than=] Fix this by factoring out do_write_buffer_locked(). Signed-off-by: Andy Shevchenko --- v3: addressed set but unused variables when MTD_XIP=y (LKP) v2: kept DIS/ENABLE_VPP paired drivers/mtd/chips/cfi_cmdset_0001.c | 88 +++++++++++++++++------------ 1 file changed, 51 insertions(+), 37 deletions(-) diff --git a/drivers/mtd/chips/cfi_cmdset_0001.c b/drivers/mtd/chips/cfi_cmdset_0001.c index 5a4d2e16a9d1..7733e076ad40 100644 --- a/drivers/mtd/chips/cfi_cmdset_0001.c +++ b/drivers/mtd/chips/cfi_cmdset_0001.c @@ -1154,7 +1154,8 @@ static void __xipram xip_enable(struct map_info *map, struct flchip *chip, static int __xipram xip_wait_for_operation( struct map_info *map, struct flchip *chip, - unsigned long adr, unsigned int chip_op_time_max) + unsigned long adr, unsigned long inval_adr, int inval_len, + unsigned int chip_op_time, unsigned int chip_op_time_max) { struct cfi_private *cfi = map->fldrv_priv; struct cfi_pri_intelext *cfip = cfi->cmdset_priv; @@ -1276,8 +1277,7 @@ static int __xipram xip_wait_for_operation( #define XIP_INVAL_CACHED_RANGE(map, from, size) \ INVALIDATE_CACHED_RANGE(map, from, size) -#define INVAL_CACHE_AND_WAIT(map, chip, cmd_adr, inval_adr, inval_len, usec, usec_max) \ - xip_wait_for_operation(map, chip, cmd_adr, usec_max) +#define INVAL_CACHE_AND_WAIT xip_wait_for_operation #else @@ -1720,42 +1720,24 @@ static int cfi_intelext_write_words (struct mtd_info *mtd, loff_t to , size_t le } -static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip, - unsigned long adr, const struct kvec **pvec, - unsigned long *pvec_seek, int len) +static int __xipram do_write_buffer_locked(struct map_info *map, struct flchip *chip, + unsigned long cmd_adr, unsigned long adr, + const struct kvec **pvec, + unsigned long *pvec_seek, int len) { struct cfi_private *cfi = map->fldrv_priv; map_word status, write_cmd, datum; - unsigned long cmd_adr; - int ret, wbufsize, word_gap, words; + int ret, word_gap, words; const struct kvec *vec; unsigned long vec_seek; unsigned long initial_adr; int initial_len = len; - wbufsize = cfi_interleave(cfi) << cfi->cfiq->MaxBufWriteSize; - adr += chip->start; initial_adr = adr; - cmd_adr = adr & ~(wbufsize-1); - - /* Sharp LH28F640BF chips need the first address for the - * Page Buffer Program command. See Table 5 of - * LH28F320BF, LH28F640BF, LH28F128BF Series (Appendix FUM00701) */ - if (is_LH28F640BF(cfi)) - cmd_adr = adr; /* Let's determine this according to the interleave only once */ write_cmd = (cfi->cfiq->P_ID != P_ID_INTEL_PERFORMANCE) ? CMD(0xe8) : CMD(0xe9); - mutex_lock(&chip->mutex); - ret = get_chip(map, chip, cmd_adr, FL_WRITING); - if (ret) { - mutex_unlock(&chip->mutex); - return ret; - } - - XIP_INVAL_CACHED_RANGE(map, initial_adr, initial_len); - ENABLE_VPP(map); xip_disable(map, chip, cmd_adr); /* ยง4.8 of the 28FxxxJ3A datasheet says "Any time SR.4 and/or SR.5 is set @@ -1789,7 +1771,7 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip, xip_enable(map, chip, cmd_adr); printk(KERN_ERR "%s: Chip not ready for buffer write. Xstatus = %lx, status = %lx\n", map->name, Xstatus.x[0], status.x[0]); - goto out; + return ret; } /* Figure out the number of words to write */ @@ -1853,7 +1835,7 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip, chip->state = FL_STATUS; xip_enable(map, chip, cmd_adr); printk(KERN_ERR "%s: buffer write error (status timeout)\n", map->name); - goto out; + return ret; } /* check for errors */ @@ -1866,21 +1848,53 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip, map_write(map, CMD(0x70), cmd_adr); xip_enable(map, chip, cmd_adr); - if (chipstatus & 0x02) { - ret = -EROFS; - } else if (chipstatus & 0x08) { + if (chipstatus & 0x02) + return -EROFS; + + if (chipstatus & 0x08) { printk(KERN_ERR "%s: buffer write error (bad VPP)\n", map->name); - ret = -EIO; - } else { - printk(KERN_ERR "%s: buffer write error (status 0x%lx)\n", map->name, chipstatus); - ret = -EINVAL; + return -EIO; } - goto out; + printk(KERN_ERR "%s: buffer write error (status 0x%lx)\n", map->name, chipstatus); + return -EINVAL; } xip_enable(map, chip, cmd_adr); - out: DISABLE_VPP(map); + return 0; +} + +static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip, + unsigned long adr, const struct kvec **pvec, + unsigned long *pvec_seek, int len) +{ + struct cfi_private *cfi = map->fldrv_priv; + unsigned long cmd_adr; + int ret, wbufsize; + + wbufsize = cfi_interleave(cfi) << cfi->cfiq->MaxBufWriteSize; + adr += chip->start; + cmd_adr = adr & ~(wbufsize - 1); + + /* Sharp LH28F640BF chips need the first address for the + * Page Buffer Program command. See Table 5 of + * LH28F320BF, LH28F640BF, LH28F128BF Series (Appendix FUM00701) */ + if (is_LH28F640BF(cfi)) + cmd_adr = adr; + + mutex_lock(&chip->mutex); + ret = get_chip(map, chip, cmd_adr, FL_WRITING); + if (ret) { + mutex_unlock(&chip->mutex); + return ret; + } + + XIP_INVAL_CACHED_RANGE(map, adr, len); + ENABLE_VPP(map); + + ret = do_write_buffer_locked(map, chip, cmd_adr, adr, pvec, pvec_seek, len); + + DISABLE_VPP(map); put_chip(map, chip, cmd_adr); mutex_unlock(&chip->mutex); return ret; -- 2.50.1