From: Kuniyuki Iwashima <kuniyu@google.com>
To: marcharvey@google.com
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
horms@kernel.org, jiri@resnulli.us, kuba@kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com, shuah@kernel.org
Subject: Re: [PATCH net-next v6 00/10] Decouple receive and transmit enablement in team driver
Date: Thu, 9 Apr 2026 01:48:59 +0000 [thread overview]
Message-ID: <20260409015007.3741559-1-kuniyu@google.com> (raw)
In-Reply-To: <CANkEMgk16j2xzQ85JGQ4OWqeiwiVO5Gy-UfkN3omKkKizpLxiQ@mail.gmail.com>
From: Marc Harvey <marcharvey@google.com>
Date: Wed, 8 Apr 2026 17:10:05 -0700
> On Wed, Apr 8, 2026 at 9:40 AM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > It pains me to report on non-debug kernels:
>
> I'm sorry to have pained you. Despite my best efforts to run with the
> exact same environment and conditions as your CI, my teamd can be
> killed with "teamd -k" but yours hangs (both are version 1.32 on
> Fedora with the same kernel config).
Considering the subsequent "kill" works on the dbg instance (thanks
to 2400s timeout), I guess teamd is somehow stuck at SIGTERM handling
removing team devices in teamd_port_remove_all(). (SIGTERM being masked
sounds unlikely)
https://netdev-ctrl.bots.linux.dev/logs/vmksft/bonding-dbg/results/593802/4-teamd-activebackup-sh/stdout
https://netdev-ctrl.bots.linux.dev/logs/vmksft/bonding-dbg/results/593802/4-teamd-activebackup-sh/stderr
---8<---
[ 759.819815][T21724] test_team1: Port device eth1 removed
[ 759.822323][T21724] test_team1: Port device eth0 removed
[ 790.615687][T21728] test_team2: Port device eth1 removed
[ 790.617445][T21728] test_team2: Port device eth0 removed
---8<---
Adding -N and letting "ip netns del" release the last netns refcnt
and defer device destruction to cleanup_net() may help.
> For v7, I’ll invoke "teamd -k"
> using the timeout utility, or just increase the test timeout.
+1 for the latter, maybe set timeout=300.
daemon_pid_file_kill_wait(SIGTERM, 30) * 2 = 120s, but just in case.
See these files for howto:
$ find tools/testing/selftests/net/ -name settings
prev parent reply other threads:[~2026-04-09 1:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 2:52 [PATCH net-next v6 00/10] Decouple receive and transmit enablement in team driver Marc Harvey
2026-04-08 2:52 ` [PATCH net-next v6 01/10] net: team: Annotate reads and writes for mixed lock accessed values Marc Harvey
2026-04-08 2:52 ` [PATCH net-next v6 02/10] net: team: Remove unused team_mode_op, port_enabled Marc Harvey
2026-04-08 2:52 ` [PATCH net-next v6 03/10] net: team: Rename port_disabled team mode op to port_tx_disabled Marc Harvey
2026-04-08 9:02 ` Jiri Pirko
2026-04-08 2:52 ` [PATCH net-next v6 04/10] selftests: net: Add tests for failover of team-aggregated ports Marc Harvey
2026-04-08 2:52 ` [PATCH net-next v6 05/10] selftests: net: Add test for enablement of ports with teamd Marc Harvey
2026-04-08 2:52 ` [PATCH net-next v6 06/10] net: team: Rename enablement functions and struct members to tx Marc Harvey
2026-04-08 2:52 ` [PATCH net-next v6 07/10] net: team: Track rx enablement separately from tx enablement Marc Harvey
2026-04-08 2:52 ` [PATCH net-next v6 08/10] net: team: Add new rx_enabled team port option Marc Harvey
2026-04-08 2:52 ` [PATCH net-next v6 09/10] net: team: Add new tx_enabled " Marc Harvey
2026-04-08 2:52 ` [PATCH net-next v6 10/10] selftests: net: Add tests for team driver decoupled tx and rx control Marc Harvey
2026-04-08 16:40 ` [PATCH net-next v6 00/10] Decouple receive and transmit enablement in team driver Jakub Kicinski
2026-04-09 0:10 ` Marc Harvey
2026-04-09 0:31 ` Jakub Kicinski
2026-04-09 1:48 ` Kuniyuki Iwashima [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260409015007.3741559-1-kuniyu@google.com \
--to=kuniyu@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=marcharvey@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.