From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-multipath: drop head pointer check in nvme_mpath_clear_current_path()
Date: Thu, 9 Apr 2026 08:11:46 +0200 [thread overview]
Message-ID: <20260409061146.GA6514@lst.de> (raw)
In-Reply-To: <20260408080357.3072749-1-john.g.garry@oracle.com>
On Wed, Apr 08, 2026 at 08:03:57AM +0000, John Garry wrote:
> A NS will always have a head pointer, so drop the check. As proof in
> practice, all the nvme_mpath_clear_current_path() callers also
> dereference ns->head.
>
> This check has endured since the original changes to support multipath.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-04-09 6:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 8:03 [PATCH] nvme-multipath: drop head pointer check in nvme_mpath_clear_current_path() John Garry
2026-04-09 6:11 ` Christoph Hellwig [this message]
2026-04-09 14:21 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260409061146.GA6514@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.