From: Jakub Kicinski <kuba@kernel.org>
To: Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>,
Michael Chan <michael.chan@broadcom.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Petr Machata <petrm@nvidia.com>, David Wei <dw@davidwei.uk>,
Chris J Arges <carges@cloudflare.com>,
Carolina Jubran <cjubran@nvidia.com>,
Dimitri Daskalakis <daskald@meta.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] selftests: drv-net: Add ntuple (NFC) flow steering test
Date: Thu, 9 Apr 2026 08:50:55 -0700 [thread overview]
Message-ID: <20260409085055.0834111c@kernel.org> (raw)
In-Reply-To: <20260407164954.2977820-2-dimitri.daskalakis1@gmail.com>
On Tue, 7 Apr 2026 09:49:53 -0700 Dimitri Daskalakis wrote:
> Add a test for ethtool NFC (ntuple) flow steering rules. The test
> creates an ntuple rule matching on various flow fields and verifies
> that traffic is steered to the correct queue.
Hi Michael, how accurate is the stats refresh timer in bnxt?
This test is seeing ~10% of flakiness on bnxt, fewer packets
got counted than we sent. Could be something else but I suspect
the stats just didn't get refreshed. We give it 25% margin right
now.
Dimitiri, this skips for some drivers because they don't auto-enable
ntuple filters. Looks like other selftests have the same check and also
skip in netdev CI. So probably a separate / follow up task but I think
we need to add code to enable the filters if they were disabled.
next prev parent reply other threads:[~2026-04-09 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 16:49 [PATCH net-next 0/2] Add selftests for ntuple (NFC) rules Dimitri Daskalakis
2026-04-07 16:49 ` [PATCH net-next 1/2] selftests: drv-net: Add ntuple (NFC) flow steering test Dimitri Daskalakis
2026-04-09 15:50 ` Jakub Kicinski [this message]
2026-04-09 20:28 ` Dimitri Daskalakis
2026-04-07 16:49 ` [PATCH net-next 2/2] selftests: drv-net: ntuple: Add dst-ip, src-port, dst-port fields Dimitri Daskalakis
2026-04-10 22:40 ` [PATCH net-next 0/2] Add selftests for ntuple (NFC) rules patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260409085055.0834111c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=carges@cloudflare.com \
--cc=cjubran@nvidia.com \
--cc=daskald@meta.com \
--cc=davem@davemloft.net \
--cc=dimitri.daskalakis1@gmail.com \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.