Re: [PATCH] mfd: si476x: Modernize GPIO handling

[Lee Jones <lee@kernel.org>]

On Fri, 27 Mar 2026, Linus Walleij wrote:

> The SI476X driver depends on the legacy GPIO API. As it only
> really use a single GPIO for reset, and this can be easily converted
> to use a GPIO descriptor, modernize the driver.
> 
> The "reset" GPIO is obtained from a device property, such as a
> device tree ("reset-gpios", which is standard, but this hardware has
> no DT bindings as of now) or a software node for static platforms.
> 
> Out-of-tree users can easily adopt to providing a GPIO descriptor
> this way.
> 
> Signed-off-by: Linus Walleij <linusw@kernel.org>
> ---
>  drivers/mfd/Kconfig                 |  1 -
>  drivers/mfd/si476x-cmd.c            |  1 -
>  drivers/mfd/si476x-i2c.c            | 46 +++++++++++++------------------------
>  include/linux/mfd/si476x-core.h     |  5 ++--
>  include/linux/mfd/si476x-platform.h |  2 --
>  5 files changed, 19 insertions(+), 36 deletions(-)

Doesn't seem to want to apply:

diff a/include/linux/mfd/si476x-core.h b/include/linux/mfd/si476x-core.h        (rejected hunks)
@@ -103,7 +104,7 @@ enum si476x_power_state {
  * @state: Current power state of the device.
  * @supplues: Structure containing handles to all power supplies used
  * by the device (NULL ones are ignored).
- * @gpio_reset: GPIO pin connectet to the RSTB pin of the chip.
+ * @reset: GPIO connected to the RSTB pin of the chip.
  * @pinmux: Chip's configurable pins configuration.
  * @diversity_mode: Chips role when functioning in diversity mode.
  * @status_monitor: Polling worker used in polling use case scenarion

-- 
Lee Jones [李琼斯]