All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Tso" <tytso@mit.edu>
To: Li Chen <me@linux.beauty>
Cc: Zhang Yi <yi.zhang@huaweicloud.com>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	linux-ext4@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC v4 0/7] ext4: fast commit: snapshot inode state for FC log
Date: Thu, 9 Apr 2026 21:18:43 -0400	[thread overview]
Message-ID: <20260410011843.GD99725@macsyma-wired.lan> (raw)
In-Reply-To: <20260120112538.132774-1-me@linux.beauty>

On Tue, Jan 20, 2026 at 07:25:29PM +0800, Li Chen wrote:
> Hi,
> 
> (This RFC v4 series is based on linux-next tag next-20260106, plus the
> prerequisite patch "ext4: fast commit: make s_fc_lock reclaim-safe" posted at:
> https://lore.kernel.org/all/20260106120621.440126-1-me@linux.beauty/)

Can you take a look at the Sashiko reviews here:

    https://sashiko.dev/#/patchset/20260408112020.716706-1-me%40linux.beauty

There seems to be at least one legitimate concern, which is the
potential cur_lblk overflow.  There are a couple of others which I
think is real; could you please look at their review comments?

Thanks,

					- Ted

  parent reply	other threads:[~2026-04-10  1:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-20 11:25 [RFC v4 0/7] ext4: fast commit: snapshot inode state for FC log Li Chen
2026-01-20 11:25 ` [RFC v4 1/7] ext4: fast commit: snapshot inode state before writing log Li Chen
2026-01-20 11:25 ` [RFC v4 2/7] ext4: lockdep: handle i_data_sem subclassing for special inodes Li Chen
2026-01-20 11:25 ` [RFC v4 3/7] ext4: fast commit: avoid waiting for FC_COMMITTING Li Chen
2026-01-20 11:25 ` [RFC v4 4/7] ext4: fast commit: avoid self-deadlock in inode snapshotting Li Chen
2026-01-20 11:25 ` [RFC v4 5/7] ext4: fast commit: avoid i_data_sem by dropping ext4_map_blocks() in snapshots Li Chen
2026-01-20 11:25 ` [RFC v4 6/7] ext4: fast commit: add lock_updates tracepoint Li Chen
2026-01-23 17:57   ` Steven Rostedt
2026-01-27 12:05     ` Li Chen
2026-01-20 11:25 ` [RFC v4 7/7] ext4: fast commit: export snapshot stats in fc_info Li Chen
2026-04-10  1:18 ` Theodore Tso [this message]
2026-04-13 13:01   ` [RFC v4 0/7] ext4: fast commit: snapshot inode state for FC log Li Chen
2026-04-13 13:12     ` Theodore Tso
2026-04-20  9:37       ` Li Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260410011843.GD99725@macsyma-wired.lan \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=me@linux.beauty \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=yi.zhang@huaweicloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.