All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: buildroot@buildroot.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH v2 1/2] package/libnl: enable host package variant
Date: Sat, 11 Apr 2026 09:25:19 +0200	[thread overview]
Message-ID: <20260411072519.GA179902@pevik> (raw)
In-Reply-To: <20260408193359.4047938-1-giulio.benetti@benettiengineering.com>

Hi Giulio,

> host-libnl is needed for host-nfs-utils.
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * drop HOST_LIBNL_INSTALL_STAGING = YES as pointed by Thomas Petazzoni
> ---
>  package/libnl/libnl.mk | 3 +++
>  1 file changed, 3 insertions(+)

> diff --git a/package/libnl/libnl.mk b/package/libnl/libnl.mk
> index a0441b7835..b1254d2ba0 100644
> --- a/package/libnl/libnl.mk
> +++ b/package/libnl/libnl.mk
> @@ -13,6 +13,8 @@ LIBNL_CPE_ID_VALID = YES
>  LIBNL_INSTALL_STAGING = YES
>  LIBNL_DEPENDENCIES = host-bison host-flex host-pkgconf

> +HOST_LIBNL_DEPENDENCIES = host-bison host-flex host-pkgconf

I would personally reuse already defined variable:
HOST_LIBNL_DEPENDENCIES = $(LIBNL_DEPENDENCIES)
but I know that's not how is usually in Buildroot defined.

Kind regards,
Petr

> +
>  ifeq ($(BR2_PACKAGE_LIBNL_TOOLS),y)
>  LIBNL_CONF_OPTS += --enable-cli
>  else
> @@ -27,3 +29,4 @@ LIBNL_CONF_OPTS += --disable-unit-tests
>  endif

>  $(eval $(autotools-package))
> +$(eval $(host-autotools-package))
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2026-04-11  7:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08 19:33 [Buildroot] [PATCH v2 1/2] package/libnl: enable host package variant Giulio Benetti
2026-04-08 19:33 ` [Buildroot] [PATCH v2 2/2] package/nfs-utils: bump version to 2.9.1 Giulio Benetti
2026-04-11  7:31   ` Petr Vorel
2026-04-11  7:25 ` Petr Vorel [this message]
2026-04-19 22:03 ` [Buildroot] [PATCH v2 1/2] package/libnl: enable host package variant Julien Olivain via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260411072519.GA179902@pevik \
    --to=petr.vorel@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.